Feature/remove reagent atom from theme #19706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (11)
|
ibrkhalil
approved these changes
Apr 18, 2024
|
|
||
| if test -n "$INVALID_CHANGES"; then | ||
| echo "WARNING: re-frame, status-im are not allowed in quo components" | ||
| echo "WARNING: re-frame, status-im, regent atoms are not allowed in quo components" |
clauxx
approved these changes
Apr 18, 2024
92% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (48)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
|
flexsurfer
force-pushed
the
feature/remove-reagent-atom-from-theme
branch
from
eb44b88 to
334f962
Compare
|
Hi @flexsurfer ! Thanks for tons of work! A few minor point described below 👇 ISSUE 1: status bar is black in a dark theme Devices: iOS 13 (17.3.1) Samsung A34 (14.0) Steps:
Actual result: Expected result: https://www.figma.com/file/h9wo4GipgZURbqqr1vShFN/Communities-for-Mobile?type=design&node-id=0-1&mode=design&t=ZZJtrLI3PA3FmD16-0 |
|
ISSUE 2: black stripe on Profile Settings screens Devices: iOS 13 (17.3.1) Samsung A34 (14.0) Steps:
Actual result: 
|
|
thanks @mariia-skrypnyk all will be fixed in the followup PRs |
90% of end-end tests have passedFailed tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove reagent atom from theme
based on approved #19660
so only one commit should be reviewed 1f7018b
for QA: theme of all components affected