Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ens name verication text alignment #20018

Merged
merged 1 commit into from
May 22, 2024
Merged

fix ens name verication text alignment #20018

merged 1 commit into from
May 22, 2024

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented May 14, 2024

fixes #20010

Summary

This pr. fixes the verification text for an ENS or a Chat key and refactors the some styles acording to our guidelines

Before and after screenshots comparison

status: ready

@jo-mut jo-mut force-pushed the bug/verification-text-aligment branch from d4e1dfc to e5061c9 Compare May 14, 2024 13:51
@status-im-auto
Copy link
Member

status-im-auto commented May 14, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (13)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e5061c9 #2 2024-05-14 13:57:12 ~4 min tests 📄log
✔️ 98835a1 #5 2024-05-14 14:10:44 ~6 min tests 📄log
✔️ 98835a1 #5 2024-05-14 14:15:32 ~11 min ios 📱ipa 📲
✔️ 98835a1 #5 2024-05-14 14:16:22 ~12 min android-e2e 🤖apk 📲
✔️ 98835a1 #5 2024-05-14 14:16:24 ~12 min android 🤖apk 📲
✔️ d521eb3 #6 2024-05-15 00:17:39 ~7 min tests 📄log
✔️ d521eb3 #6 2024-05-15 00:19:39 ~9 min ios 📱ipa 📲
✔️ d521eb3 #6 2024-05-15 00:21:57 ~12 min android-e2e 🤖apk 📲
✔️ d521eb3 #6 2024-05-15 00:22:26 ~12 min android 🤖apk 📲
✔️ d0c2c48 #7 2024-05-21 18:48:39 ~4 min tests 📄log
✔️ d0c2c48 #7 2024-05-21 18:52:13 ~7 min android 🤖apk 📲
✔️ d0c2c48 #7 2024-05-21 18:52:55 ~8 min android-e2e 🤖apk 📲
✔️ d0c2c48 #7 2024-05-21 18:53:51 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 2817fc7 #8 2024-05-21 21:46:55 ~5 min tests 📄log
✔️ 2817fc7 #8 2024-05-21 21:48:46 ~7 min android-e2e 🤖apk 📲
✔️ 2817fc7 #8 2024-05-21 21:48:50 ~7 min android 🤖apk 📲
✔️ 2817fc7 #8 2024-05-21 21:50:56 ~9 min ios 📱ipa 📲
✔️ 884f5e3 #9 2024-05-22 08:08:40 ~6 min tests 📄log
✔️ 884f5e3 #9 2024-05-22 08:11:27 ~9 min ios 📱ipa 📲
✔️ 884f5e3 #9 2024-05-22 08:14:16 ~12 min android-e2e 🤖apk 📲
✔️ 884f5e3 #9 2024-05-22 08:14:31 ~12 min android 🤖apk 📲

@jo-mut jo-mut force-pushed the bug/verification-text-aligment branch 2 times, most recently from a90787e to 98835a1 Compare May 14, 2024 14:03
@jo-mut jo-mut requested review from flexsurfer and Parveshdhull May 15, 2024 00:08
@jo-mut jo-mut self-assigned this May 15, 2024
@jo-mut jo-mut marked this pull request as ready for review May 15, 2024 00:08
@jo-mut jo-mut force-pushed the bug/verification-text-aligment branch from 98835a1 to d521eb3 Compare May 15, 2024 00:09
@jo-mut jo-mut changed the title refactored some styles and fixed text alignment fix ens name verication text alignment May 18, 2024
@qoqobolo qoqobolo self-assigned this May 21, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 727230,704613,727229,702807,702775 

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find `Button` by `xpath`: `//*[@text="open community"]`
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:99: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:86: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:80: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Thanks for the fix @jo-mut!
    PR can be merged.

    @jo-mut jo-mut force-pushed the bug/verification-text-aligment branch 2 times, most recently from d0c2c48 to 2817fc7 Compare May 21, 2024 21:41
    @jo-mut jo-mut force-pushed the bug/verification-text-aligment branch from 2817fc7 to 884f5e3 Compare May 22, 2024 08:01
    @jo-mut jo-mut merged commit 8bd1c8d into develop May 22, 2024
    6 checks passed
    @jo-mut jo-mut deleted the bug/verification-text-aligment branch May 22, 2024 09:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @jo-mut jo-mut

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Verification message is not aligned on the "Add a contact" page
    5 participants
    @jo-mut @status-im-auto @qoqobolo @flexsurfer @Parveshdhull