-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #2883] Migrate wallet/request to latest mockups #3247
Conversation
Automated test results:test_wallet_error_messages:white_check_mark::Test Steps & Error message:
test_change_user_name:white_check_mark::Test Steps & Error message:
test_one_to_one_chat:x:Test Steps & Error message:
test_transaction_send_command[group_chat]:x:Test Steps & Error message:
test_request_transaction_from_wallet:x:Test Steps & Error message:
test_transaction_send_command[one_to_one_chat]:x:Test Steps & Error message:
test_recover_access:white_check_mark::Test Steps & Error message:
test_group_chat_send_receive_messages_and_remove_user:x:Test Steps & Error message:
test_group_chat_members:x:Test Steps & Error message:
test_transaction_send_command[wrong_password]:x:Test Steps & Error message:
test_send_transaction_from_wallet[sign_now]:x:Test Steps & Error message:
test_send_transaction_from_daap:x:Test Steps & Error message:
test_commands_on_second_app_run:x:Test Steps & Error message:
test_send_transaction_from_wallet[sign_later]:x:Test Steps & Error message:
test_send_funds_via_request[group_chat]:x:Test Steps & Error message:
test_sign_in[invalid]:white_check_mark::Test Steps & Error message:
test_eth_and_currency_balance:white_check_mark::Test Steps & Error message:
test_sign_in[valid]:white_check_mark::Test Steps & Error message:
test_send_funds_via_request[one_to_one_chat]:x:Test Steps & Error message:
test_password[logcat]:white_check_mark::Test Steps & Error message:
test_password[mismatch]:x:Test Steps & Error message:
test_password[short]:white_check_mark::Test Steps & Error message:
|
Branch: PR-3247 |
262b8ce
to
3c2fb07
Compare
new branch should has fixes for:
Branch: PR-3247 |
Remaining to fix (however it is not critical):
|
3c2fb07
to
9293808
Compare
Branch: PR-3247 all above mentioned issues are fixed. 1 new found: cant send request on iOS (send button is not shown when keyboard appears) |
Automated test results:test_password[mismatch]:white_check_mark::Test Steps & Error message:
test_password[logcat]:white_check_mark::Test Steps & Error message:
test_sign_in[invalid]:white_check_mark::Test Steps & Error message:
test_sign_in[valid]:white_check_mark::Test Steps & Error message:
test_commands_on_second_app_run:x:Test Steps & Error message:
test_change_user_name:white_check_mark::Test Steps & Error message:
test_recover_access:white_check_mark::Test Steps & Error message:
test_group_chat_members:x:Test Steps & Error message:
test_group_chat_send_receive_messages_and_remove_user:x:Test Steps & Error message:
test_one_to_one_chat:white_check_mark::Test Steps & Error message:
test_send_funds_via_request[group_chat]:x:Test Steps & Error message:
test_eth_and_currency_balance:white_check_mark::Test Steps & Error message:
test_wallet_error_messages:white_check_mark::Test Steps & Error message:
test_send_transaction_from_wallet[sign_later]:white_check_mark::Test Steps & Error message:
test_send_transaction_from_wallet[sign_now]:x:Test Steps & Error message:
test_send_funds_via_request[one_to_one_chat]:x:Test Steps & Error message:
test_password[short]:white_check_mark::Test Steps & Error message:
test_transaction_send_command[group_chat]:white_check_mark::Test Steps & Error message:
test_request_transaction_from_wallet:x:Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:
test_transaction_send_command[one_to_one_chat]:white_check_mark::Test Steps & Error message:
test_transaction_send_command[wrong_password]:white_check_mark::Test Steps & Error message:
|
dca9dfc
to
80d8767
Compare
80d8767
to
d695306
Compare
Branch: PR-3247 |
Branch: PR-3247 all issues are gone in ^ build. Done button is in place as well as Send request (iOS). No regressions. |
Signed-off-by: Goran Jovic <goranjovic@gmail.com>
d695306
to
748b0fc
Compare
fixes #2883
fixes #3042
fixes #3220
improves #3196
Summary:
Migrate wallet/request to latest mockups while relying on components.
Steps to test:
status: ready