Add web3.keycard.signTypedData #9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (125)
|
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
from
bc9b178
to
1180851
Compare
|
@siphiuel is this still relevant? |
|
@flexsurfer yes |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
3 times, most recently
from
e6bb7c3
to
6f51e41
Compare
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
from
6f51e41
to
05d0aaa
Compare
|
@siphiuel is this still relevant? |
|
@flexsurfer yes |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
4 times, most recently
from
996e640
to
e8e5cda
Compare
✔️ status-react/prs/ios/PR-9390#12 🔹 ~9 min 37 sec 🔹 15b73b1 🔹 📦 ios package |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
2 times, most recently
from
1ecb350
to
98d369e
Compare
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
from
21ecc7d
to
22ef2ca
Compare
|
Found an issue, fixed, sorry @churik for back-and-forth. |
|
@siphiuel tried https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200319-195734-2a295c-pr-universal.apk on Android 10 - got "App is not installed", and on Android 8 - it can be installed, but at attempt to start I've got "App is not responding" |
|
Hm.. I can install and run app on Android 8 and 9 fine with this https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200319-195734-2a295c-pr-universal.apk build |
|
Finally I've managed to install it, sorry for confusion. |
|
Tested on DApp https://status-im.github.io/keycard-cash-test-dapp/ - can sign provided transation. @siphiuel can you please provide details where I can track this transaction? |
|
As it turned out, all that I can test it is message signing, it is working. |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
3 times, most recently
from
94ac0e6
to
de520f7
Compare
|
@siphiuel what is missing here ? thanks |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
2 times, most recently
from
68b38a9
to
3182cbf
Compare
|
@guylouis found one more issue after rebase, fixing it, then will merge. |
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
2 times, most recently
from
8ca631b
to
64628e9
Compare
Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>
vitvly
force-pushed
the
feature/9275-keycard-signTypedData
branch
from
64628e9
to
e11385e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9275
Fixes #10205
Without amount: https://drive.google.com/open?id=14FdIJHzTFJlCrwLXjhyTOka1ECl2dFlB
With amount: https://drive.google.com/open?id=1x18JVhYUk359OKaeseiRRtQxQk5kwyo1