[#9657] system messages ui changes in group chat #9800

ghmulti · 2020-01-12T19:59:40Z

Summary

Suggest to create separate task for joining together events without separation (chained events) as this pr affects mostly styling

Platforms

Tested on Android

Areas that maybe impacted

Group chats

status: wip (awaiting feedback)

Colored block for margin/padding overview

status-github-bot · 2020-01-12T19:59:46Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

status-im-auto · 2020-01-12T20:09:33Z

Jenkins Builds

Click to see older builds (23)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`16e2af7`	#1	2020-01-12 20:09:33	~9 min	`ios`	📦`ipa` 📲
✔️	`16e2af7`	#1	2020-01-12 20:15:40	~15 min	`android-e2e`	📦`apk` 📲
✔️	`16e2af7`	#1	2020-01-12 20:15:41	~15 min	`android`	📦`apk` 📲

✔️	`8671067`	#2	2020-01-13 19:52:55	~10 min	`ios`	📦`ipa` 📲
✔️	`8671067`	#2	2020-01-13 19:57:01	~15 min	`android-e2e`	📦`apk` 📲
✔️	`8671067`	#2	2020-01-13 19:57:05	~15 min	`android`	📦`apk` 📲

✔️	`a7ac5f8`	#3	2020-01-19 22:22:09	~8 min	`ios`	📦`ipa` 📲
✔️	`a7ac5f8`	#3	2020-01-19 22:27:31	~13 min	`android-e2e`	📦`apk` 📲
✔️	`a7ac5f8`	#3	2020-01-19 22:27:35	~13 min	`android`	📦`apk` 📲

❌	`6737239`	#4	2020-01-30 17:32:32	~4 min	`ios`	📄`log`
❌	`6737239`	#4	2020-01-30 17:34:47	~6 min	`android-e2e`	📄`log`
❌	`6737239`	#4	2020-01-30 17:34:56	~6 min	`android`	📄`log`

❌	`27a3dbb`	#5	2020-01-30 19:40:03	~31 sec	`android-e2e`	📄`log`
❌	`27a3dbb`	#5	2020-01-30 19:40:03	~28 sec	`android`	📄`log`
❌	`27a3dbb`	#5	2020-01-30 19:40:28	~50 sec	`ios`	📄`log`

❌	`7c2ef5a`	#6	2020-01-30 19:46:32	~22 sec	`android-e2e`	📄`log`
❌	`7c2ef5a`	#6	2020-01-30 19:46:34	~21 sec	`android`	📄`log`
❌	`7c2ef5a`	#6	2020-01-30 19:47:02	~46 sec	`ios`	📄`log`
❌	`7c2ef5a`	#7	2020-01-31 11:15:18	~42 sec	`android`	📄`log`
❌	`7c2ef5a`	#7	2020-01-31 11:15:36	~50 sec	`ios`	📄`log`

❌	`7ecdbd5`	#8	2020-03-06 17:44:32	~3 min	`ios`	📄`log`
❌	`7ecdbd5`	#8	2020-03-06 17:49:08	~8 min	`android`	📄`log`
❌	`7ecdbd5`	#7	2020-03-06 17:49:08	~9 min	`android-e2e`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`06dbb20`	#9	2020-03-21 14:55:15	~12 min	`android`	📦`apk` 📲
✔️	`06dbb20`	#9	2020-03-21 14:55:54	~12 min	`ios`	📦`ipa` 📲
✔️	`06dbb20`	#8	2020-03-21 14:59:18	~17 min	`android-e2e`	📦`apk` 📲

✔️	`a0fe73b`	#10	2020-03-23 09:38:30	~14 min	`ios`	📦`ipa` 📲
✔️	`a0fe73b`	#9	2020-03-23 09:43:29	~19 min	`android-e2e`	📦`apk` 📲
✔️	`a0fe73b`	#10	2020-03-23 09:45:45	~21 min	`android`	📦`apk` 📲

errorists · 2020-01-13T13:24:12Z

getting this error when trying to connect with mail servers, unfortunately can't test it out

looking at the screenshots, it seems like the horizontal margin padding on those messages is too large, should be 8.

flexsurfer · 2020-01-13T15:23:54Z

mailserver error introduced not in this PR

errorists · 2020-01-13T15:24:58Z

@flexsurfer totally, just stops me from testing in as I can't setup a group chat between a couple devices

errorists · 2020-01-13T15:57:41Z

@ghmulti ok managed to test it, these look correct as in the design apart from the horizontal margin which should be 8px on both left and right sides, so it's even with chat bubbles.

ghmulti · 2020-01-13T19:39:10Z

@errorists sure, there is a max-width limit defined for chat message view (red rectangle), should it be dropped for system messages then?
:max-width (if platform/desktop? 500 320)

here is view after removing max-width for system messages and adding margin 8px on both sides

ghmulti · 2020-01-13T19:46:05Z

it's worth mentioning that changes related to "system messages" are made within generic chat message component, so style changes potentially may affect public groups and one-to-one chat views

errorists · 2020-01-14T07:53:23Z

@ghmulti thanks, that did the trick! I asked @Ferossgp to review changes in message code since he's too working on them and addressed some of the values in his PR here #9757

Ferossgp · 2020-01-14T08:47:37Z

Hey @ghmulti, good work! I just have some suggestions, that may have made this type of message less dependent on the text message. What do you think about making them as a separate type in multi-method message-content. That way you will have to check system-message? only in one place and will avoid passing that value through components. You can do that check one-time chat-message.

Thanks!

churik · 2020-01-15T10:00:55Z

Hello @ghmulti!
Thank you for contribution.
Can you please resolve conflicts and rebase your branch to current develop?

ghmulti · 2020-01-15T13:35:28Z

@Ferossgp hey, thanks for feedback and I think you are right - had the same thought

@churik sure, but I'll need to do some refactoring (#9800 (comment))

churik · 2020-01-15T13:44:11Z

I meant when it will be ready. Thanks!

ghmulti · 2020-01-19T22:22:14Z

for now - since there is no content-type-system-text defined in status-go, it is assigned manually based on status-message? flag in chat-message
(when system-message? {:content-type constants/content-type-system-text})
(if this is permissible) after adding new content-type to status-go, that verification needs to be deleted

dismiss

errorists

Tested latest commit, group chat system messages look as they should now, thanks!!

ghmulti · 2020-01-30T17:29:11Z

@cammellos done 👍

src/status_im/ui/screens/chat/message/message.cljs

cammellos

@Serhy could you give it another quick round of testing? if this tests ok I can merge status-go and update the version with develop.

churik · 2020-03-04T11:58:15Z

@ghmulti sorry for the significant delay.
Can you please rebase your branch with the latest develop, because builds can't be built now?

ghmulti · 2020-03-06T17:40:40Z

@cammellos could you please prepare new status-go build with content-type, assume it will not work with the old build after rebase

cammellos · 2020-03-17T08:48:18Z

@ghmulti sorry for the delay, I have been off for the past two weeks.
You can use this branch:
feature/add-content-type-group-chat

To update status-go you can run:

make shell
scripts/update-status-go.sh 'feature/add-content-type-group-chat'

and then you can restart the stack and it should pick up the new version.

ghmulti · 2020-03-21T14:44:43Z

@churik hey, pushed updated version could you take a look please?
as @cammellos said if everything looks fine he will need to merge status-go and update the version with develop before merging pr

status-im-auto · 2020-03-21T15:30:37Z

94% of end-end tests have passed

Total executed tests: 94
Failed tests: 6
Passed tests: 88

Failed tests (6)

Click to expand

1. test_open_public_chat_using_deep_link
Device 1: Type 'https://join.status.im/chat/public/akwtckc' to SearchEditBox Device 1: Tap 'Confirm' on native keyboard `Device 1: 'OpenInStatusButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_decline_invitation_to_group_chat
Device 1: Tap on SendMessageButton Device 2: Looking for an element by text: 'revwvnx' `Message with text '@Navy Greenyellow Anemonecrab left the group' was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_group_chat_system_messages
Device 1: Looking for a message by text: '@focused Boring Degu left the group' Device 1: Wait for ChatElementByText `Message with test '@Stormy Darkviolet Kentrosaurus created the group dpyoddt' was not received Message with test '@Focused Boring Degu joined the group' was not received Message with test '@Focused Boring Degu left the group' was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_dapps_permissions
Device 1: Tap on ProfileButton Device 1: Wait for PrivacyAndSecurityButton `Device 1: 'PrivacyAndSecurityButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_pair_devices_sync_one_to_one_contacts_public_chat
Device 2: Wait for PlusButton Device 2: Looking for an element by text part: 'after-pairing' `"Darkorchid Clueless Ewe" is not found in Contacts after adding when devices are paired` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_send_two_transactions_in_batch_in_dapp
Device 1: Wait for SignButton Device 1: Wait for SignButton `Device 1: 'OkButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (88)

Click to expand

1. test_request_public_key_status_test_daap
Device sessions Device 1: Steps, video, logs
2. test_ens_username_recipient
Device sessions Device 1: Steps, video, logs
3. test_offline_status
Device sessions Device 1: Steps, video, logs
4. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
5. test_open_chat_by_pasting_public_key
Device sessions Device 1: Steps, video, logs
6. test_back_forward_buttons_browsing_website
Device sessions Device 1: Steps, video, logs
7. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
8. test_can_use_purchased_stickers_on_recovered_account
Device sessions Device 1: Steps, video, logs
9. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
10. test_insufficient_funds_wallet_positive_balance
Device sessions Device 1: Steps, video, logs
11. test_mobile_data_usage_settings
Device sessions Device 1: Steps, video, logs
12. test_delete_group_chat_via_delete_button
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
14. test_logcat_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
15. test_unread_messages_counter_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
17. test_message_marked_as_sent_in_1_1_chat
Device sessions Device 1: Steps, video, logs
18. test_user_can_switch_network
Device sessions Device 1: Steps, video, logs
19. test_public_chat_clear_history (TestRail link is not found)
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
20. test_wallet_set_up
Device sessions Device 1: Steps, video, logs
21. test_timestamp_in_chats
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_delete_chats_via_delete_button
Device sessions Device 1: Steps, video, logs
23. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions Device 1: Steps, video, logs
24. test_fetch_more_history_in_empty_chat
Device sessions Device 1: Steps, video, logs
25. test_mobile_data_usage_popup_continue_syncing
Device sessions Device 1: Steps, video, logs
26. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
27. test_long_press_delete_clear_all_dapps
Device sessions Device 1: Steps, video, logs
28. test_need_help_section
Device sessions Device 1: Steps, video, logs
29. test_transaction_wrong_password_wallet
Device sessions Device 1: Steps, video, logs
30. test_offline_messaging_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_token_with_more_than_allowed_decimals
Device sessions Device 1: Steps, video, logs
32. test_add_account_to_multiaccount_instance_private_key
Device sessions Device 1: Steps, video, logs
33. test_text_message_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_install_pack_and_send_sticker
Device sessions Device 1: Steps, video, logs
35. test_make_admin_member_of_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
36. test_send_emoji
Device sessions Device 1: Steps, video, logs
37. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
38. test_clear_history_of_group_chat_via_group_view
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
39. test_add_account_to_multiaccount_instance_generate_new
Device sessions Device 1: Steps, video, logs
40. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
41. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
42. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
43. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
44. test_connection_is_secure
Device sessions Device 1: Steps, video, logs
45. test_user_can_see_all_own_assets_after_account_recovering
Device sessions Device 1: Steps, video, logs
46. test_add_new_group_chat_member
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
47. test_long_press_to_delete_chat
Device sessions Device 1: Steps, video, logs
48. test_add_and_remove_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
49. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
50. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions Device 1: Steps, video, logs
51. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
52. test_open_blocked_site
Device sessions Device 1: Steps, video, logs
53. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
54. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
55. test_pass_phrase_validation
Device sessions Device 1: Steps, video, logs
56. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
57. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
58. test_send_message_in_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
59. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
60. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
61. test_add_custom_token
Device sessions Device 1: Steps, video, logs
62. test_send_and_open_links
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
63. test_manage_assets
Device sessions Device 1: Steps, video, logs
64. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
65. test_redirect_to_public_chat_tapping_tag_message
Device sessions Device 1: Steps, video, logs
66. test_block_user_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
67. test_ens_in_public_and_1_1_chats
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
68. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
69. test_create_new_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
70. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
71. test_account_recovery_with_uppercase_recovery_phrase
Device sessions Device 1: Steps, video, logs
72. test_send_message_to_newly_added_contact
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
73. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
74. test_mobile_data_usage_popup_stop_syncing
Device sessions Device 1: Steps, video, logs
75. test_collectible_from_wallet_opens_in_browser_view
Device sessions Device 1: Steps, video, logs
76. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
77. test_contact_profile_view
Device sessions Device 1: Steps, video, logs
78. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
79. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
80. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
81. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
82. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
83. test_home_view
Device sessions Device 1: Steps, video, logs
84. test_log_level_and_fleet
Device sessions Device 1: Steps, video, logs
85. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
86. test_copy_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
87. test_fetching_balance_after_offline
Device sessions Device 1: Steps, video, logs
88. test_can_see_all_transactions_in_history
Device sessions Device 1: Steps, video, logs

churik · 2020-03-23T09:56:47Z

Tested ally types of group system messages, right order, fetching system messages from offline (Android 10, IOS 13).
Group tests should work with, however can't check because it is separate repo.

Thanks for a work @ghmulti !

flexsurfer · 2020-03-26T06:23:31Z

#10208

ghmulti requested a review from a team as a code owner January 12, 2020 19:59

auto-assign bot removed the request for review from a team January 12, 2020 19:59

errorists added the design-review label Jan 13, 2020

errorists requested a review from Ferossgp January 13, 2020 09:33

flexsurfer requested a review from errorists January 13, 2020 15:22

flexsurfer added the community label Jan 13, 2020

flexsurfer previously approved these changes Jan 13, 2020

View reviewed changes

flexsurfer requested a review from cammellos January 13, 2020 16:42

flexsurfer added the request-manual-qa label Jan 13, 2020

ghmulti force-pushed the fix/#9657 branch from 8671067 to a7ac5f8 Compare January 19, 2020 22:13

flexsurfer self-requested a review January 21, 2020 15:22

errorists approved these changes Jan 22, 2020

View reviewed changes

cammellos reviewed Jan 30, 2020

View reviewed changes

src/status_im/ui/screens/chat/message/message.cljs Outdated Show resolved Hide resolved

cammellos approved these changes Jan 30, 2020

View reviewed changes

ghmulti force-pushed the fix/#9657 branch from 27a3dbb to 7c2ef5a Compare January 30, 2020 19:45

weekly-digest bot mentioned this pull request Feb 2, 2020

Weekly Digest (26 January, 2020 - 2 February, 2020) #9963

Closed

ghmulti force-pushed the fix/#9657 branch from 7c2ef5a to 7ecdbd5 Compare March 6, 2020 17:38

[status-im#9657] system messages ui changes in group chat

06dbb20

ghmulti force-pushed the fix/#9657 branch from 7ecdbd5 to 06dbb20 Compare March 21, 2020 14:41

fix group chat tests

a0fe73b

ghmulti requested review from antdanchenko and churik as code owners March 23, 2020 07:48

churik added the Tested - OK label Mar 23, 2020

churik mentioned this pull request Mar 23, 2020

Add web3.keycard.signTypedData #9390

Merged

cammellos mentioned this pull request Mar 25, 2020

[#9657] system messages ui changes in group chat #10208

Merged

flexsurfer closed this Mar 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#9657] system messages ui changes in group chat #9800

[#9657] system messages ui changes in group chat #9800

ghmulti commented Jan 12, 2020

status-github-bot bot commented Jan 12, 2020

status-im-auto commented Jan 12, 2020 •

edited

Loading

errorists commented Jan 13, 2020 •

edited

Loading

flexsurfer commented Jan 13, 2020

errorists commented Jan 13, 2020

errorists commented Jan 13, 2020

ghmulti commented Jan 13, 2020

ghmulti commented Jan 13, 2020

errorists commented Jan 14, 2020

Ferossgp commented Jan 14, 2020

churik commented Jan 15, 2020

ghmulti commented Jan 15, 2020

churik commented Jan 15, 2020

ghmulti commented Jan 19, 2020

errorists left a comment

ghmulti commented Jan 30, 2020

cammellos left a comment

churik commented Mar 4, 2020

ghmulti commented Mar 6, 2020

cammellos commented Mar 17, 2020

ghmulti commented Mar 21, 2020

status-im-auto commented Mar 21, 2020

churik commented Mar 23, 2020

flexsurfer commented Mar 26, 2020

[#9657] system messages ui changes in group chat #9800

[#9657] system messages ui changes in group chat #9800

Conversation

ghmulti commented Jan 12, 2020

Summary

Platforms

Areas that maybe impacted

status-github-bot bot commented Jan 12, 2020

Pull Request Checklist

status-im-auto commented Jan 12, 2020 • edited Loading

Jenkins Builds

errorists commented Jan 13, 2020 • edited Loading

flexsurfer commented Jan 13, 2020

errorists commented Jan 13, 2020

errorists commented Jan 13, 2020

ghmulti commented Jan 13, 2020

ghmulti commented Jan 13, 2020

errorists commented Jan 14, 2020

Ferossgp commented Jan 14, 2020

churik commented Jan 15, 2020

ghmulti commented Jan 15, 2020

churik commented Jan 15, 2020

ghmulti commented Jan 19, 2020

errorists left a comment

Choose a reason for hiding this comment

ghmulti commented Jan 30, 2020

cammellos left a comment

Choose a reason for hiding this comment

churik commented Mar 4, 2020

ghmulti commented Mar 6, 2020

cammellos commented Mar 17, 2020

ghmulti commented Mar 21, 2020

status-im-auto commented Mar 21, 2020

94% of end-end tests have passed

Failed tests (6)

Passed tests (88)

churik commented Mar 23, 2020

flexsurfer commented Mar 26, 2020

status-im-auto commented Jan 12, 2020 •

edited

Loading

errorists commented Jan 13, 2020 •

edited

Loading