Skip to content

Commit

Permalink
Add changes to PR checklist discussed in Istanbul
Browse files Browse the repository at this point in the history
Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>
  • Loading branch information
Pedro Pombeiro committed Sep 23, 2019
1 parent a1735e4 commit 4a95b88
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/github-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,11 @@ github-team:
prchecklist:
title: Pull Request Checklist
checklist:
- 'Have you updated the documentation, if impacted (e.g. [docs.status.im](https://docs.status.im/docs/build_status.html))?'
- '**Docs**: Updated the [documentation](https://status.im/build_status/), if affected'
- '**Docs**: Added or updated inline comments explaining intention of the code'
- '**Tests**: Ensured that all new UI elements have been assigned accessibility IDs'
- '**Tests**: Signaled need for E2E tests with label, if applicable'
- '**Tests**: Briefly described what was tested and what platforms were used'
- '**UI**: In case of UI changes, ensured that UI matches [Figma](https://www.figma.com/)'
- '**UI**: In case of UI changes, requested review from a Core UI designer'
- '**UI**: In case of UI changes, included screenshots of implementation'

0 comments on commit 4a95b88

Please sign in to comment.