Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new chat on search #10890

Closed
decanus opened this issue Jun 29, 2020 · 9 comments
Closed

Start a new chat on search #10890

decanus opened this issue Jun 29, 2020 · 9 comments

Comments

@decanus
Copy link
Contributor

decanus commented Jun 29, 2020

Feature Issue

An intuitive design for starting a chat with a user is to search for their name. Currently the search bar does not handle this case. When I search for a user who I do not have a chat started with I should be presented with a button that allows me to start a new chat.

image

User Story

As a user, I want to be presented with a option to start a new chat if I search for someone I do not have a conversation started with.

Notes

For examples, see telegram.

@hesterbruikman
Copy link
Contributor

@decanus do you mean search the ENS registry? @flexsurfer @andremedeiros can you think of a reason we do not have this yet? We basically use the same functionality when registering a name, correct?

cc @errorists

@decanus
Copy link
Contributor Author

decanus commented Jun 30, 2020

It should probably work with public keys too @hesterbruikman my main point was that the UI should be bridged for minimal effort. I should be able to start a chat through search.

@errorists
Copy link
Contributor

ok I admit i had to read it a couple times to 'get' it's the chat list search bar we're talking about :) thanks, yea I believe adding relevant suggestions to the empty state here could be a worthwhile improvement

Screenshot 2020-06-30 at 10 47 34

@flexsurfer
Copy link
Member

yeah i also always trying to create new chat in search :)

@decanus
Copy link
Contributor Author

decanus commented Jun 30, 2020

@errorists sorry, my description may have not been the best, it was late in the evening. Glad we are on the same page however.

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Aug 5, 2020

Partial solution implemented: 8652f89

Doesn't resolve non-stateofus.eth names. Leaving the issue open

Not sure how this could be handled for non-stateofus.eth names as I believe we wouldn't know if they have a chat key connected. Issue needs investigation if this is feasible, if not, issue can be closed

@Ferossgp
Copy link
Contributor

Ferossgp commented Aug 5, 2020

@hesterbruikman the merged solution handles all cases which are handled by the new chat screen. I think this issue should be closed as it is a duplicate of #10988

@churik
Copy link
Member

churik commented Aug 5, 2020

it is done, agree

@churik
Copy link
Member

churik commented Aug 5, 2020

@churik churik closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants