Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to a sent confirmation for all message types #11020

Closed
hesterbruikman opened this issue Jul 30, 2020 · 2 comments · Fixed by #11546
Closed

Listen to a sent confirmation for all message types #11020

hesterbruikman opened this issue Jul 30, 2020 · 2 comments · Fixed by #11546
Assignees

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Jul 30, 2020

Problem

When adding a reaction in an offline state, it is instantly visible for user A. However, the reaction is not send when offline, nor when User A comes back online. User B never sees the reaction, while it remains visible for user A

Expected

Three options (ideally a combination of 1&2):

  1. User A can add a reaction when offline, when the client comes back online, the reaction is send
  2. User A can add a reaction when offline, user is informed the reaction was not send and can Tap to try again, upon which this message will disappear as soon as the reaction is send successfully
  3. User A cannot send a reaction when offline

Current

User A can add a reaction when offline. User A is not informed the reaction is not send. Reaction is not send when user A comes online

Implementation

Acceptance Criteria

Reaction is successfully sent or user is informed if message is not successfully sent
or
User cannot add reaction when offline

Notes

Future Steps

@errorists
Copy link
Contributor

Let's try to make the first option work since imo it's superior to other alternatives

User A can add a reaction when offline, when the client comes back online, the reaction is send

@hesterbruikman hesterbruikman changed the title Handle offline state for (Emoji) reactions Handle offline state for messages and (Emoji) reactions Aug 10, 2020
@hesterbruikman
Copy link
Contributor Author

From conversation with @Ferossgp this is actually related to how we get and show a send confirmation for all message types.

Hiding (disallowing) reactions in offline state is not sufficient. Also with low or interrupted connections, we cannot confirm the message was send; however the client might still show as online and allow reactions.

A better solution would be to listen to a send confirmation

@hesterbruikman hesterbruikman changed the title Handle offline state for messages and (Emoji) reactions Listen to a sent confirmation for all message types Oct 1, 2020
@vkjr vkjr self-assigned this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants