-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No conversion for WETH is assests in wallet #11037
Comments
cryptocompare api doesn't support WETH https://min-api.cryptocompare.com/data/price?fsym=WETH&tsyms=USD,JPY,EUR |
See also #10695 (comment) for a check with Cryptocompare on Manage assets to inform the user of fiat values not available |
@hesterbruikman It seems weird to me to have tokens / currencies that are not supported in case if they are already hardcoded in our assets list. |
Agreed, I think WETH is one of the exceptions where it is commonly used so we want to offer not having to add it manually. At the same time it's supported, but not fully supported. We should probably still check if the token fiat value is supported given the fiat value you have selected. |
i didn't find a list of supported tokens by Cryptocompare, so probably not only weth from our list is not supported, but i figured out that WETH is not traded on any centralized exchange , thats why there is no price, it is traded on decentralized uniswap, so if we want its price we should get it somehow from uniswap contract i guess |
related issue #9140 |
Seems like this can be closed, @flexsurfer feel free to re-open if other actions are required |
Bug Report
Problem
Сonversion for WETH in wallet no displayed. Adress for checking conversion for this asset on Etherscan: 0xcf2272205cc0cf96Cfbb9Dd740BD681D1E86901E
Actual behavior
The text was updated successfully, but these errors were encountered: