Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local contact names #11046

Closed
hesterbruikman opened this issue Aug 6, 2020 · 2 comments · Fixed by #11106
Closed

Add local contact names #11046

hesterbruikman opened this issue Aug 6, 2020 · 2 comments · Fixed by #11106
Assignees

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Aug 6, 2020

Add local contact names

Source: Roadmap planning workshop item #37 and Discuss

User stories

  • As a user, I want to add a nickname to my contacts so that I don’t get confused about who I’m chatting to or struggle to find the person I want to chat with in my contact list.

Use cases

  • Add local name in Contacts
  • View local name in chat
  • View local name in chat list
  • View local name in notifications
  • View local name in user profile
  • View local name in contact list

Preliminary designs

@hesterbruikman hesterbruikman changed the title Locak (nick) names Local (nick) names Aug 6, 2020
@hesterbruikman hesterbruikman changed the title Local (nick) names Add local contact names Aug 6, 2020
@Samyoul
Copy link
Member

Samyoul commented Aug 7, 2020

My responses to concerns from team

See feedback

Security concerns

On the other hand, isn't there any risk of my contacts deanonymization if my phone gets hacked?

Yes, depending on the nickname you give. But if your phone is hacked all of your chat is also compromised, along with your wallet keys and identity key. A concern, but a tiny one compared to the other consequences of a hacked phone.

Also there is nothing stopping someone from creating a list of all their contacts and saving them in a pastebin. If you are communicating with someone you are always giving up some level of anonymity.


crucial. Are there any privacy/security concerns with this?

To me the main concerns are a phone being compromised. Syncing is not an issue as the data is encrypted with the same process as all Waku messages are.


Syncing

We need to have a good grasp on what syncing looks like.

Currently device contact sync protobuf looks like:

message SyncInstallationContact {
  uint64 clock = 1;
  string id = 2;
  string profile_image = 3;
  string ens_name = 4;
  uint64 last_updated = 5;
  repeated string system_tags = 6;
}

I'd imagine that a logical next step would be to add a nickname field to the protobuf and change the logic to handle this additional field.


This should be quick, it NEEDs to be synced across synced devices.

Syncing can be handled.


Mobile <-> Desktop local names sync. What are the requirements?


Misc

Feels highly important, but is it easily doable? Wondering if there's a technical blocker as to why we don't have it already

Looking through the code there is no technical limitation.


Not ambitious enough, could try and improve random name as well?

This would be a separate feature. Both can exist simultaneously, and be developed independently.


Size of data? Like comments or just names?

Comments if a priority should be a separate feature. Equally easy to implement as nicknames but not dependant on local nicknames.


i'm not convinced this will help with the username challenges we experience, but rather dump the responsibility on the user to make sense of it

This feature is not designed to resolve username challenges. This feature is designed to address confusing contact lists. Granted a self determined user name would solve this concern, ENS gives a pre-existing solution.


I think it's helpful; it might also be nice if you could set a local profile photo for a contact. But for both the name an photo there should be some subtle but constant visual indicator that it's a local name/photo.

--- 

In the UI we need to be really clear with how someone could be imporsonating someone else just by changing their usernameWe are reducing value to the ENS usernames. Why would I spend gas and snt to get a username if i can use a free local name instead?

This is only for the local user's address book. This isn't for setting a public name.


IMO can be merged with 'profile image' swarm (at least in the past it was managed as of contact list) and really dependant from go side

Probably could be merged with profile image, but it is not dependant in my estimation.

@Samyoul
Copy link
Member

Samyoul commented Aug 10, 2020

We need to identify any syncing weirdness, and edge cases where syncing is not working.

See https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3Apairing

@flexsurfer flexsurfer self-assigned this Aug 18, 2020
flexsurfer added a commit that referenced this issue Aug 20, 2020
flexsurfer added a commit that referenced this issue Aug 27, 2020
flexsurfer added a commit that referenced this issue Aug 28, 2020
flexsurfer added a commit that referenced this issue Aug 31, 2020
flexsurfer added a commit that referenced this issue Aug 31, 2020
flexsurfer added a commit that referenced this issue Aug 31, 2020
flexsurfer added a commit that referenced this issue Sep 3, 2020
flexsurfer added a commit that referenced this issue Sep 4, 2020
flexsurfer added a commit that referenced this issue Sep 4, 2020
flexsurfer added a commit that referenced this issue Sep 4, 2020
flexsurfer added a commit that referenced this issue Sep 4, 2020
flexsurfer added a commit that referenced this issue Sep 4, 2020
flexsurfer added a commit that referenced this issue Sep 7, 2020
flexsurfer added a commit that referenced this issue Sep 7, 2020
Signed-off-by: andrey <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants