-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local contact names #11046
Comments
My responses to concerns from teamSecurity concerns
Yes, depending on the nickname you give. But if your phone is hacked all of your chat is also compromised, along with your wallet keys and identity key. A concern, but a tiny one compared to the other consequences of a hacked phone. Also there is nothing stopping someone from creating a list of all their contacts and saving them in a pastebin. If you are communicating with someone you are always giving up some level of anonymity.
To me the main concerns are a phone being compromised. Syncing is not an issue as the data is encrypted with the same process as all Waku messages are. Syncing
Currently device contact sync protobuf looks like: message SyncInstallationContact {
uint64 clock = 1;
string id = 2;
string profile_image = 3;
string ens_name = 4;
uint64 last_updated = 5;
repeated string system_tags = 6;
} I'd imagine that a logical next step would be to add a
Syncing can be handled.
Misc
Looking through the code there is no technical limitation.
This would be a separate feature. Both can exist simultaneously, and be developed independently.
Comments if a priority should be a separate feature. Equally easy to implement as nicknames but not dependant on local nicknames.
This feature is not designed to resolve username challenges. This feature is designed to address confusing contact lists. Granted a self determined user name would solve this concern, ENS gives a pre-existing solution.
---
This is only for the local user's address book. This isn't for setting a public name.
Probably could be merged with profile image, but it is not dependant in my estimation. |
We need to identify any syncing weirdness, and edge cases where syncing is not working. See https://github.com/status-im/status-react/issues?q=is%3Aopen+is%3Aissue+label%3Apairing |
Signed-off-by: andrey <motor4ik@gmail.com>
Add local contact names
Source: Roadmap planning workshop item #37 and Discuss
User stories
Use cases
Contacts
Preliminary designs
The text was updated successfully, but these errors were encountered: