Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked card screen isn't shown while trying to perform transaction after card has already been blocked #11052

Closed
qoqobolo opened this issue Aug 6, 2020 · 3 comments · Fixed by #12183
Assignees

Comments

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 6, 2020

Bug Report

Problem

If keycard was blocked (e.g. during Send transaction flow), if try to perform transaction again, blocked card screen/pop up isn't shown, and after entering PIN nothing happens. Also, the message "Your keycard is frozen" is shown at the top of the screen after keycard was blocked.

Expected behavior

Blocked card screen/pop up is shown again while attempting to perform transactions after blocking.

Actual behavior

ezgif com-resize (14)

Reproduction

  • Login to keycard account
  • Wallet > Send transaction > Enter valid amount of ETH > Choose recipient > tap Sign with Keycard
  • Enter invalid PIN 3 times
  • Enter invalid PUK 5 times
  • When "Keycard was blocked" screen appears, tap back
  • Go to Wallet > Send transaction > Enter valid amount of ETH > Choose recipient > tap Sign with Keycard
  • Enter valid PIN

Additional Information

  • Status version: Nightly 6/08
  • Operating System: Android 10
@churik churik changed the title Blocked card screen isn't shown while trying to perform transaction after card has already been blocked during send transaction flow Blocked card screen isn't shown while trying to perform transaction after card has already been blocked Aug 6, 2020
@guylouis
Copy link
Contributor

@qoqobolo
when you have time, could you tell us if it's still reproduceable ?

@qoqobolo
Copy link
Contributor Author

@guylouis yes, this behavior is reproducible, the issue is still relevant

@bitgamma
Copy link
Member

indeed the problem is that a "blocked card" popup does not exist, it needs to be created and shown. At the moment the only reaction to blocked card is setting the banner in the wallet page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants