Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycard onboarding UI touchups / use components #9177

Closed
churik opened this issue Oct 11, 2019 · 6 comments
Closed

Keycard onboarding UI touchups / use components #9177

churik opened this issue Oct 11, 2019 · 6 comments
Labels
feature feature requests onboarding

Comments

@churik
Copy link
Member

churik commented Oct 11, 2019

Problem

After #8903 it is required to use same components across all onboarding process, including Keycard part.
It should resolve differences in design and issues with long text (i.e. impossibility to create account with Keycard when the application in Russian - screenshot is attached)
photo_2019-10-11 13 20 56

More details will be added by @siphiuel

@churik
Copy link
Member Author

churik commented Oct 14, 2019

More issues #9200 and #9201

@vitvly
Copy link
Contributor

vitvly commented Oct 14, 2019

@dmitryn not sure if this is the best approach, but that's what I did when fixing #8911 (Basic recovery flow):

  1. Move views from status-im.ui.screens.multiaccounts.recover.views to status-im.ui.screens.intro.views so that top-bar, bottom-bar, etc. can be re-used.
  2. Re-use logic from status-im.multiaccounts.create.core for recovery flow as much as possible, but preserve status-im.multiaccounts.recover.core for wizard forward-action handling and recovery-specific calls. All wizard state data is now in (:intro-wizard db).
  3. Initialize custom back-button/iOS swipe action processing in core namespaces via ::navigation/add-wizard-back-event fx. This means that now wizard's back action (clicking on back arrow, Android's hardware back button and iOS's swipe left gesture) are invoked via navigate-back, which then invokes proper back handling as setup by wizard-back-event. Forward action is different between intro flow and basic recovery flow, and is setup in core namespaces via (get-in db [:intro-wizard :forward-action]).

@guylouis guylouis changed the title Keycard onboarding UI touchups Keycard onboarding UI touchups / use components Oct 16, 2019
@churik
Copy link
Member Author

churik commented Oct 17, 2019

related issue: #8851

@rachelhamlin
Copy link
Contributor

@guylouis I think we bumped this one from v1 must-haves, right? Want to double check w/ you, I forgot to drop release label last week.

@guylouis
Copy link
Contributor

@rachelhamlin yes, it's out of v1
@andrei I guess this one should be closed and be part of your newly edited issues right ?

@andmironov
Copy link

Addressed in #9356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests onboarding
Projects
None yet
Development

No branches or pull requests

6 participants