drop all desktop related files and references #10901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
jakubgs
force-pushed
the
drop-desktop
branch
2 times, most recently
from
051a2ec
to
ae132db
Compare
jakubgs
changed the title
91% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (86)Click to expand |
61% of end-end tests have passedFailed tests (37)Click to expand
Passed tests (57)Click to expand |
93% of end-end tests have passedFailed tests (7)Click to expand
Passed tests (87)Click to expand |
|
Wrong issue, meant #10904. |
|
I've checked latest build (https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200707-104549-1b55e1-pr-universal.apk) and iOS build is the same, - and there is a regression bug: |
|
looking |
|
thanks @Serhy fixed |
92% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (88)Click to expand |
1% of end-end tests have passedFailed tests (95)Click to expand
Passed tests (1) |
|
Nice, still waiting for a review of https://github.com/status-im/status-react-jenkins/pull/11 to merge it and tag it tho... |
1% of end-end tests have passedFailed tests (95)Click to expand
Passed tests (1) |
Signed-off-by: Jakub Sokołowski <jakub@status.im>
97% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (93)Click to expand
|
|
The only thing I changed was the branch name from |
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since desktop is now officially developed in nim-status-client we can finally get rid of all of the desktop crust from this repo.
My favorite part of this is that we finally get rid of the symlinking of files from
mobile/js_files.Thanks for help from @flexsurfer with cleaning up the Clojure side of things.
And once this is merged I'll have to update Snyk settings so it can find the files.
Also, I snuck in a reduction in built timeouts to 20 minutes.