Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactions picker UI #10912

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Add reactions picker UI #10912

merged 1 commit into from
Jul 31, 2020

Conversation

Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Jul 5, 2020

No description provided.

@Ferossgp Ferossgp requested a review from a team as a code owner July 5, 2020 07:59
@Ferossgp Ferossgp self-assigned this Jul 5, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Jul 5, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (105)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6a69120 #1 2020-07-05 08:13:33 ~13 min ios 📦ipa 📲
✔️ 6a69120 #1 2020-07-05 08:16:02 ~16 min android 📦apk 📲
✔️ 6a69120 #1 2020-07-05 08:16:10 ~16 min android-e2e 📦apk 📲
✔️ 056d4e8 #2 2020-07-05 10:10:40 ~12 min ios 📦ipa 📲
✔️ 056d4e8 #2 2020-07-05 10:11:57 ~14 min android 📦apk 📲
✔️ 056d4e8 #2 2020-07-05 10:12:08 ~14 min android-e2e 📦apk 📲
✔️ 0619080 #4 2020-07-05 15:10:02 ~11 min android-e2e 📦apk 📲
✔️ 0619080 #4 2020-07-05 15:10:11 ~11 min android 📦apk 📲
✔️ 0619080 #4 2020-07-05 15:12:27 ~14 min ios 📦ipa 📲
✔️ beb390e #5 2020-07-06 08:39:28 ~8 min android 📦apk 📲
✔️ beb390e #5 2020-07-06 08:44:09 ~12 min ios 📦ipa 📲
✔️ beb390e #5 2020-07-06 08:47:05 ~15 min android-e2e 📦apk 📲
✔️ 45131a4 #6 2020-07-06 09:50:09 ~13 min ios 📦ipa 📲
✔️ 45131a4 #6 2020-07-06 09:51:09 ~14 min android 📦apk 📲
✔️ 45131a4 #6 2020-07-06 09:51:12 ~14 min android-e2e 📦apk 📲
✔️ 6c746b1 #7 2020-07-06 13:30:33 ~13 min ios 📦ipa 📲
✔️ 6c746b1 #7 2020-07-06 13:30:46 ~14 min android-e2e 📦apk 📲
✔️ 6c746b1 #7 2020-07-06 13:30:49 ~14 min android 📦apk 📲
✔️ aa357e2 #9 2020-07-09 18:49:59 ~11 min android-e2e 📦apk 📲
✔️ aa357e2 #9 2020-07-09 18:50:02 ~11 min android 📦apk 📲
✔️ aa357e2 #9 2020-07-09 18:51:40 ~12 min ios 📦ipa 📲
✔️ 16d1408 #10 2020-07-10 09:07:03 ~8 min android 📦apk 📲
✔️ 16d1408 #10 2020-07-10 09:10:23 ~11 min android-e2e 📦apk 📲
✔️ 16d1408 #10 2020-07-10 09:14:05 ~15 min ios 📦ipa 📲
✔️ b8c5006 #11 2020-07-10 12:01:57 ~14 min ios 📦ipa 📲
✔️ b8c5006 #11 2020-07-10 12:03:35 ~15 min android-e2e 📦apk 📲
✔️ b8c5006 #11 2020-07-10 12:03:47 ~16 min android 📦apk 📲
❌ 1895564 #12 2020-07-10 16:18:27 ~5 min android 📄log
❌ 1895564 #12 2020-07-10 16:18:59 ~6 min ios 📄log
❌ 1895564 #12 2020-07-10 16:21:00 ~8 min android-e2e 📄log
✔️ c3e1700 #13 2020-07-10 16:55:09 ~12 min android-e2e 📦apk 📲
✔️ c3e1700 #13 2020-07-10 16:55:13 ~12 min android 📦apk 📲
❌ c3e1700 #14 2020-07-10 20:08:12 ~12 min ios 📄log
✔️ 277b970 #16 2020-07-11 09:42:24 ~13 min ios 📦ipa 📲
✔️ 277b970 #15 2020-07-11 09:49:14 ~20 min android 📦apk 📲
✔️ 277b970 #15 2020-07-11 09:49:16 ~20 min android-e2e 📦apk 📲
❌ 7b81062 #17 2020-07-13 14:21:33 ~15 min ios 📄log
❌ 7b81062 #16 2020-07-13 14:25:22 ~19 min android-e2e 📄log
✔️ 7b81062 #16 2020-07-13 14:25:39 ~19 min android 📦apk 📲
✖️ 3580705 #17 2020-07-15 13:46:04 ~11 min android 📦apk 📲
❌ 3580705 #18 2020-07-15 13:48:45 ~14 min ios 📄log
❌ 3580705 #17 2020-07-15 13:51:58 ~17 min android-e2e 📄log
✔️ 750a8dc #18 2020-07-16 07:08:28 ~8 min android 📦apk 📲
✔️ 750a8dc #19 2020-07-16 07:18:30 ~18 min ios 📦ipa 📲
✔️ 750a8dc #18 2020-07-16 07:19:29 ~19 min android-e2e 📦apk 📲
✖️ 56928e8 #19 2020-07-20 14:58:04 ~14 min android 📦apk 📲
✖️ 56928e8 #19 2020-07-20 14:58:14 ~15 min android-e2e 📦apk 📲
✖️ 56928e8 #20 2020-07-20 14:58:17 ~15 min ios 📦ipa 📲
✔️ 78d7e7a #21 2020-07-20 15:22:41 ~12 min ios 📦ipa 📲
✔️ 78d7e7a #20 2020-07-20 15:24:21 ~14 min android-e2e 📦apk 📲
✔️ 78d7e7a #20 2020-07-20 15:24:33 ~14 min android 📦apk 📲
✔️ 2732ad4 #22 2020-07-21 08:52:22 ~13 min ios 📦ipa 📲
✔️ 2732ad4 #21 2020-07-21 08:53:46 ~14 min android-e2e 📦apk 📲
✔️ 2732ad4 #21 2020-07-21 08:53:52 ~14 min android 📦apk 📲
✔️ 2732ad4 #23 2020-07-27 10:18:11 ~13 min ios 📦ipa 📲
✔️ 518894d #22 2020-07-27 11:23:45 ~10 min android 📦apk 📲
✔️ 518894d #22 2020-07-27 11:24:17 ~11 min android-e2e 📦apk 📲
✔️ 518894d #24 2020-07-27 11:25:53 ~12 min ios 📦ipa 📲
✖️ 9e8d171 #24 2020-07-28 09:16:42 ~13 min android-e2e 📦apk 📲
✖️ 9e8d171 #24 2020-07-28 09:17:10 ~13 min android 📦apk 📲
✖️ 81cdcba #25 2020-07-28 09:27:59 ~9 min android 📦apk 📲
✖️ 81cdcba #27 2020-07-28 09:31:23 ~12 min ios 📦ipa 📲
✖️ 81cdcba #25 2020-07-28 09:32:09 ~13 min android-e2e 📦apk 📲
✖️ 81cdcba #26 2020-07-28 11:08:21 ~11 min android 📦apk 📲
✔️ a713813 #28 2020-07-28 12:28:50 ~15 min ios 📦ipa 📲
✔️ a713813 #26 2020-07-28 12:29:03 ~15 min android-e2e 📦apk 📲
✔️ a713813 #27 2020-07-28 12:29:05 ~15 min android 📦apk 📲
✔️ 3f7e092 #28 2020-07-28 13:54:44 ~16 min android 📦apk 📲
✔️ 3f7e092 #27 2020-07-28 13:55:27 ~17 min android-e2e 📦apk 📲
✔️ 3f7e092 #29 2020-07-28 13:56:39 ~18 min ios 📦ipa 📲
✔️ 274fff4 #29 2020-07-28 14:50:06 ~13 min android 📦apk 📲
✔️ 274fff4 #28 2020-07-28 14:51:50 ~15 min android-e2e 📦apk 📲
✔️ 274fff4 #30 2020-07-28 14:52:45 ~16 min ios 📦ipa 📲
✖️ cfc19a6 #31 2020-07-29 08:06:26 ~13 min ios 📦ipa 📲
✖️ cfc19a6 #30 2020-07-29 08:08:41 ~15 min android 📦apk 📲
✖️ cfc19a6 #29 2020-07-29 08:08:42 ~15 min android-e2e 📦apk 📲
✔️ e9bcae4 #31 2020-07-29 09:32:46 ~14 min android-e2e 📦apk 📲
✔️ e9bcae4 #32 2020-07-29 09:32:54 ~14 min android 📦apk 📲
✔️ e9bcae4 #33 2020-07-29 09:33:31 ~15 min ios 📦ipa 📲
✔️ dc892b4 #33 2020-07-29 14:33:18 ~13 min android 📦apk 📲
✔️ dc892b4 #32 2020-07-29 14:33:18 ~13 min android-e2e 📦apk 📲
✔️ 8731328 #33 2020-07-29 14:47:32 ~11 min android-e2e 📦apk 📲
✔️ 8731328 #34 2020-07-29 14:47:40 ~12 min android 📦apk 📲
✔️ 8731328 #35 2020-07-29 14:53:56 ~18 min ios 📦ipa 📲
✔️ 846de9b #35 2020-07-30 10:55:05 ~11 min android 📦apk 📲
✔️ 846de9b #34 2020-07-30 10:55:38 ~11 min android-e2e 📦apk 📲
✔️ 846de9b #36 2020-07-30 11:01:10 ~17 min ios 📦ipa 📲
✔️ 78e4ba2 #36 2020-07-30 12:11:36 ~13 min android 📦apk 📲
✔️ 78e4ba2 #35 2020-07-30 12:11:38 ~13 min android-e2e 📦apk 📲
✔️ 78e4ba2 #37 2020-07-30 12:14:49 ~16 min ios 📦ipa 📲
✔️ 2bae234 #36 2020-07-30 15:06:02 ~9 min android-e2e 📦apk 📲
✔️ 2bae234 #37 2020-07-30 15:06:13 ~9 min android 📦apk 📲
✔️ 2bae234 #38 2020-07-30 15:15:46 ~19 min ios 📦ipa 📲
✔️ 11b12ae #37 2020-07-30 19:52:41 ~14 min android-e2e 📦apk 📲
✔️ 11b12ae #38 2020-07-30 19:53:33 ~14 min android 📦apk 📲
✔️ 11b12ae #39 2020-07-30 19:55:46 ~17 min ios 📦ipa 📲
✔️ 4a408b7 #38 2020-07-30 21:14:23 ~14 min android-e2e 📦apk 📲
✔️ 4a408b7 #39 2020-07-30 21:16:41 ~16 min android 📦apk 📲
✔️ 4a408b7 #40 2020-07-30 21:17:02 ~16 min ios 📦ipa 📲
✔️ 5a15e9a #40 2020-07-31 05:27:30 ~15 min android 📦apk 📲
✔️ 5a15e9a #39 2020-07-31 05:27:33 ~15 min android-e2e 📦apk 📲
✔️ 5a15e9a #41 2020-07-31 05:27:46 ~15 min ios 📦ipa 📲
✔️ e111038 #42 2020-07-31 07:13:24 ~15 min ios 📦ipa 📲
✔️ e111038 #40 2020-07-31 07:14:21 ~16 min android-e2e 📦apk 📲
✔️ e111038 #41 2020-07-31 07:14:27 ~16 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1c308c2 #42 2020-07-31 11:55:26 ~12 min android-e2e 📦apk 📲
✔️ 6081a80 #42 2020-07-31 11:56:17 ~13 min android 📦apk 📲

@Ferossgp Ferossgp force-pushed the feature/reactions-ui branch 2 times, most recently from 0619080 to beb390e Compare July 6, 2020 08:31
@Ferossgp Ferossgp force-pushed the feature/reactions-ui branch 3 times, most recently from 210cc8f to aa357e2 Compare July 9, 2020 18:38
@hesterbruikman
Copy link
Contributor

Love these @Ferossgp @errorists!

Tested on:
Samsung s10e
Android 10

Fairphone 2
Android 7

Findings

  • image 1 - User A reaction on message user B shows the username for user B. Against the backdrop of the chat the text feels a little out of place. I doubt it adds value. How do you feel about removing the name?
  • image 2 - For both user A reacting to user B and user B reacting to user A, the picker and message move to the top when tapping while the Keyboard is open. Is this because there's no overlay on Keyboard? Not a blocker, but the behavior felt unexpected. I think I expected a transition such as close keyboard > scroll down > show picker below message

Frame 1

@errorists
Copy link
Contributor

errorists commented Jul 10, 2020 •
edited
Loading

whoa, everything on image 1 went wrong :D the menu should be aligned with the bottom left corner of the bubble, and the text is positioned in an incorrect location. We can leave the usernames and avatars where they are and don't include them in the long press menus, sure.
image 2, you are 100% correct :) thanks!

@Ferossgp
Copy link
Contributor Author

Ferossgp commented Jul 10, 2020 •
edited
Loading

yeah, image 1 should be fixed. But the image 2 uses the same behaviour as Apple Messages, I can try to not move the list from the background

@errorists
Copy link
Contributor

re: image 2, not exactly, with Messages they dismiss the keyboard/toolbar for the time when the message is active and leave the scroll position intact. Here the scroll position of the chat is moved downward with the keyboard and the message moves out of existing context. It would be preferable if we either don't move the chat scroll position (Apple) or animate the Y position of the message so that it's as close to its intended position in the scrolled chat as possible.

@Samyoul Samyoul mentioned this pull request Jul 10, 2020
Merged
12 tasks
@Ferossgp Ferossgp force-pushed the feature/reactions-ui branch 2 times, most recently from 1895564 to c3e1700 Compare July 10, 2020 16:42
@Samyoul Samyoul mentioned this pull request Jul 10, 2020
Merged
@weekly-digest weekly-digest bot mentioned this pull request Jul 12, 2020
Closed
@hesterbruikman hesterbruikman added this to the Mobile Release 1.5 milestone Jul 14, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
@Ferossgp
Copy link
Contributor Author

@churik Fixed 10 and 11

@churik
Copy link
Member

churik commented Jul 30, 2020 •
edited
Loading

@hesterbruikman
noticed that reactions are also available in Offline, so if you react somehow to message when you are offline, therefore you'll see wrong state until you re-add the same reaction.
Example:

  • user A: send message to User B
  • user A: go to airplane mode
  • user A: long tap on the message, add thumb up(wait for ~5 mins)
  • user A: go back to online
  • user A: check reactions on message (have thumb up)
  • user B: check reactions on message (doesn't have thumb up)

So in this case to reset counter User A should delete thumbnail reaction and re-add it again.
Is it acceptable behavior for now?

@hesterbruikman
Copy link
Contributor

Sounds like there is no handling of offline state for reactions. Indeed, I'd say acceptable for now.

Two directions, I'm not sure which is best at this point:

  • either not allow to place react when offline (similar to how you can't send a message)
  • check for new reactions when client comes online and send

@churik
Copy link
Member

churik commented Jul 30, 2020

test fixes in #11018, waiting for results

@churik
Copy link
Member

churik commented Jul 30, 2020

all failed e2e are fixed, results are in #11018 (comment)

@churik
Copy link
Member

churik commented Jul 30, 2020

One more issue (thanks @qoqobolo for discovering): if some message had reactions from User B and then User A blocks User B - changing reactions from User B on messages for User A has no effect

Steps:

  • User A, User B: join public chat
  • User A: send message A
  • User B: like message A
  • User A: blocks User B
  • User B: dislike message A
  • User A: unblocks User B

Expected result: message reactions are synchronized after unblocking
Actual result: message reactions are still the same - to sync it you need to re-add reactions.
Basically situation is similar to offline.
Can be fixed separately IMO.

@Ferossgp I think last issue to fix

Issue 12 'No messages' on preview if joining public channel with last message with reaction

Steps:

  • User A: join public chat, send message with reaction
  • User B: join same public chat, navigate back

Expected result: can see message
Actual result:
photo_2020-07-30 17 59 39 jpeg 2020-07-30 17-59-52

@cammellos
Copy link
Contributor

@churik the last issue seems to be in status-go, I will fix it and merge the PR.
cc @Ferossgp @hesterbruikman

@cammellos cammellos force-pushed the feature/reactions-ui branch 2 times, most recently from 11b12ae to 4a408b7 Compare July 30, 2020 20:59
@status-im-auto
Copy link
Member

95% of end-end tests have passed

Total executed tests: 97
Failed tests: 5
Passed tests: 92

Failed tests (5)

Click to expand
1. test_public_chat_clear_history

Device 1: Tap on SignInButton
Device 1: Looking for an element by text: '#ymsqgto'

Device 1: 'BaseButton' is not found on the screen

Device sessions

2. test_push_notification_1_1_chat

Device 2: Check text push notification and tap it
Device 2: Looking for an element by text part: 'Text push notification'

Device 2: Push notification with text was not received

Device sessions

3. test_image_in_one_to_one_send_save_reply

Device 2: Looking for a message by text: 'image reply'
Device 2: Wait for ImageInReply

Save and reply are not available on long-press on own image messages

Device sessions

4. test_block_user_from_public_chat

Device 1: Wait for JoinPublicChatButton
Device 1: JoinPublicChatButton element not found

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

5. test_request_and_receive_stt_in_1_1_chat_offline

Device 2: Looking for a message by text: '↑ Outgoing transaction'
Device 2: Wait for ChatElementByText

'TestCommandsMultipleDevices' object has no attribute 'driver'

Device sessions

Passed tests (92)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_need_help_section
Device sessions

10. test_send_and_open_links
Device sessions

11. test_mobile_data_usage_popup_stop_syncing
Device sessions

12. test_keycard_send_eth_in_1_1_chat
Device sessions

13. test_mobile_data_usage_settings
Device sessions

14. test_create_new_group_chat
Device sessions

15. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

16. test_user_can_switch_network
Device sessions

17. test_mobile_data_usage_popup_continue_syncing
Device sessions

18. test_home_view
Device sessions

19. test_open_google_com_via_open_dapp
Device sessions

20. test_share_contact_code_and_wallet_address
Device sessions

21. test_connection_is_secure
Device sessions

22. test_add_to_contacts
Device sessions

23. test_add_account_to_multiaccount_instance_private_key
Device sessions

24. test_refresh_button_browsing_app_webview
Device sessions

25. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_transaction_wrong_password_wallet
Device sessions

28. test_public_chat_messaging
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_keycard_send_eth_from_wallet_to_address
Device sessions

31. test_keycard_fetching_balance_after_offline
Device sessions

32. test_keycard_send_transaction_from_daap
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_can_use_purchased_stickers_on_recovered_account
Device sessions

35. test_open_transaction_on_etherscan
Device sessions

36. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

37. test_contact_profile_view
Device sessions

38. test_offline_add_new_group_chat_member
Device sessions

39. test_logcat_backup_recovery_phrase
Device sessions

40. test_can_recover_keycard_account_card_pairing
Device sessions

41. test_start_chat_with_ens
Device sessions

42. test_add_and_remove_contact_from_public_chat
Device sessions

43. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

44. test_open_blocked_site
Device sessions

45. test_open_chat_by_pasting_public_key
Device sessions

46. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

47. test_keycard_sign_message_from_daap
Device sessions

48. test_send_non_english_message_to_newly_added_contact
Device sessions

49. test_ens_username_recipient
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_open_public_chat_using_deep_link
Device sessions

52. test_switch_users_and_add_new_account
Device sessions

53. test_add_account_to_multiaccount_instance_generate_new
Device sessions

54. test_copy_contact_code_and_wallet_address
Device sessions

55. test_send_transaction_from_daap
Device sessions

56. test_send_two_transactions_one_after_another_in_dapp
Device sessions

57. test_add_new_keycard_account_and_login
Device sessions

58. test_long_press_delete_clear_all_dapps
Device sessions

59. test_copy_and_paste_messages
Device sessions

60. test_back_forward_buttons_browsing_website
Device sessions

61. test_password_in_logcat_creating_account
Device sessions

62. test_sign_message_from_daap
Device sessions

63. test_dapps_permissions
Device sessions

64. test_request_public_key_status_test_daap
Device sessions

65. test_long_press_to_delete_chat
Device sessions

66. test_log_level_and_fleet
Device sessions

67. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

68. test_recover_account_from_new_user_seedphrase
Device sessions

69. test_send_transaction_with_custom_token
Device sessions

70. test_send_eth_in_1_1_chat
Device sessions

71. test_send_two_transactions_in_batch_in_dapp
Device sessions

72. test_ens_in_public_and_1_1_chats
Device sessions

73. test_fetching_balance_after_offline
Device sessions

74. test_offline_status
Device sessions

75. test_wallet_set_up
Device sessions

76. test_manage_assets
Device sessions

77. test_offline_messaging_1_1_chat
Device sessions

78. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

79. test_send_token_with_7_decimals
Device sessions

80. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

81. test_pass_phrase_validation
Device sessions

82. test_keycard_can_see_all_transactions_in_history
Device sessions

83. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

84. test_send_emoji
Device sessions

85. test_filters_from_daap
Device sessions

86. test_redirect_to_public_chat_tapping_tag_message
Device sessions

87. test_restore_account_from_mnemonic_to_keycard
Device sessions

88. test_send_eth_to_ens_in_chat
Device sessions

89. test_send_eth_from_wallet_to_address
Device sessions

90. test_messaging_in_different_networks
Device sessions

91. test_collectible_from_wallet_opens_in_browser_view
Device sessions

92. test_insufficient_funds_wallet_positive_balance
Device sessions

@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 97
Failed tests: 1
Passed tests: 96

Failed tests (1)

Click to expand
1. test_image_in_one_to_one_send_save_reply

Device 2: Looking for a message by text: 'image reply'
Device 2: Wait for ImageInReply

Save and reply are not available on long-press on own image messages

Device sessions

Passed tests (96)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_public_chat_clear_history
Device sessions

10. test_need_help_section
Device sessions

11. test_send_and_open_links
Device sessions

12. test_mobile_data_usage_popup_stop_syncing
Device sessions

13. test_keycard_send_eth_in_1_1_chat
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_share_contact_code_and_wallet_address
Device sessions

22. test_connection_is_secure
Device sessions

23. test_add_to_contacts
Device sessions

24. test_add_account_to_multiaccount_instance_private_key
Device sessions

25. test_refresh_button_browsing_app_webview
Device sessions

26. test_push_notification_1_1_chat
Device sessions

27. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_public_chat_messaging
Device sessions

31. test_unread_messages_counter_public_chat
Device sessions

32. test_keycard_send_eth_from_wallet_to_address
Device sessions

33. test_keycard_fetching_balance_after_offline
Device sessions

34. test_keycard_send_transaction_from_daap
Device sessions

35. test_text_message_1_1_chat
Device sessions

36. test_can_use_purchased_stickers_on_recovered_account
Device sessions

37. test_open_transaction_on_etherscan
Device sessions

38. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

39. test_contact_profile_view
Device sessions

40. test_offline_add_new_group_chat_member
Device sessions

41. test_logcat_backup_recovery_phrase
Device sessions

42. test_can_recover_keycard_account_card_pairing
Device sessions

43. test_start_chat_with_ens
Device sessions

44. test_add_and_remove_contact_from_public_chat
Device sessions

45. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

46. test_open_blocked_site
Device sessions

47. test_open_chat_by_pasting_public_key
Device sessions

48. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

49. test_keycard_sign_message_from_daap
Device sessions

50. test_send_non_english_message_to_newly_added_contact
Device sessions

51. test_ens_username_recipient
Device sessions

52. test_fetch_more_history_in_empty_chat
Device sessions

53. test_open_public_chat_using_deep_link
Device sessions

54. test_switch_users_and_add_new_account
Device sessions

55. test_add_account_to_multiaccount_instance_generate_new
Device sessions

56. test_copy_contact_code_and_wallet_address
Device sessions

57. test_send_transaction_from_daap
Device sessions

58. test_send_two_transactions_one_after_another_in_dapp
Device sessions

59. test_add_new_keycard_account_and_login
Device sessions

60. test_long_press_delete_clear_all_dapps
Device sessions

61. test_copy_and_paste_messages
Device sessions

62. test_back_forward_buttons_browsing_website
Device sessions

63. test_password_in_logcat_creating_account
Device sessions

64. test_sign_message_from_daap
Device sessions

65. test_dapps_permissions
Device sessions

66. test_request_public_key_status_test_daap
Device sessions

67. test_long_press_to_delete_chat
Device sessions

68. test_log_level_and_fleet
Device sessions

69. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

70. test_recover_account_from_new_user_seedphrase
Device sessions

71. test_send_transaction_with_custom_token
Device sessions

72. test_send_eth_in_1_1_chat
Device sessions

73. test_send_two_transactions_in_batch_in_dapp
Device sessions

74. test_ens_in_public_and_1_1_chats
Device sessions

75. test_block_user_from_public_chat
Device sessions

76. test_fetching_balance_after_offline
Device sessions

77. test_offline_status
Device sessions

78. test_wallet_set_up
Device sessions

79. test_manage_assets
Device sessions

80. test_offline_messaging_1_1_chat
Device sessions

81. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

82. test_send_token_with_7_decimals
Device sessions

83. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

84. test_pass_phrase_validation
Device sessions

85. test_keycard_can_see_all_transactions_in_history
Device sessions

86. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

87. test_send_emoji
Device sessions

88. test_filters_from_daap
Device sessions

89. test_redirect_to_public_chat_tapping_tag_message
Device sessions

90. test_restore_account_from_mnemonic_to_keycard
Device sessions

91. test_send_eth_to_ens_in_chat
Device sessions

92. test_send_eth_from_wallet_to_address
Device sessions

93. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

94. test_messaging_in_different_networks
Device sessions

95. test_collectible_from_wallet_opens_in_browser_view
Device sessions

96. test_insufficient_funds_wallet_positive_balance
Device sessions

@churik
Copy link
Member

churik commented Jul 31, 2020 •
edited
Loading

I don't see other issues except mentioned above, which are not blockers.

Apart from #10912 (comment) tested:

  • all redirects to user profile from any type of messages from reaction panel ;
  • 10+ of each reaction on messages
  • compatibility with 1.4.1 (messages, replies, stickers)
  • PNs
  • reactions in offline/online (issue described here Add reactions picker UI #10912 (comment))
  • reactions after blocking/unblocking users (issue described Add reactions picker UI #10912 (comment))
  • preview of messages with reaction
  • the app is in the background with reactions panel opened
  • reaction panel in all type of messages in dark mode
  • reactions from keycard accounts
  • devices pairing

Waiting for e2e test results from ( e2e are triggered from #11018 branch)

@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 171
Failed tests: 11
Passed tests: 160

Failed tests (11)

Click to expand
1. test_public_chat_clear_history

Device 1: Tap on SignInButton
Device 1: Looking for an element by text: '#xgahhbg'

Device 1: 'BaseButton' is not found on the screen

Device sessions

2. test_open_user_profile_long_press_on_message (TestRail link is not found)

Device 2: Looking for message with text 'Message sender'
Device 2: Long press ChatElementByText

Device 2: 'ViewProfileButton' is not found on the screen

Device sessions

3. test_webview_security (TestRail link is not found)

Device 1: Tap 'Confirm' on native keyboard
Device 1: Looking for an element by text part: 'XSS check'

Device 1: 'OpenInStatusButton' is not found on the screen

Device sessions

4. test_block_user_from_one_to_one_header_check_push_notification_service (TestRail link is not found)

Device 1: Wait for JoinPublicChatButton
Device 1: JoinPublicChatButton element not found

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

5. test_validation_amount_errors (TestRail link is not found)

Device 1: Tap on ValidationErrorOnSendTransaction
Device 1: Looking for an element by text part: 'Not enough ETH for gas'

Warning Not enough ETH for gas is not shown on sending screen from wallet Warning Insufficient funds is not shown on sending screen from DApp Warning Not enough ETH for gas is not shown on sending screen from DApp

Device sessions

6. test_logcat_backup_recovery_phrase

Device 1: Tap on DoneButton
Device 1: Tap on YesButton

Device 1: ['Passphrase1 in logcat!!!', 'Passphrase2 in logcat!!!']

Device sessions

7. test_block_and_unblock_user_from_group_chat_via_group_info (TestRail link is not found)

Device 1: =========================================================================
Device 1: Unblock user via group info and check that new messages will arrive

Device 1: 'ChatMenuButton' is not found on the screen

Device sessions

8. test_image_in_one_to_one_send_save_reply

Device 2: Looking for a message by text: 'image reply'
Device 2: Wait for ImageInReply

Save and reply are not available on long-press on own image messages

Device sessions

9. test_block_user_from_public_chat

Device 1: Wait for JoinPublicChatButton
Device 1: JoinPublicChatButton element not found

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

10. test_add_switch_delete_custom_mailserver (TestRail link is not found)

Device 1: Scrolling down to SyncSettingsButton
Device 1: Scrolling down to SyncSettingsButton

Device 1: 'SyncSettingsButton' is not found on the screen

Device sessions

11. test_request_and_receive_stt_in_1_1_chat_offline

Device 2: Looking for a message by text: '↑ Outgoing transaction'
Device 2: Wait for ChatElementByText

'TestCommandsMultipleDevices' object has no attribute 'driver'

Device sessions

Passed tests (160)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_search_chat_on_home (TestRail link is not found)
Device sessions

3. test_delete_chats_via_delete_button
Device sessions

4. test_can_see_all_transactions_in_history
Device sessions

5. test_install_pack_and_send_sticker
Device sessions

6. test_login_with_new_account
Device sessions

7. test_same_seed_added_inside_multiaccount_and_keycard (TestRail link is not found)
Device sessions

8. test_invite_friends (TestRail link is not found)
Device sessions

9. test_timestamp_in_chats
Device sessions

10. test_privacy_policy_is_accessible (TestRail link is not found)
Device sessions

11. test_password_in_logcat_sign_in
Device sessions

12. test_logcat_recovering_account
Device sessions

13. test_offline_login (TestRail link is not found)
Device sessions

14. test_need_help_section
Device sessions

15. test_send_and_open_links
Device sessions

16. test_mobile_data_usage_popup_stop_syncing
Device sessions

17. test_add_custom_network (TestRail link is not found)
Device sessions

18. test_keycard_send_eth_in_1_1_chat
Device sessions

19. test_cant_add_more_ten_participants_to_group_chat (TestRail link is not found)
Device sessions

20. test_mobile_data_usage_settings
Device sessions

21. test_create_new_group_chat
Device sessions

22. test_can_access_images_by_link (TestRail link is not found)
Device sessions

23. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

24. test_sign_typed_message (TestRail link is not found)
Device sessions

25. test_user_can_switch_network
Device sessions

26. test_mobile_data_usage_popup_continue_syncing
Device sessions

27. test_browser_shows_offline_state (TestRail link is not found)
Device sessions

28. test_home_view
Device sessions

29. test_open_google_com_via_open_dapp
Device sessions

30. test_network_mismatch_for_send_request_in_1_1_chat (TestRail link is not found)
Device sessions

31. test_share_contact_code_and_wallet_address
Device sessions

32. test_make_admin_member_of_group_chat (TestRail link is not found)
Device sessions

33. test_connection_is_secure
Device sessions

34. test_add_to_contacts
Device sessions

35. test_navigation_history_kept_after_relogin
Device sessions

36. test_cant_send_transaction_in_offline_mode (TestRail link is not found)
Device sessions

37. test_add_account_to_multiaccount_instance_private_key
Device sessions

38. test_refresh_button_browsing_app_webview
Device sessions

39. test_delete_cut_and_paste_messages (TestRail link is not found)
Device sessions

40. test_push_notification_1_1_chat
Device sessions

41. test_copy_transaction_hash (TestRail link is not found)
Device sessions

42. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

43. test_reply_to_message_in_chats (TestRail link is not found)
Device sessions

44. test_deny_camera_access_scanning_wallet_adders (TestRail link is not found)
Device sessions

45. test_can_add_existing_ens
Device sessions

46. test_markdown_support_in_messages (TestRail link is not found)
Device sessions

47. test_unblocked_user_is_not_added_in_contacts (TestRail link is not found)
Device sessions

48. test_transaction_wrong_password_wallet
Device sessions

49. test_login_with_incorrect_password (TestRail link is not found)
Device sessions

50. test_public_chat_messaging
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_long_press_to_clear_chat_history
Device sessions

53. test_keycard_send_eth_from_wallet_to_address
Device sessions

54. test_keycard_fetching_balance_after_offline
Device sessions

55. test_keycard_send_transaction_from_daap
Device sessions

56. test_text_message_1_1_chat
Device sessions

57. test_can_not_connect_to_mailserver (TestRail link is not found)
Device sessions

58. test_no_backup_seedphrase_option_for_recovered_account (TestRail link is not found)
Device sessions

59. test_add_remove_contact_via_contacts_view (TestRail link is not found)
Device sessions

60. test_open_invalid_link (TestRail link is not found)
Device sessions

61. test_can_use_purchased_stickers_on_recovered_account
Device sessions

62. test_set_currency (TestRail link is not found)
Device sessions

63. test_recover_accounts_with_certain_seedphrase (TestRail link is not found)
Device sessions

64. test_backup_recovery_phrase_warning_from_wallet (TestRail link is not found)
Device sessions

65. test_app_on_background_by_back_button (TestRail link is not found)
Device sessions

66. test_open_transaction_on_etherscan
Device sessions

67. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

68. test_unread_messages_counter_1_1_chat
Device sessions

69. test_contact_profile_view
Device sessions

70. test_custom_bootnodes (TestRail link is not found)
Device sessions

71. test_offline_add_new_group_chat_member
Device sessions

72. test_create_account_short_and_mismatch_password (TestRail link is not found)
Device sessions

73. test_connection_is_not_secure (TestRail link is not found)
Device sessions

74. test_can_recover_keycard_account_card_pairing
Device sessions

75. test_start_chat_with_ens
Device sessions

76. test_add_and_remove_contact_from_public_chat
Device sessions

77. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

78. test_open_blocked_site
Device sessions

79. test_open_chat_by_pasting_public_key
Device sessions

80. test_keycard_deploy_contract_from_daap (TestRail link is not found)
Device sessions

81. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

82. test_keycard_sign_message_from_daap
Device sessions

83. test_leave_group_chat_via_group_info (TestRail link is not found)
Device sessions

84. test_send_non_english_message_to_newly_added_contact
Device sessions

85. test_set_primary_ens_custom_domain (TestRail link is not found)
Device sessions

86. test_ens_username_recipient
Device sessions

87. test_fetch_more_history_in_empty_chat
Device sessions

88. test_open_public_chat_using_deep_link
Device sessions

89. test_keycard_interruption_access_key_onboarding_flow (TestRail link is not found)
Device sessions

90. test_no_collectibles_to_send_from_wallet (TestRail link is not found)
Device sessions

91. test_can_change_account_settings (TestRail link is not found)
Device sessions

92. test_clear_history_via_options (TestRail link is not found)
Device sessions

93. test_mark_all_messages_as_read_public_chat (TestRail link is not found)
Device sessions

94. test_switch_users_and_add_new_account
Device sessions

95. test_open_user_profile_using_deep_link (TestRail link is not found)
Device sessions

96. test_add_account_to_multiaccount_instance_generate_new
Device sessions

97. test_public_chat_messages_received_while_different_tab_opened (TestRail link is not found)
Device sessions

98. test_copy_contact_code_and_wallet_address
Device sessions

99. test_send_transaction_from_daap
Device sessions

100. test_send_two_transactions_one_after_another_in_dapp
Device sessions

101. test_backup_recovery_phrase (TestRail link is not found)
Device sessions

102. test_add_new_keycard_account_and_login
Device sessions

103. test_long_press_delete_clear_all_dapps
Device sessions

104. test_copy_and_paste_messages
Device sessions

105. test_back_forward_buttons_browsing_website
Device sessions

106. test_switching_accounts_in_dapp (TestRail link is not found)
Device sessions

107. test_incorrect_contact_code_start_new_chat (TestRail link is not found)
Device sessions

108. test_password_in_logcat_creating_account
Device sessions

109. test_sign_message_from_daap
Device sessions

110. test_dapps_permissions
Device sessions

111. test_request_public_key_status_test_daap
Device sessions

112. test_long_press_to_delete_chat
Device sessions

113. test_log_level_and_fleet
Device sessions

114. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

115. test_recover_account_from_new_user_seedphrase
Device sessions

116. test_deep_link_with_invalid_user_public_key (TestRail link is not found)
Device sessions

117. test_send_transaction_with_custom_token
Device sessions

118. test_keycard_sign_typed_message (TestRail link is not found)
Device sessions

119. test_keycard_request_and_receive_stt_in_1_1_chat_offline (TestRail link is not found)
Device sessions

120. test_send_eth_in_1_1_chat
Device sessions

121. test_rename_group_chat (TestRail link is not found)
Device sessions

122. test_share_user_profile_url_public_chat (TestRail link is not found)
Device sessions

123. test_send_two_transactions_in_batch_in_dapp
Device sessions

124. test_ens_in_public_and_1_1_chats
Device sessions

125. test_fetching_balance_after_offline
Device sessions

126. test_send_eth_from_wallet_incorrect_address (TestRail link is not found)
Device sessions

127. test_offline_status
Device sessions

128. test_wallet_set_up
Device sessions

129. test_special_characters_in_password_when_recover_account (TestRail link is not found)
Device sessions

130. test_manage_assets
Device sessions

131. test_use_pinned_mailserver (TestRail link is not found)
Device sessions

132. test_special_characters_in_password_when_creating_new_account (TestRail link is not found)
Device sessions

133. test_offline_messaging_1_1_chat
Device sessions

134. test_open_dapp_using_deep_link (TestRail link is not found)
Device sessions

135. test_decline_invitation_to_group_chat (TestRail link is not found)
Device sessions

136. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

137. test_send_token_with_7_decimals
Device sessions

138. test_keycard_send_funds_between_accounts_in_multiaccount_instance (TestRail link is not found)
Device sessions

139. test_keycard_interruption_creating_onboarding_flow (TestRail link is not found)
Device sessions

140. test_search_asset_and_currency (TestRail link is not found)
Device sessions

141. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

142. test_pass_phrase_validation
Device sessions

143. test_keycard_can_see_all_transactions_in_history
Device sessions

144. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

145. test_deny_camera_access_scanning_contact_code (TestRail link is not found)
Device sessions

146. test_send_emoji
Device sessions

147. test_filters_from_daap
Device sessions

148. test_browse_page_with_non_english_text (TestRail link is not found)
Device sessions

149. test_redirect_to_public_chat_tapping_tag_message
Device sessions

150. test_passphrase_whitespaces_ignored_while_recovering_access (TestRail link is not found)
Device sessions

151. test_restore_account_from_mnemonic_to_keycard
Device sessions

152. test_send_eth_to_ens_in_chat
Device sessions

153. test_send_funds_between_accounts_in_multiaccount_instance (TestRail link is not found)
Device sessions

154. test_remove_member_from_group_chat (TestRail link is not found)
Device sessions

155. test_send_eth_from_wallet_to_address
Device sessions

156. test_can_scan_qr_with_chat_key_from_new_contact_view (TestRail link is not found)
Device sessions

157. test_messaging_in_different_networks
Device sessions

158. test_collectible_from_wallet_opens_in_browser_view
Device sessions

159. test_insufficient_funds_wallet_positive_balance
Device sessions

160. test_can_scan_eip_681_links (TestRail link is not found)
Device sessions

@churik
Copy link
Member

churik commented Jul 31, 2020 •
edited
Loading

failed tests are relaunched in #11018 (comment) with https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200731-065744-e11103-pr-x86.apk - no issues related to PR.

Ready to merge.

Also rechecked manually different scenarios of logout to check status-go error - not reproducible.

@cammellos cammellos force-pushed the feature/reactions-ui branch 2 times, most recently from 6081a80 to 1c308c2 Compare July 31, 2020 11:42
@cammellos cammellos merged commit 1c308c2 into develop Jul 31, 2020
@cammellos cammellos deleted the feature/reactions-ui branch July 31, 2020 11:43
@Ferossgp @cammellos
Emoji reactions
1c308c2 
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
@churik churik mentioned this pull request Jul 31, 2020
Closed
@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samyoul Samyoul Samyoul left review comments

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@churik churik

@Ferossgp Ferossgp

Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
Mobile Release 1.5
Development

Successfully merging this pull request may close these issues.
9 participants
@Ferossgp @status-im-auto @hesterbruikman @errorists @Serhy @cammellos @churik @Samyoul @flexsurfer