Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tokens validation #10923

Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix tokens validation #10923

merged 1 commit into from
Sep 14, 2020

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Jul 7, 2020 •
edited by StatusWrike
Loading

fix tokens validation
fixes: #10922

@flexsurfer flexsurfer requested a review from a team as a code owner July 7, 2020 13:49
@flexsurfer flexsurfer self-assigned this Jul 7, 2020
@flexsurfer flexsurfer requested a review from Serhy July 7, 2020 13:49
@status-im-auto
Copy link
Member

status-im-auto commented Jul 7, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7258045 #1 2020-07-07 13:59:02 ~9 min android-e2e 📦apk 📲
✔️ 7258045 #1 2020-07-07 14:01:28 ~11 min android 📦apk 📲
✔️ 7258045 #1 2020-07-07 14:04:02 ~14 min ios 📦ipa 📲
✔️ 09af1f2 #2 2020-07-10 10:13:43 ~8 min android 📦apk 📲
✔️ 09af1f2 #2 2020-07-10 10:16:32 ~11 min android-e2e 📦apk 📲
✔️ 09af1f2 #2 2020-07-10 10:18:30 ~13 min ios 📦ipa 📲
✔️ a285341 #3 2020-09-14 07:52:48 ~11 min android 📦apk 📲
✔️ a285341 #3 2020-09-14 07:56:11 ~15 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 02f820a #4 2020-09-14 08:15:44 ~10 min android 📦apk 📲
✔️ 02f820a #4 2020-09-14 08:15:47 ~11 min android-e2e 📦apk 📲
✔️ 02f820a #4 2020-09-14 08:18:15 ~13 min ios 📦ipa 📲
✔️ 301f1c8 #5 2020-09-14 14:15:40 ~8 min android-e2e 📦apk 📲

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 96
Failed tests: 10
Passed tests: 86

Failed tests (10)

Click to expand
1. test_ens_username_recipient

Device 1: =========================================================================
Device 1: checking that "stateofus.eth" name will be resolved as recipient

Device 1: 'SignInPhraseText' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

2. test_can_use_purchased_stickers_on_recovered_account

Device 1: Wait for JoinPublicChatButton
Device 1: JoinPublicChatButton element not found

Device 1: 'JoinPublicChatButton' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

3. test_user_can_switch_network

Device 1: Scrolling down to AdvancedButton
Device 1: Scrolling down to AdvancedButton

Device 1: 'AdvancedButton' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

4. test_install_pack_and_send_sticker

Device 1: =========================================================================
Device 1: install free sticker pack and use it in public chat

Device 1: 'ShowStickersButton' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'; also Unexpected Alert is sho

Device sessions

5. test_messaging_in_different_networks

Device 2: ChatMessageInput element not found
Device 2: Looking for a message by text: 'test message'

Device 2: 'ChatElementByText' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

6. test_start_chat_with_ens

Device 1: Wait for StartNewChatButton
Device 1: StartNewChatButton element not found

Device 1: 'StartNewChatButton' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

7. test_ens_in_public_and_1_1_chats

Device 1: Scrolling down to ENSusernames
Device 1: Scrolling down to ENSusernames

Device 1: 'ENSusernames' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

8. test_collectible_from_wallet_opens_in_browser_view

Device 1: Wait for MultiaccountMoreOptions
Device 1: MultiaccountMoreOptions element not found

Device 1: 'SignInPhraseText' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

9. test_can_add_existing_ens

Device 1: Scrolling down to ENSusernames
Device 1: Scrolling down to ENSusernames

Device 1: 'ENSusernames' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token POE at address 0x0e0989b1f9b8a38983c2ba8053269ca62ec9b195 - set to Po.et Tokens but detected as Po.et'

Device sessions

10. test_keycard_request_and_receive_stt_in_1_1_chat_offline

Device 2: Check that transaction message is fetched from offline and sign transaction
Device 2: Tap on AirplaneModeButton

Device 2: 'ConnectionStatusText' is still visible on the screen after 30 seconds

Device sessions

Passed tests (86)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_keycard_can_see_all_transactions_in_history
Device sessions

4. test_offline_status
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_open_chat_by_pasting_public_key
Device sessions

7. test_back_forward_buttons_browsing_website
Device sessions

8. test_password_in_logcat_creating_account
Device sessions

9. test_insufficient_funds_wallet_positive_balance
Device sessions

10. test_mobile_data_usage_settings
Device sessions

11. test_open_google_com_via_open_dapp
Device sessions

12. test_logcat_backup_recovery_phrase
Device sessions

13. test_unread_messages_counter_public_chat
Device sessions

14. test_send_two_transactions_one_after_another_in_dapp
Device sessions

15. test_public_chat_clear_history
Device sessions

16. test_wallet_set_up
Device sessions

17. test_timestamp_in_chats
Device sessions

18. test_delete_chats_via_delete_button
Device sessions

19. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

20. test_fetch_more_history_in_empty_chat
Device sessions

21. test_mobile_data_usage_popup_continue_syncing
Device sessions

22. test_keycard_fetching_balance_after_offline
Device sessions

23. test_add_to_contacts
Device sessions

24. test_dapps_permissions
Device sessions

25. test_long_press_delete_clear_all_dapps
Device sessions

26. test_need_help_section
Device sessions

27. test_transaction_wrong_password_wallet
Device sessions

28. test_offline_messaging_1_1_chat
Device sessions

29. test_add_account_to_multiaccount_instance_private_key
Device sessions

30. test_text_message_1_1_chat
Device sessions

31. test_send_eth_in_1_1_chat
Device sessions

32. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

33. test_image_in_one_to_one_send_save_reply
Device sessions

34. test_send_emoji
Device sessions

35. test_copy_and_paste_messages
Device sessions

36. test_keycard_send_eth_in_1_1_chat
Device sessions

37. test_restore_account_from_mnemonic_to_keycard
Device sessions

38. test_add_account_to_multiaccount_instance_generate_new
Device sessions

39. test_send_eth_from_wallet_to_address
Device sessions

40. test_logcat_recovering_account
Device sessions

41. test_offline_add_new_group_chat_member
Device sessions

42. test_connection_is_secure
Device sessions

43. test_keycard_send_transaction_from_daap
Device sessions

44. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

45. test_send_eth_to_ens_in_chat
Device sessions

46. test_keycard_sign_message_from_daap
Device sessions

47. test_long_press_to_delete_chat
Device sessions

48. test_add_and_remove_contact_from_public_chat
Device sessions

49. test_send_transaction_from_daap
Device sessions

50. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

51. test_keycard_send_eth_from_wallet_to_address
Device sessions

52. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

53. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

54. test_open_blocked_site
Device sessions

55. test_refresh_button_browsing_app_webview
Device sessions

56. test_public_chat_messaging
Device sessions

57. test_pass_phrase_validation
Device sessions

58. test_send_token_with_7_decimals
Device sessions

59. test_sign_message_from_daap
Device sessions

60. test_recover_account_from_new_user_seedphrase
Device sessions

61. test_add_new_keycard_account_and_login
Device sessions

62. test_decline_transactions_in_1_1_chat
Device sessions

63. test_send_and_open_links
Device sessions

64. test_manage_assets
Device sessions

65. test_share_contact_code_and_wallet_address
Device sessions

66. test_send_transaction_with_custom_token
Device sessions

67. test_keycard_send_eth_to_ens
Device sessions

68. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

69. test_redirect_to_public_chat_tapping_tag_message
Device sessions

70. test_block_user_from_public_chat
Device sessions

71. test_create_new_group_chat
Device sessions

72. test_password_in_logcat_sign_in
Device sessions

73. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

74. test_mobile_data_usage_popup_stop_syncing
Device sessions

75. test_send_non_english_message_to_newly_added_contact
Device sessions

76. test_contact_profile_view
Device sessions

77. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

78. test_switch_users_and_add_new_account
Device sessions

79. test_send_two_transactions_in_batch_in_dapp
Device sessions

80. test_filters_from_daap
Device sessions

81. test_login_with_new_account
Device sessions

82. test_home_view
Device sessions

83. test_log_level_and_fleet
Device sessions

84. test_copy_contact_code_and_wallet_address
Device sessions

85. test_fetching_balance_after_offline
Device sessions

86. test_can_see_all_transactions_in_history
Device sessions

@churik churik self-assigned this Jul 8, 2020
@status-im-auto
Copy link
Member

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Passed tests: 0

Failed tests (1)

Click to expand
1. test_can_add_existing_ens

Device 1: Scrolling down to ENSusernames
Device 1: Scrolling down to ENSusernames

Device 1: 'ENSusernames' is not found on the screen; also Unexpected Alert is shown: 'Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token'

Device sessions

@churik
Copy link
Member

churik commented Jul 8, 2020 •
edited
Loading

@flexsurfer can't reproduce Wrong name for token FUEL at address 0xea38eaa3c86c8f9b751533ba2e562deb9acded40 - set to Etherparty FUEL but detected as Fuel Token manually, but it is failed constantly on e2e builds when switching from Ropsten (default in e2e builds) to Mainnet (#10923 (comment))

Can you please take a look?
0034screenshot

@flexsurfer
Copy link
Member Author

@churik i just fixed validation in e2e but i didn't fix warnings, so currently there are warnings in e2e

@churik
Copy link
Member

churik commented Jul 8, 2020

@flexsurfer so what we need here? to tap OK to dismiss the warning?
It blocks now 10 e2e, so I'm not sure what is expected here.
For me sounds better to have some kind of button somewhere in e2e which will show this warning on tapping.

Also not clear what can I test to check PR itself.

@flexsurfer
Copy link
Member Author

we need a decision what to do with these warnings, my suggestion we just need to fix tokens data in status-react according to contracts @Serhy wdyt ?

@Serhy
Copy link
Contributor

Serhy commented Jul 8, 2020

we need a decision what to do with these warnings, my suggestion we just need to fix tokens data in status-react according to contracts @Serhy wdyt ?

Yes, correct. To set token names according to their name in contract. Do you want me to gather that data, @flexsurfer ?

@churik
Copy link
Member

churik commented Jul 10, 2020

@flexsurfer just found:

:symbol  :SUPR
 :nft?    true
 :name    "SupeRare"
 :address "0x41a322b28d0ff354040e2cbc676f0320d8c8850d"

https://etherscan.io/token/0xb932a70a57673d89f4acffbe830e8ed7f75fb9e0
https://etherscan.io/token/0x41a322b28d0ff354040e2cbc676f0320d8c8850d

We use https://etherscan.io/token/0x41a322b28d0ff354040e2cbc676f0320d8c8850d

But when I made transaction in
https://superrare.co/ I've got transaction from https://etherscan.io/token/0xb932a70a57673d89f4acffbe830e8ed7f75fb9e0 (so seems this is right one)

Tr hash: 0x888aa55af3e6e495af94fe6a61b6659d12237b3bc27b08561862b622815bb9ad

@churik
Copy link
Member

churik commented Jul 10, 2020

Another one:
https://ethermon.io/
https://etherscan.io/token/0x5d00d312e171be5342067c09bae883f9bcb2003b
In Status:

                   {:symbol  :EMONA
                    :nft?    true
                    :name    "EtheremonAsset"
                    :address "0xb2c0782ae4a299f7358758b2d15da9bf29e1dd99"}

@flexsurfer
Copy link
Member Author

@Serhy @churik fixed all tokens according to warnings , please take a look on changes

@Serhy
Copy link
Contributor

Serhy commented Jul 10, 2020

  1. FXC token left unchanged (duplicated and with the same icons)
  2. On iOS Decentraland token lost icon after update: nothing is shown on iOS and on Android there is a default token icon

Screenshot 2020-07-10 at 14 20 32

@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 96
Failed tests: 3
Passed tests: 93

Failed tests (3)

Click to expand
1. test_logcat_backup_recovery_phrase

Device 1: Tap on DoneButton
Device 1: Tap on YesButton

Device 1: ['Passphrase1 in logcat!!!', 'Passphrase2 in logcat!!!']

Device sessions

2. test_pair_devices_sync_one_to_one_contacts_public_chat

Device 2: Scrolling up to ContactsButton
Device 2: Scrolling up to ContactsButton

Device 2: 'ContactsButton' is not found on the screen

Device sessions

3. test_decline_transactions_in_1_1_chat

Device 2: ChatMessageInput element not found
Device 2: Looking for a message by text: '↓ Incoming transaction'

Device 2: 'DeclineTransaction' is not found on the screen

Device sessions

Passed tests (93)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_keycard_can_see_all_transactions_in_history
Device sessions

5. test_offline_status
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_open_chat_by_pasting_public_key
Device sessions

8. test_back_forward_buttons_browsing_website
Device sessions

9. test_password_in_logcat_creating_account
Device sessions

10. test_can_use_purchased_stickers_on_recovered_account
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_unread_messages_counter_public_chat
Device sessions

15. test_send_two_transactions_one_after_another_in_dapp
Device sessions

16. test_user_can_switch_network
Device sessions

17. test_public_chat_clear_history
Device sessions

18. test_wallet_set_up
Device sessions

19. test_timestamp_in_chats
Device sessions

20. test_delete_chats_via_delete_button
Device sessions

21. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

22. test_fetch_more_history_in_empty_chat
Device sessions

23. test_mobile_data_usage_popup_continue_syncing
Device sessions

24. test_keycard_fetching_balance_after_offline
Device sessions

25. test_add_to_contacts
Device sessions

26. test_dapps_permissions
Device sessions

27. test_long_press_delete_clear_all_dapps
Device sessions

28. test_need_help_section
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_offline_messaging_1_1_chat
Device sessions

31. test_add_account_to_multiaccount_instance_private_key
Device sessions

32. test_text_message_1_1_chat
Device sessions

33. test_install_pack_and_send_sticker
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_image_in_one_to_one_send_save_reply
Device sessions

36. test_send_emoji
Device sessions

37. test_copy_and_paste_messages
Device sessions

38. test_keycard_send_eth_in_1_1_chat
Device sessions

39. test_restore_account_from_mnemonic_to_keycard
Device sessions

40. test_add_account_to_multiaccount_instance_generate_new
Device sessions

41. test_send_eth_from_wallet_to_address
Device sessions

42. test_messaging_in_different_networks
Device sessions

43. test_start_chat_with_ens
Device sessions

44. test_logcat_recovering_account
Device sessions

45. test_offline_add_new_group_chat_member
Device sessions

46. test_connection_is_secure
Device sessions

47. test_keycard_send_transaction_from_daap
Device sessions

48. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

49. test_send_eth_to_ens_in_chat
Device sessions

50. test_keycard_sign_message_from_daap
Device sessions

51. test_long_press_to_delete_chat
Device sessions

52. test_add_and_remove_contact_from_public_chat
Device sessions

53. test_send_transaction_from_daap
Device sessions

54. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

55. test_keycard_send_eth_from_wallet_to_address
Device sessions

56. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

57. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

58. test_open_blocked_site
Device sessions

59. test_refresh_button_browsing_app_webview
Device sessions

60. test_public_chat_messaging
Device sessions

61. test_pass_phrase_validation
Device sessions

62. test_send_token_with_7_decimals
Device sessions

63. test_sign_message_from_daap
Device sessions

64. test_recover_account_from_new_user_seedphrase
Device sessions

65. test_add_new_keycard_account_and_login
Device sessions

66. test_send_and_open_links
Device sessions

67. test_manage_assets
Device sessions

68. test_share_contact_code_and_wallet_address
Device sessions

69. test_send_transaction_with_custom_token
Device sessions

70. test_keycard_send_eth_to_ens
Device sessions

71. test_can_recover_keycard_account_card_pairing
Device sessions

72. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

73. test_redirect_to_public_chat_tapping_tag_message
Device sessions

74. test_block_user_from_public_chat
Device sessions

75. test_ens_in_public_and_1_1_chats
Device sessions

76. test_create_new_group_chat
Device sessions

77. test_password_in_logcat_sign_in
Device sessions

78. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

79. test_mobile_data_usage_popup_stop_syncing
Device sessions

80. test_send_non_english_message_to_newly_added_contact
Device sessions

81. test_contact_profile_view
Device sessions

82. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

83. test_switch_users_and_add_new_account
Device sessions

84. test_send_two_transactions_in_batch_in_dapp
Device sessions

85. test_filters_from_daap
Device sessions

86. test_login_with_new_account
Device sessions

87. test_home_view
Device sessions

88. test_log_level_and_fleet
Device sessions

89. test_can_add_existing_ens
Device sessions

90. test_copy_contact_code_and_wallet_address
Device sessions

91. test_fetching_balance_after_offline
Device sessions

92. test_can_see_all_transactions_in_history
Device sessions

93. test_keycard_request_and_receive_stt_in_1_1_chat_offline
Device sessions

@weekly-digest weekly-digest bot mentioned this pull request Jul 12, 2020
Closed
@churik
Copy link
Member

churik commented Jul 27, 2020

@flexsurfer #10923 (comment)
can you please check the issues when you've got a chance to?

@flexsurfer
Copy link
Member Author

i'm not sure what to do with these two cases @hesterbruikman

  1. tokens have the same symbol, but symbol must be unique
  2. token has strange name ^
    we can remove them from list, but the problem users can add them as custom tokens and problem is here

@churik
Copy link
Member

churik commented Jul 31, 2020

according to FXC

https://etherscan.io/address/0xc92D6E3E64302C59d734f3292E2A13A13D7E1817 - last transaction was 92 days ago; not sure it is used now.
https://etherscan.io/address/0x4a57E687b9126435a9B19E4A802113e266AdeBde - contract is active.

@flexsurfer
Copy link
Member Author

ok so for 1 we can remove "old" token and prevent creating tokens with the same symbol , not sure what to do with 2

@hesterbruikman
Copy link
Contributor

@flexsurfer is the issue that we don't have an icon for MANA (decentraland)?

@flexsurfer
Copy link
Member Author

flexsurfer commented Jul 31, 2020 •
edited
Loading

@hesterbruikman no, the issue that it has a symbol name ^ that can't be used as a path for the image

@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
@Serhy
Copy link
Contributor

Serhy commented Aug 6, 2020

I thought that we may need to have some balance between token names and symbols used in the contracts and, like, in more centralised world.
For example when the one search for Dentacoin, - token symbol in coinmarketcap is DCN. And centralised exchanges having this token also uses DCN. So here better even to use DCN than ٨

Similar thing with DAI and SAI tokens:
DAI: https://etherscan.io/address/0x6b175474e89094c44da98b954eedeac495271d0f#readContract -> symbol in contract DAI. We use DAI.
SAI: https://etherscan.io/address/0x89d24a6b4ccb1b6faa2625fe562bdd9a23260359#readContract -> symbol in contract DAI (hex 0x4441490000000000000000000000000000000000000000000000000000000000). We use at the moment in develop SAI which is good.

There are some other token with similar story when contract symbol is not the same (or even similar) to what in coinmarketcap.

So what I suggest at this point is to use DCN for Dentacoin which should fix (2) in #10923 (comment) and so we able to push this in v1.6

@flexsurfer @hesterbruikman what do you think?

@hesterbruikman
Copy link
Contributor

That makes sense to me @Serhy DCN for Dentacoin.

@flexsurfer any thoughts on the best approach to update in general? As I understand, it's best to get token name from token tracker on Etherscan (is that right @Serhy?)

What I recall from the most recent round was that Simon provided icons for a range of tokens. @Ferossgp then wrote a script to get info for those tokens. From what I gather it's probably more durable for us to contribute to https://github.com/ethereum-lists/tokens providing icon design there and using an open source list. Wdyt?

@weekly-digest weekly-digest bot mentioned this pull request Aug 9, 2020
Closed
@flexsurfer
Copy link
Member Author

@Serhy i would agree with you, but still think we should keep validation and show this error in e2e and handle it , also we need to prevent creating custom token with an existing symbol

@flexsurfer
Copy link
Member Author

@Serhy so i've fixed all issues, removed this FXC https://etherscan.io/address/0xc92D6E3E64302C59d734f3292E2A13A13D7E1817 - last transaction was 92 days ago; not sure it is used now.
and reverted DCN back and added it to ignore on symbol verification

@flexsurfer
Copy link
Member Author

added two more validation, symbols and addresses duplication, and found 1 item with the duplicated symbol and one with duplicated address

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 98
Failed tests: 7
Passed tests: 91

IDs of failed tests: 5386, 6305, 5313, 5758, 5786, 5315, 6315

Failed tests (7)

Click to expand
1. test_public_chat_clear_history, id: 5386
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/00d9dbbb7bdd412f9c08d0040b4a9a87

2. test_image_in_one_to_one_send_save_reply, id: 6305
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/7c41c791e42246f7afb65bab9f130389

3. test_public_chat_messaging, id: 5313
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/89420b17062c434b8675677673c60414

4. test_can_recover_keycard_account_card_pairing, id: 5758

Device 1: Wait for MultiAccountOnLoginButton
Device 1: Tap on MultiAccountOnLoginButton

Device 1: 'OnePinKeyboardButton' is not found on the screen

Device sessions

5. test_block_user_from_public_chat, id: 5786
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/e39943c5494247338f56a53caaec5df6

6. test_send_non_english_message_to_newly_added_contact, id: 5315
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/0946c5bf72a44e728b422267c1c8528b

7. test_reactions_to_message_in_chats, id: 6315
Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/1acb22e16dff4955afcdb4ff90fa0dc0

Passed tests (91)

Click to expand
1. test_request_public_key_status_test_daap, id: 5397
Device sessions

2. test_open_public_chat_using_deep_link, id: 5396
Device sessions

3. test_ens_username_recipient, id: 5406
Device sessions

4. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions

5. test_offline_status, id: 5326
Device sessions

6. test_open_transaction_on_etherscan, id: 5384
Device sessions

7. test_open_chat_by_pasting_public_key, id: 5304
Device sessions

8. test_back_forward_buttons_browsing_website, id: 5321
Device sessions

9. test_password_in_logcat_creating_account, id: 5414
Device sessions

10. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions

11. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions

12. test_mobile_data_usage_settings, id: 6229
Device sessions

13. test_open_google_com_via_open_dapp, id: 5320
Device sessions

14. test_logcat_backup_recovery_phrase, id: 5419
Device sessions

15. test_unread_messages_counter_public_chat, id: 5360
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions

17. test_user_can_switch_network, id: 5299
Device sessions

18. test_wallet_set_up, id: 5335
Device sessions

19. test_timestamp_in_chats, id: 5385
Device sessions

20. test_delete_chats_via_delete_button, id: 5387
Device sessions

21. test_add_account_to_multiaccount_instance_seed_phrase, id: 6271
Device sessions

22. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions

23. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions

24. test_push_notification_1_1_chat, id: 6283
Device sessions

25. test_mobile_data_usage_popup_continue_syncing, id: 5741
Device sessions

26. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions

27. test_add_to_contacts, id: 5316
Device sessions

28. test_dapps_permissions, id: 5738
Device sessions

29. test_long_press_delete_clear_all_dapps, id: 5390
Device sessions

30. test_need_help_section, id: 5391
Device sessions

31. test_transaction_wrong_password_wallet, id: 5408
Device sessions

32. test_offline_messaging_1_1_chat, id: 5310
Device sessions

33. test_text_message_1_1_chat, id: 5305
Device sessions

34. test_install_pack_and_send_sticker, id: 5782
Device sessions

35. test_send_eth_in_1_1_chat, id: 6253
Device sessions

36. test_pair_devices_sync_one_to_one_contacts_public_chat, id: 5762
Device sessions

37. test_send_emoji, id: 5328
Device sessions

38. test_copy_and_paste_messages, id: 5317
Device sessions

39. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions

40. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions

41. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions

42. test_send_eth_from_wallet_to_address, id: 5308
Device sessions

43. test_messaging_in_different_networks, id: 5338
Device sessions

44. test_start_chat_with_ens, id: 5403
Device sessions

45. test_logcat_recovering_account, id: 5366
Device sessions

46. test_offline_add_new_group_chat_member, id: 3998
Device sessions

47. test_connection_is_secure, id: 5402
Device sessions

48. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions

49. test_keycard_send_transaction_from_daap, id: 6249
Device sessions

50. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions

51. test_send_eth_to_ens_in_chat, id: 6279
Device sessions

52. test_keycard_sign_message_from_daap, id: 6251
Device sessions

53. test_long_press_to_delete_chat, id: 5319
Device sessions

54. test_add_and_remove_contact_from_public_chat, id: 5332
Device sessions

55. test_send_transaction_from_daap, id: 5309
Device sessions

56. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions

57. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions

58. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions

59. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions

60. test_open_blocked_site, id: 6210
Device sessions

61. test_refresh_button_browsing_app_webview, id: 5354
Device sessions

62. test_pass_phrase_validation, id: 5363
Device sessions

63. test_send_token_with_7_decimals, id: 5350
Device sessions

64. test_sign_message_from_daap, id: 5342
Device sessions

65. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions

66. test_add_new_keycard_account_and_login, id: 5689
Device sessions

67. test_send_and_open_links, id: 5373
Device sessions

68. test_manage_assets, id: 5341
Device sessions

69. test_share_contact_code_and_wallet_address, id: 5323
Device sessions

70. test_send_transaction_with_custom_token, id: 6208
Device sessions

71. test_keycard_send_eth_to_ens, id: 6295
Device sessions

72. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions

73. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions

74. test_ens_in_public_and_1_1_chats, id: 6226
Device sessions

75. test_create_new_group_chat, id: 3994
Device sessions

76. test_password_in_logcat_sign_in, id: 5415
Device sessions

77. test_account_recovery_with_uppercase_recovery_phrase, id: 5394
Device sessions

78. test_mobile_data_usage_popup_stop_syncing, id: 6228
Device sessions

79. test_collectible_from_wallet_opens_in_browser_view, id: 5346
Device sessions

80. test_contact_profile_view, id: 5382
Device sessions

81. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
Device sessions

82. test_switch_users_and_add_new_account, id: 5356
Device sessions

83. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions

84. test_filters_from_daap, id: 5353
Device sessions

85. test_login_with_new_account, id: 5312
Device sessions

86. test_home_view, id: 5379
Device sessions

87. test_log_level_and_fleet, id: 5368
Device sessions

88. test_can_add_existing_ens, id: 5502
Device sessions

89. test_copy_contact_code_and_wallet_address, id: 5375
Device sessions

90. test_fetching_balance_after_offline, id: 6237
Device sessions

91. test_can_see_all_transactions_in_history, id: 5314
Device sessions

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Passed tests: 7

Passed tests (7)

Click to expand
1. test_public_chat_clear_history, id: 5386
Device sessions

2. test_image_in_one_to_one_send_save_reply, id: 6305
Device sessions

3. test_public_chat_messaging, id: 5313
Device sessions

4. test_can_recover_keycard_account_card_pairing, id: 5758
Device sessions

5. test_block_user_from_public_chat, id: 5786
Device sessions

6. test_send_non_english_message_to_newly_added_contact, id: 5315
Device sessions

7. test_reactions_to_message_in_chats, id: 6315
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Sep 14, 2020

Tested on Android 8.1, Android 9 and iOS 13
All changed tokens display to what they should according to address and token name.
Original issue #10922 fixed too (because one token removed)

@flexsurfer
fix tokens validation
301f1c8 
Signed-off-by: andrey <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 301f1c8 into develop Sep 14, 2020
@flexsurfer flexsurfer deleted the bug/tokens-validation branch September 14, 2020 14:07
@hesterbruikman
Copy link
Contributor

@flexsurfer just found:

:symbol  :SUPR
 :nft?    true
 :name    "SupeRare"
 :address "0x41a322b28d0ff354040e2cbc676f0320d8c8850d"

https://etherscan.io/token/0xb932a70a57673d89f4acffbe830e8ed7f75fb9e0
https://etherscan.io/token/0x41a322b28d0ff354040e2cbc676f0320d8c8850d

We use https://etherscan.io/token/0x41a322b28d0ff354040e2cbc676f0320d8c8850d

But when I made transaction in
https://superrare.co/ I've got transaction from https://etherscan.io/token/0xb932a70a57673d89f4acffbe830e8ed7f75fb9e0 (so seems this is right one)

Tr hash: 0x888aa55af3e6e495af94fe6a61b6659d12237b3bc27b08561862b622815bb9ad

Indeed looks like we use the ERC20 token address where we should be using the ERC721 token address

Symbol SUPR
Name SuperRare

@flexsurfer can you please take a look to see if that works. Let me know if I need to create a separate issue

@flexsurfer
Copy link
Member Author

flexsurfer commented Sep 23, 2020 •
edited
Loading

it needs a separate issue for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serhy Serhy Serhy approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@Ferossgp Ferossgp Awaiting requested review from Ferossgp

Assignees

@churik churik

@flexsurfer flexsurfer

Labels
request-manual-qa
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
Mobile bug fixes and small improvements
Development

Successfully merging this pull request may close these issues.

Two tokens (Flexacoin and FUTURAX) is checked and unchecked at the same time in "Wallet" -> "Manage assets"
5 participants
@flexsurfer @status-im-auto @churik @Serhy @hesterbruikman