[DO NOT MERGE] Nim-Status: iOS/Android support #10936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (242)
|
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
f1492d1 to
cec0722
Compare
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
7a610d8 to
8fe680b
Compare
jakubgs
force-pushed
the
feature/nim-status-ios
branch
4 times, most recently
from
1051aab to
3dfaab7
Compare
vitvly
force-pushed
the
feature/nim-status-ios
branch
3 times, most recently
from
6577f37 to
cc1bd3e
Compare
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
1d67939 to
797b108
Compare
jakubgs
reviewed
Sep 30, 2020
nix/status-go/shared/build.nix
Outdated
| else if platform == "androideabi" then "arm "else "arm64" | ||
| else | ||
| if arch == "386" then "amd64" else | ||
| if arch == "arm" then "arm" else "arm64"; |
There was a problem hiding this comment.
I was thinking more like:
{
goArch =
if isAndroid then (
if arch == "386" then "386" else
if platform == "androideabi" then "arm"
else "arm64"
) else if isIOS then (
if arch == "386" then "amd64" else
if arch == "arm" then "arm"
else "arm64"
) else throw "Uknown Platform!";
}There was a problem hiding this comment.
The if platform == "androideabi" then "arm" part makes me worried tho. Every other if is checking arch, but this one is checking platform. Some weird edge case?
There was a problem hiding this comment.
The else "arm64" is kinda ugly too. I'd prefer a clear case rather than else.
jakubgs
reviewed
Sep 30, 2020
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
797b108 to
08e6085
Compare
61% of end-end tests have passedFailed tests (38)Click to expand
Passed tests (60)Click to expand
|
|
@siphiuel could you rebase against develop and re-run e2e tests please once the build is ready? (go to projects -> Pipelien for Qa -> Move issue from e2e column to another column and back to e2e will trigger them) https://github.com/status-im/status-react/projects/7 Thank you! |
jakubgs
reviewed
Nov 9, 2020
| url = "https://ftp.pcre.org/pub/pcre/pcre-8.44.tar.gz"; | ||
| sha256 = "0a3pnhzhd8wipmqq9dcn3phb494hkn47pxqsf8skj3xxyd5gvjmf"; | ||
|
|
||
| }; |
jakubgs
reviewed
Nov 9, 2020
| url = "https://www.openssl.org/source/openssl-1.1.1h.tar.gz"; | ||
| sha256 = "5c9ca8774bd7b03e5784f26ae9e9e6d749c9da2438545077e6b3d755a06595d9"; | ||
|
|
||
| }; |
There was a problem hiding this comment.
Why can't we use pkgs.openssl.src?
ISSUE 2 Crash on IOS when tapping "Generate keys" on nightly build from PR branchMade nightly builds from 'feature/nim-status-ios' StatusIm-201109-122725-afdb9d-nightly.ipa_2020_11_9_15_42_49.log ISSUE 3 Can't build IOS release buildBuild: https://ci.status.im/job/status-react/job/combined/job/mobile-ios/8357/console |
churik
changed the title
|
On issue 2 - tried running |
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
afdb9db to
7c9c5c8
Compare
|
@siphiuel |
|
@siphiuel any updates on this? |
|
@churik i've updated the |
|
@siphiuel any updates ? |
|
@flexsurfer will rebase, resolve conflicts, and retest. This is still relevant. |
added 6 commits
February 5, 2021 12:19
Cleanup Refactoring Review fixes Use coreutils inside writeScript Fix androidToolPathPrefix nim-make: initial Common srcRaw; updates to API Updates to ios build; remove GoStruct references in android's JNI file Android fix; update nim-status rev Add openssl PCRE updates Updates Commit Linking fixes Include xcodeWrapper in pod-shell (SQLCipher compilation issue) Disable flipper for ios Add patchShebangs and nim-status build TODO line Use fetchgit, custom createNimbleLink script Use clang sha256 change patchShebangs in nim-status src leaveDotGit,deepClone=false CC=clang in for nim-status make sed clang force clang force clang Test Include pcre.h Debugging Debugging 2 Logout crash fix add [start,stop]LocalNotifications disable androidNDK switch Update sha Add nim_status.nim override Add shim Fix shim Fix Podfile.lock Use exported [setup,tearDown]ForeignThreadGc fns Update nim-status Remove onboarding functions
[nightly,release] builds
vitvly
force-pushed
the
feature/nim-status-ios
branch
from
545faff to
283f4d0
Compare
|
Superseded by #11793. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on status-im/nim-status#44 (only because it's behind master for now)
Overview
nim-statusis a wrapper aroundstatus-go. Currentlystatus-gois transformed into something that can be consumed by Android/iOS with help ofgomobile(https://github.com/golang/go/wiki/Mobile). In this PR,gomobileoutputs are replaced by 2 libs (static/shared) -libstatusandlibnim_status, compiled fromstatus-goandnim-statusrespectively.To that end, 2 new derivations are added to
nix/status-go-shared(for status-go builds) andnim-status(fornim-statusbuilds).Huge thanks to @jakubgs for hand-holding during Nix travails.