Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10195] Delete multiaccount #10955

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[#10195] Delete multiaccount #10955

merged 1 commit into from
Jul 28, 2020

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jul 14, 2020 •
edited
Loading

fix #10195

It is not implemented fort keycard yet, but the main purpose if it is to allow users to migrate to keycard, so that can be handled in a separate PR.

status: ready

@rasom rasom requested a review from a team as a code owner July 14, 2020 13:34
@rasom rasom self-assigned this Jul 14, 2020
@rasom rasom force-pushed the delete-multiaccount branch from 2da729f to c141ca1 Compare July 14, 2020 13:37
@status-im-auto
Copy link
Member

status-im-auto commented Jul 14, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c141ca1 #2 2020-07-14 13:53:47 ~16 min ios 📦ipa 📲
✔️ c141ca1 #2 2020-07-14 13:54:05 ~16 min android-e2e 📦apk 📲
✔️ c141ca1 #2 2020-07-14 13:54:19 ~16 min android 📦apk 📲
✔️ 9feee9c #3 2020-07-16 07:58:16 ~13 min ios 📦ipa 📲
✔️ 9feee9c #3 2020-07-16 08:02:00 ~17 min android-e2e 📦apk 📲
✖️ d51d654 #4 2020-07-24 12:45:26 ~10 min android 📦apk 📲
✖️ d51d654 #4 2020-07-24 12:45:28 ~10 min android-e2e 📦apk 📲
✖️ d51d654 #4 2020-07-24 12:47:37 ~12 min ios 📦ipa 📲
✔️ 5c4a56a #8 2020-07-24 15:11:39 ~11 min android-e2e 📦apk 📲
✔️ 5c4a56a #8 2020-07-24 15:11:43 ~11 min android 📦apk 📲
✔️ 5c4a56a #8 2020-07-24 15:14:11 ~14 min ios 📦ipa 📲
✔️ 0238b6e #9 2020-07-24 16:01:03 ~9 min android-e2e 📦apk 📲
✔️ 0238b6e #9 2020-07-24 16:02:35 ~11 min android 📦apk 📲
✔️ 0238b6e #9 2020-07-24 16:05:43 ~14 min ios 📦ipa 📲
✔️ 695a664 #11 2020-07-24 16:22:03 ~11 min android-e2e 📦apk 📲
✔️ 695a664 #11 2020-07-24 16:22:08 ~11 min android 📦apk 📲
✔️ 695a664 #11 2020-07-24 16:23:27 ~13 min ios 📦ipa 📲
✔️ 1b0c563 #12 2020-07-25 05:16:08 ~12 min android-e2e 📦apk 📲
✔️ 1b0c563 #12 2020-07-25 05:16:08 ~12 min android 📦apk 📲
✔️ 1b0c563 #12 2020-07-25 05:17:48 ~13 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1079128 #13 2020-07-28 08:15:14 ~9 min android 📦apk 📲
✔️ 1079128 #13 2020-07-28 08:15:23 ~9 min android-e2e 📦apk 📲
✔️ 1079128 #13 2020-07-28 08:19:19 ~13 min ios 📦ipa 📲
✔️ 10a8147 #14 2020-07-28 12:55:27 ~12 min android-e2e 📦apk 📲
✔️ 10a8147 #14 2020-07-28 12:55:29 ~12 min android 📦apk 📲
✔️ 10a8147 #14 2020-07-28 12:56:44 ~13 min ios 📦ipa 📲

@rasom rasom force-pushed the delete-multiaccount branch from c141ca1 to 9feee9c Compare July 16, 2020 07:44
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
@rasom rasom force-pushed the delete-multiaccount branch 3 times, most recently from 6cdc477 to 5c4a56a Compare July 24, 2020 14:59
andremedeiros
andremedeiros approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@andremedeiros andremedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nitpicky things, but looks good 👏

Excited to being able to clean up multi accounts!

modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java Outdated Show resolved Hide resolved
modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java Outdated Show resolved Hide resolved
modules/react-native-status/ios/RCTStatus/RCTStatus.m Outdated Show resolved Hide resolved
modules/react-native-status/ios/RCTStatus/RCTStatus.m Outdated Show resolved Hide resolved
src/quo/components/separator.cljs Show resolved Hide resolved
src/status_im/ui/screens/privacy_and_security_settings/delete_profile.cljs
(if keycard?
[keycard-pin]
[quo/text-input
{:style {:margin-horizontal 36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have pre-defined styles for this sort of thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice, @Ferossgp any ideas?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we do not have a component which will manage spacing, but I'm looking at this approach https://github.com/mobily/stacks

@hesterbruikman
Copy link
Contributor

cc @johnlea-quiup

@rasom rasom force-pushed the delete-multiaccount branch from 695a664 to 1b0c563 Compare July 25, 2020 05:03
@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 98
Failed tests: 1
Passed tests: 97

Failed tests (1)

Click to expand
1. test_keycard_request_and_receive_stt_in_1_1_chat_offline

Looking for a transaction with unique amount 0.0027114623 in list of transactions, address is B55B0D599D0472bE73f2Ead892244c8930f14689
Transaction with unique amount 0.0027114623 is found in list of transactions, address is B55B0D599D0472bE73f2Ead892244c8930f14689

Wrong state is shown for outgoing transaction: "Confirmed" is expected, in fact Pending

Device sessions

Passed tests (97)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_public_chat_clear_history
Device sessions

10. test_need_help_section
Device sessions

11. test_send_and_open_links
Device sessions

12. test_mobile_data_usage_popup_stop_syncing
Device sessions

13. test_keycard_send_eth_in_1_1_chat
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_keycard_send_eth_to_ens
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_share_contact_code_and_wallet_address
Device sessions

22. test_connection_is_secure
Device sessions

23. test_add_to_contacts
Device sessions

24. test_add_account_to_multiaccount_instance_private_key
Device sessions

25. test_refresh_button_browsing_app_webview
Device sessions

26. test_push_notification_1_1_chat
Device sessions

27. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_public_chat_messaging
Device sessions

31. test_unread_messages_counter_public_chat
Device sessions

32. test_keycard_send_eth_from_wallet_to_address
Device sessions

33. test_keycard_fetching_balance_after_offline
Device sessions

34. test_keycard_send_transaction_from_daap
Device sessions

35. test_text_message_1_1_chat
Device sessions

36. test_can_use_purchased_stickers_on_recovered_account
Device sessions

37. test_open_transaction_on_etherscan
Device sessions

38. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

39. test_contact_profile_view
Device sessions

40. test_offline_add_new_group_chat_member
Device sessions

41. test_logcat_backup_recovery_phrase
Device sessions

42. test_can_recover_keycard_account_card_pairing
Device sessions

43. test_start_chat_with_ens
Device sessions

44. test_add_and_remove_contact_from_public_chat
Device sessions

45. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

46. test_open_blocked_site
Device sessions

47. test_open_chat_by_pasting_public_key
Device sessions

48. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

49. test_keycard_sign_message_from_daap
Device sessions

50. test_send_non_english_message_to_newly_added_contact
Device sessions

51. test_ens_username_recipient
Device sessions

52. test_fetch_more_history_in_empty_chat
Device sessions

53. test_open_public_chat_using_deep_link
Device sessions

54. test_switch_users_and_add_new_account
Device sessions

55. test_add_account_to_multiaccount_instance_generate_new
Device sessions

56. test_copy_contact_code_and_wallet_address
Device sessions

57. test_send_transaction_from_daap
Device sessions

58. test_send_two_transactions_one_after_another_in_dapp
Device sessions

59. test_image_in_one_to_one_send_save_reply
Device sessions

60. test_add_new_keycard_account_and_login
Device sessions

61. test_long_press_delete_clear_all_dapps
Device sessions

62. test_copy_and_paste_messages
Device sessions

63. test_back_forward_buttons_browsing_website
Device sessions

64. test_password_in_logcat_creating_account
Device sessions

65. test_sign_message_from_daap
Device sessions

66. test_dapps_permissions
Device sessions

67. test_request_public_key_status_test_daap
Device sessions

68. test_long_press_to_delete_chat
Device sessions

69. test_log_level_and_fleet
Device sessions

70. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

71. test_recover_account_from_new_user_seedphrase
Device sessions

72. test_send_transaction_with_custom_token
Device sessions

73. test_send_eth_in_1_1_chat
Device sessions

74. test_send_two_transactions_in_batch_in_dapp
Device sessions

75. test_ens_in_public_and_1_1_chats
Device sessions

76. test_block_user_from_public_chat
Device sessions

77. test_fetching_balance_after_offline
Device sessions

78. test_offline_status
Device sessions

79. test_wallet_set_up
Device sessions

80. test_manage_assets
Device sessions

81. test_offline_messaging_1_1_chat
Device sessions

82. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

83. test_send_token_with_7_decimals
Device sessions

84. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

85. test_pass_phrase_validation
Device sessions

86. test_keycard_can_see_all_transactions_in_history
Device sessions

87. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

88. test_send_emoji
Device sessions

89. test_filters_from_daap
Device sessions

90. test_redirect_to_public_chat_tapping_tag_message
Device sessions

91. test_restore_account_from_mnemonic_to_keycard
Device sessions

92. test_send_eth_to_ens_in_chat
Device sessions

93. test_send_eth_from_wallet_to_address
Device sessions

94. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

95. test_messaging_in_different_networks
Device sessions

96. test_collectible_from_wallet_opens_in_browser_view
Device sessions

97. test_insufficient_funds_wallet_positive_balance
Device sessions

@rasom rasom force-pushed the delete-multiaccount branch from 1b0c563 to 1079128 Compare July 28, 2020 08:05
@hesterbruikman
Copy link
Contributor

Great work @rasom !

Tested

  • iPhone 8, iOS 13 and Smasung Galaxy s10e
  • Scenario 1 - Remove last profile
  • Scenario 2 - Remove a profile

Issue 1 (see image 1)

Current: On iOS, chevron is shown on list item indicating profile name is tappable
Expected: No chevron is shown
Think this might be a component configuration

Frame 1

@churik
Copy link
Member

churik commented Jul 28, 2020

Tested on Android 10 when

  • several multiaccounts are created
  • several account inside one multiaccount are created
  • delete last multiaccount
  • no option to delete keycard multiaccount
  • can restore same multiaccount after deleting with seed phrase

Looks good to me!

@rasom rasom force-pushed the delete-multiaccount branch from 1079128 to 10a8147 Compare July 28, 2020 12:43
@rasom rasom merged commit 10a8147 into develop Jul 28, 2020
@rasom rasom deleted the delete-multiaccount branch July 28, 2020 12:43
@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferossgp Ferossgp Ferossgp approved these changes

@andremedeiros andremedeiros andremedeiros approved these changes

Assignees

@rasom rasom

Labels
request-manual-qa
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow delete multiaccount
6 participants
@rasom @status-im-auto @hesterbruikman @churik @andremedeiros @Ferossgp