Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10988] Add entry point to start new chat from search results #10997

Merged
merged 1 commit into from
Jul 30, 2020
Merged

[#10988] Add entry point to start new chat from search results #10997

merged 1 commit into from
Jul 30, 2020
+56 −17

Conversation

Ferossgp
Copy link
Contributor

Fixes #10988

@Ferossgp Ferossgp requested a review from a team as a code owner July 27, 2020 07:52
@Ferossgp Ferossgp self-assigned this Jul 27, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Jul 27, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 68c5693 #1 2020-07-27 08:02:43 ~10 min android-e2e 📦apk 📲
✔️ 68c5693 #1 2020-07-27 08:03:07 ~10 min android 📦apk 📲
✔️ 68c5693 #1 2020-07-27 08:05:57 ~13 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9209083 #3 2020-07-27 08:56:45 ~9 min android 📦apk 📲
✔️ 9209083 #3 2020-07-27 08:57:46 ~10 min android-e2e 📦apk 📲
✔️ 9209083 #3 2020-07-27 09:02:37 ~15 min ios 📦ipa 📲
✔️ cb4b02b #4 2020-07-28 10:27:39 ~9 min android-e2e 📦apk 📲
✔️ cb4b02b #4 2020-07-28 10:27:56 ~10 min android 📦apk 📲
✔️ cb4b02b #4 2020-07-28 10:30:32 ~12 min ios 📦ipa 📲

flexsurfer
flexsurfer approved these changes Jul 27, 2020
View reviewed changes
src/status_im/ui/screens/home/views.cljs Outdated Show resolved Hide resolved
src/status_im/ui/screens/home/views.cljs Outdated Show resolved Hide resolved
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 98
Failed tests: 1
Passed tests: 97

Failed tests (1)

Click to expand
1. test_fetching_balance_after_offline

Device 1: Wait for EnterPasswordInput
Device 1: EnterPasswordInput element not found

Device 1: 'EnterPasswordInput' is not found on the screen

Device sessions

Passed tests (97)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_public_chat_clear_history
Device sessions

10. test_need_help_section
Device sessions

11. test_send_and_open_links
Device sessions

12. test_mobile_data_usage_popup_stop_syncing
Device sessions

13. test_keycard_send_eth_in_1_1_chat
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_keycard_send_eth_to_ens
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_share_contact_code_and_wallet_address
Device sessions

22. test_connection_is_secure
Device sessions

23. test_add_to_contacts
Device sessions

24. test_add_account_to_multiaccount_instance_private_key
Device sessions

25. test_refresh_button_browsing_app_webview
Device sessions

26. test_push_notification_1_1_chat
Device sessions

27. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_public_chat_messaging
Device sessions

31. test_unread_messages_counter_public_chat
Device sessions

32. test_keycard_send_eth_from_wallet_to_address
Device sessions

33. test_keycard_fetching_balance_after_offline
Device sessions

34. test_keycard_send_transaction_from_daap
Device sessions

35. test_text_message_1_1_chat
Device sessions

36. test_can_use_purchased_stickers_on_recovered_account
Device sessions

37. test_open_transaction_on_etherscan
Device sessions

38. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

39. test_contact_profile_view
Device sessions

40. test_offline_add_new_group_chat_member
Device sessions

41. test_logcat_backup_recovery_phrase
Device sessions

42. test_can_recover_keycard_account_card_pairing
Device sessions

43. test_start_chat_with_ens
Device sessions

44. test_add_and_remove_contact_from_public_chat
Device sessions

45. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

46. test_open_blocked_site
Device sessions

47. test_open_chat_by_pasting_public_key
Device sessions

48. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

49. test_keycard_sign_message_from_daap
Device sessions

50. test_send_non_english_message_to_newly_added_contact
Device sessions

51. test_ens_username_recipient
Device sessions

52. test_fetch_more_history_in_empty_chat
Device sessions

53. test_open_public_chat_using_deep_link
Device sessions

54. test_switch_users_and_add_new_account
Device sessions

55. test_add_account_to_multiaccount_instance_generate_new
Device sessions

56. test_copy_contact_code_and_wallet_address
Device sessions

57. test_send_transaction_from_daap
Device sessions

58. test_send_two_transactions_one_after_another_in_dapp
Device sessions

59. test_image_in_one_to_one_send_save_reply
Device sessions

60. test_add_new_keycard_account_and_login
Device sessions

61. test_long_press_delete_clear_all_dapps
Device sessions

62. test_copy_and_paste_messages
Device sessions

63. test_back_forward_buttons_browsing_website
Device sessions

64. test_password_in_logcat_creating_account
Device sessions

65. test_sign_message_from_daap
Device sessions

66. test_dapps_permissions
Device sessions

67. test_request_public_key_status_test_daap
Device sessions

68. test_long_press_to_delete_chat
Device sessions

69. test_log_level_and_fleet
Device sessions

70. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

71. test_recover_account_from_new_user_seedphrase
Device sessions

72. test_send_transaction_with_custom_token
Device sessions

73. test_keycard_request_and_receive_stt_in_1_1_chat_offline
Device sessions

74. test_send_eth_in_1_1_chat
Device sessions

75. test_send_two_transactions_in_batch_in_dapp
Device sessions

76. test_ens_in_public_and_1_1_chats
Device sessions

77. test_block_user_from_public_chat
Device sessions

78. test_offline_status
Device sessions

79. test_wallet_set_up
Device sessions

80. test_manage_assets
Device sessions

81. test_offline_messaging_1_1_chat
Device sessions

82. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

83. test_send_token_with_7_decimals
Device sessions

84. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

85. test_pass_phrase_validation
Device sessions

86. test_keycard_can_see_all_transactions_in_history
Device sessions

87. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

88. test_send_emoji
Device sessions

89. test_filters_from_daap
Device sessions

90. test_redirect_to_public_chat_tapping_tag_message
Device sessions

91. test_restore_account_from_mnemonic_to_keycard
Device sessions

92. test_send_eth_to_ens_in_chat
Device sessions

93. test_send_eth_from_wallet_to_address
Device sessions

94. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

95. test_messaging_in_different_networks
Device sessions

96. test_collectible_from_wallet_opens_in_browser_view
Device sessions

97. test_insufficient_funds_wallet_positive_balance
Device sessions

@churik
Copy link
Member

churik commented Jul 27, 2020

@Ferossgp

ISSUE 1: Error when tap on public chat name under "Do you mean"

Steps:

  1. join any public chat
  2. type 'aaaaa' in search
  3. tap on 'aaaa' under Do you mean

Expected result: redirect to public chat
Actual result:
IMAGE 2020-07-27 18:15:18

ISSUE 2: No chats are suggested if I type existing ENS with domain

I.e. when typing 'tanyatest1.eth' or 'qbnewzz.stateofus.eth' I would expect that 1-1 chat is suggested

ISSUE 3: Search input is not cleared after redirecting to chat

Steps:

  1. join any public chat
  2. type 'tanyatest10' in search
  3. tap to start 1-1 chat
  4. tap back

Expected result: redirect to home view, search input is cleared
Actual result: redirect to home view, in the search field the same value is set

ISSUE 4: 1-1 chat is not suggested in case of pasting ENS to search input

Steps:
Scenario 1:

  1. join any public chat
  2. paste 'tanyatest10' in search

Expected result: 1-1 chat will be suggested
Actual result: nothing happened

@Ferossgp
Copy link
Contributor Author

Ferossgp commented Jul 28, 2020 •
edited
Loading

@churik

ISSUE 1

Fixed

ISSUE 2:

Most probably the connection was slow? We do not show spinner for loading but use the same logic as start a new chat. I've tried these ens and it worked.

ISSUE 3: Search input is not cleared after redirecting to chat

This is the same behavior as searching other chats

ISSUE 4

Fixed

@qoqobolo
Copy link
Contributor

qoqobolo commented Jul 29, 2020 •
edited
Loading

@Ferossgp

ISSUE 5: Search input and chat list disappear after deleting public chat if navigating from suggestions

Steps:

  1. Join any public chat
  2. Type random word in search
  3. Tap "Join a public chat"
  4. In opened chat tap 3 dots on the top right
  5. Delete chat -> Delete

Expected result: redirect to home screen, chat list and search input are shown
Actual result: redirect to home screen, no chat list and search input

Video: https://drive.google.com/file/d/1-sJDkNWG5bQnBmX6bBdNavR87_cQBdNP/view?usp=sharing

@Ferossgp
Copy link
Contributor Author

Ferossgp commented Jul 30, 2020 •
edited
Loading

@qoqobolo Because this is also present in current release and it is not a regression of this PR, I would prefer to have it as a separate issue to be solved independently of this task

@qoqobolo
Copy link
Contributor

@Ferossgp Yes, you are right about both issues (3 and 5)! Thanks for a great job and sorry for the distraction.

@qoqobolo
Copy link
Contributor

Tested latest build which are https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200728-101749-cb4b02-pr-universal.apk and https://i.diawi.com/ox3cbt on Android 8, Android 10 and iOS 13.

Scenarios verified:

  1. Join 1-1 chats and public chats and search for them (typing value, pasting value)
  2. Typing and pasting chat’s name that are not in my chat list and joining them via “Do you mean” links:
  • ens names (no domen, with .stateofus.eth, with .eth)
  • valid values for public chat names, but not valid ENS
  1. Invalid values + adding chars in the end of value / deleting chars in the end
  2. Navigating back and forth after some actions in chat view (deleting chats, clearing history)

@Ferossgp
[#10988] Add entry point to start new chat from search results
8652f89 
Fixes #10988

Allow public key and filter public chats

Make toolbar width 100

Clear new identity from search

QA issues fix

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
@Ferossgp Ferossgp force-pushed the feature/new-chat-from-search branch from cb4b02b to 8652f89 Compare July 30, 2020 10:47
@Ferossgp Ferossgp merged commit 8652f89 into develop Jul 30, 2020
@Ferossgp Ferossgp deleted the feature/new-chat-from-search branch July 30, 2020 10:47
@weekly-digest weekly-digest bot mentioned this pull request Aug 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@Ferossgp Ferossgp

@qoqobolo qoqobolo

Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add entry point to start new chat from search results
5 participants
@Ferossgp @status-im-auto @churik @qoqobolo @flexsurfer