-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F-Droid build enabling changes #11004
Conversation
Jenkins BuildsClick to see older builds (3)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@jakubgs this is fantastic! For my understanding, does this mean packaging is all done and we could submit 1.5 when ready or should we still go through a request for packaging? If we can start with 1.4.1, what would be actions needed? |
@hesterbruikman I have not submitted the App to F-Droid yet. And I've been wondering how to do it. We can either wait till
I think the first option is more... proper? Kosher? |
I'm thinking the 2nd, keeps any view on retention data more pure as we know what was in a release for 1.4.1, followed by 1.5. More build makes impact harder to track. So I think it makes sense to:
What makes you consider the first option 1.4.2 more kosher? |
Just a general rule that if you apply changes you should change the version. But to be fair the changes are only related to the build system, and none the that app codebase itself, so in theory the resulting application should be almost identical. If you think that's better I don't really mind. This way we can get it ready for the |
@churik should I worry about the one e2e test failing? |
@jakubgs no, that is fixed in develop |
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (97)Click to expand
|
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
After a lot of research in #8512 I finally have a working F-Droid build using this branch.
Changes:
build-use-sandbox = true
for Android Nix buildsorg.gradle.daemon=false
for Nix Android buildsANDROID_APK_SIGNED
to make unsigned builds for F-DroidI think we should be able to release
1.5.0
on F-Droid.It should be also doable to release
1.4.1
with these changes.