Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text input animations lags #11033

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix text input animations lags #11033

merged 1 commit into from
Aug 10, 2020

Conversation

Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Aug 4, 2020

No description provided.

@Ferossgp Ferossgp requested a review from a team as a code owner August 4, 2020 12:41
@Ferossgp Ferossgp self-assigned this Aug 4, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Aug 4, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 0ab2c15 #1 2020-08-04 12:49:40 ~8 min android-e2e 📦apk 📲
✖️ 0ab2c15 #1 2020-08-04 12:50:53 ~9 min android 📦apk 📲
✖️ 33ee152 #2 2020-08-04 13:02:20 ~8 min android-e2e 📦apk 📲
✖️ 33ee152 #2 2020-08-04 13:04:34 ~10 min android 📦apk 📲
✖️ 1f46f41 #3 2020-08-04 15:15:00 ~10 min android 📦apk 📲
✖️ 1f46f41 #3 2020-08-04 15:19:58 ~15 min ios 📦ipa 📲
✖️ 1f46f41 #3 2020-08-04 15:22:20 ~17 min android-e2e 📦apk 📲
✖️ fb7ef84 #4 2020-08-05 08:11:56 ~12 min android-e2e 📦apk 📲
✖️ fb7ef84 #4 2020-08-05 08:12:11 ~12 min android 📦apk 📲
✖️ fb7ef84 #4 2020-08-05 08:14:27 ~14 min ios 📦ipa 📲
✖️ 2c1645d #5 2020-08-05 08:39:01 ~8 min android-e2e 📦apk 📲
✖️ 2c1645d #5 2020-08-05 08:40:31 ~9 min android 📦apk 📲
✖️ 2c1645d #5 2020-08-05 08:45:47 ~14 min ios 📦ipa 📲
✔️ 2a0e9f7 #6 2020-08-05 09:44:36 ~10 min android 📦apk 📲
✔️ 2a0e9f7 #6 2020-08-05 09:45:04 ~10 min android-e2e 📦apk 📲
✔️ 2a0e9f7 #6 2020-08-05 09:47:42 ~13 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 5ab3ad9 #7 2020-08-07 09:21:22 ~3 min android 📄log
❌ 5ab3ad9 #7 2020-08-07 09:21:23 ~3 min android-e2e 📄log
✔️ bc64eb3 #8 2020-08-07 09:41:55 ~9 min android-e2e 📦apk 📲
✔️ bc64eb3 #8 2020-08-07 09:42:38 ~10 min android 📦apk 📲
✔️ bc64eb3 #8 2020-08-07 09:46:11 ~14 min ios 📦ipa 📲

@Serhy
Copy link
Contributor

Serhy commented Aug 4, 2020 •
edited
Loading

On Android 9 still can reproduce the issue.
In 1-1 chat (with 30 stickers and 5 images) - scrolled down while keyboard was open and switched to images pad - it collapses sticker/command/image (until re-navigate to chat view)
(tested second Jenkins build https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200804-125414-33ee15-pr-universal.apk)

@Ferossgp Ferossgp changed the title WIP: Fix text input animations lags Fix text input animations lags Aug 5, 2020
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 97
Failed tests: 4
Passed tests: 93

Failed tests (4)

Click to expand
1. test_push_notification_1_1_chat

Device 1: Device 1 checks PN with emoji
Device 1: Looking for an element by text part: '🎬'

Device 1: Push notification with emoji was not received

Device sessions

2. test_image_in_one_to_one_send_save_reply

Device 2: Looking for a message by text: 'image reply'
Device 2: Wait for ImageInReply

Image doesn't match expected template for sender Image doesn't match expected template for receiver

Device sessions

3. test_decline_transactions_in_1_1_chat

Device 2: ChatMessageInput element not found
Device 2: Looking for a message by text: '↓ Incoming transaction'

Device 2: 'DeclineTransaction' is not found on the screen

Device sessions

4. test_fetching_balance_after_offline

Device 1: AssetText is 199.8890201071 STT
Device 1: Waiting 300 seconds for STT to update

Device 1: Balance is not changed during 300 seconds!

Device sessions

Passed tests (93)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_keycard_can_see_all_transactions_in_history
Device sessions

5. test_offline_status
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_open_chat_by_pasting_public_key
Device sessions

8. test_back_forward_buttons_browsing_website
Device sessions

9. test_password_in_logcat_creating_account
Device sessions

10. test_can_use_purchased_stickers_on_recovered_account
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_logcat_backup_recovery_phrase
Device sessions

15. test_unread_messages_counter_public_chat
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_public_chat_clear_history
Device sessions

19. test_wallet_set_up
Device sessions

20. test_timestamp_in_chats
Device sessions

21. test_delete_chats_via_delete_button
Device sessions

22. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

23. test_fetch_more_history_in_empty_chat
Device sessions

24. test_mobile_data_usage_popup_continue_syncing
Device sessions

25. test_keycard_fetching_balance_after_offline
Device sessions

26. test_add_to_contacts
Device sessions

27. test_dapps_permissions
Device sessions

28. test_long_press_delete_clear_all_dapps
Device sessions

29. test_need_help_section
Device sessions

30. test_transaction_wrong_password_wallet
Device sessions

31. test_offline_messaging_1_1_chat
Device sessions

32. test_add_account_to_multiaccount_instance_private_key
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_install_pack_and_send_sticker
Device sessions

35. test_send_eth_in_1_1_chat
Device sessions

36. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

37. test_send_emoji
Device sessions

38. test_copy_and_paste_messages
Device sessions

39. test_keycard_send_eth_in_1_1_chat
Device sessions

40. test_restore_account_from_mnemonic_to_keycard
Device sessions

41. test_add_account_to_multiaccount_instance_generate_new
Device sessions

42. test_send_eth_from_wallet_to_address
Device sessions

43. test_messaging_in_different_networks
Device sessions

44. test_start_chat_with_ens
Device sessions

45. test_logcat_recovering_account
Device sessions

46. test_offline_add_new_group_chat_member
Device sessions

47. test_connection_is_secure
Device sessions

48. test_keycard_send_transaction_from_daap
Device sessions

49. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

50. test_send_eth_to_ens_in_chat
Device sessions

51. test_keycard_sign_message_from_daap
Device sessions

52. test_long_press_to_delete_chat
Device sessions

53. test_add_and_remove_contact_from_public_chat
Device sessions

54. test_send_transaction_from_daap
Device sessions

55. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

56. test_keycard_send_eth_from_wallet_to_address
Device sessions

57. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

58. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

59. test_open_blocked_site
Device sessions

60. test_refresh_button_browsing_app_webview
Device sessions

61. test_public_chat_messaging
Device sessions

62. test_pass_phrase_validation
Device sessions

63. test_send_token_with_7_decimals
Device sessions

64. test_sign_message_from_daap
Device sessions

65. test_recover_account_from_new_user_seedphrase
Device sessions

66. test_add_new_keycard_account_and_login
Device sessions

67. test_send_and_open_links
Device sessions

68. test_manage_assets
Device sessions

69. test_share_contact_code_and_wallet_address
Device sessions

70. test_send_transaction_with_custom_token
Device sessions

71. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

72. test_can_recover_keycard_account_card_pairing
Device sessions

73. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

74. test_redirect_to_public_chat_tapping_tag_message
Device sessions

75. test_block_user_from_public_chat
Device sessions

76. test_ens_in_public_and_1_1_chats
Device sessions

77. test_create_new_group_chat
Device sessions

78. test_password_in_logcat_sign_in
Device sessions

79. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

80. test_mobile_data_usage_popup_stop_syncing
Device sessions

81. test_send_non_english_message_to_newly_added_contact
Device sessions

82. test_collectible_from_wallet_opens_in_browser_view
Device sessions

83. test_contact_profile_view
Device sessions

84. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

85. test_switch_users_and_add_new_account
Device sessions

86. test_send_two_transactions_in_batch_in_dapp
Device sessions

87. test_filters_from_daap
Device sessions

88. test_login_with_new_account
Device sessions

89. test_home_view
Device sessions

90. test_log_level_and_fleet
Device sessions

91. test_can_add_existing_ens
Device sessions

92. test_copy_contact_code_and_wallet_address
Device sessions

93. test_can_see_all_transactions_in_history
Device sessions

@status-im-auto
Copy link
Member

67% of end-end tests have passed

Total executed tests: 3
Failed tests: 1
Passed tests: 2

Failed tests (1)

Click to expand
1. test_image_in_one_to_one_send_save_reply

Device 2: Looking for a message by text: 'image reply'
Device 2: Wait for ImageInReply

Image doesn't match expected template for sender Image doesn't match expected template for receiver

Device sessions

Passed tests (2)

Click to expand
1. test_push_notification_1_1_chat
Device sessions

2. test_decline_transactions_in_1_1_chat
Device sessions

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 6, 2020

ISSUE 1

If open chat (any type), open keyboard (set focus on the text input), send the app to the background, and open it again, the input field will be shifted upwards.

Only Android 8, 10

ezgif com-resize (12)

ISSUE 2

If open chat that contains a long message, open keyboard, send the app to the background, reopen it, and switch to sticker pad, then text input and sticker pad will be shifted upwards and overlaid on the chat history.

Only Android 8, 10

ezgif com-resize (13)

@Ferossgp
Copy link
Contributor Author

Ferossgp commented Aug 7, 2020

@qoqobolo

Issue 1 was always present as it is in the tabbar keyboard handling. If we want to fix it, I would do it as a separate task.

Can't replicate 2 on my device, but I pushed a commit that may fix it.

@churik
Copy link
Member

churik commented Aug 7, 2020 •
edited
Loading

@Ferossgp
according to issue 2: still can replicate it on my Xiaomi mi Note 9 (Android 10)
Will ask @Serhy to try on his devices as well.
My main concern that probably it may cause other issues like this, but if it is only me it will likely have lower prio.
@Serhy can you assist please?
@qoqobolo on your devices it is not reproducible, is it right?

@Serhy
Copy link
Contributor

Serhy commented Aug 7, 2020

I can't reproduce 2nd bug there on Android 8 (Samsung J7) and Android 9 (Galaxy S8).

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 7, 2020

@churik yes, currently can't reproduce issue 2. But now if I switch from keyboard to sticker pad while scrolling long message, sticker/image/command panel height changes, sometimes it's overlapped with main tabs.

Google Pixel 2, Android 10.

BAACAgQAAxkBAAEqDo1fLTNJXumiwIfk3n7bq6QhNzCrggACdAcAAo6vaVFMR8xOpLe0xhoE_1596797912 01

@Ferossgp
Copy link
Contributor Author

Ferossgp commented Aug 7, 2020

@qoqobolo what build id is in latests gif?

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 7, 2020

@Ferossgp it was nightly. My fault, sorry.

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 7, 2020 •
edited
Loading

@Ferossgp I checked issue in the latest gif a few more times, and eventually reproduced it both in build bc64eb3 and in nightly. It isn't reproducible every single time though.
Would it be better for you if I create a new separate issue for this case?

@weekly-digest weekly-digest bot mentioned this pull request Aug 9, 2020
Closed
@Serhy Serhy self-assigned this Aug 10, 2020
@Serhy
Copy link
Contributor

Serhy commented Aug 10, 2020

Since 2nd issue from #11033 (comment) is in develop we'll create a separate issue for it.
The #11031 has been fixed (can reproduce anymore in 1-1/Public/Group chats on Android 8/Android 9)

This one is ready for merge.

@Ferossgp
Fix chat text input animation lags
7bb7b48 
Remove picker panel from input

Clean pan state

Fixes #11031

Do not use pan state on android

iOs panel switching do not change height

Revert "Remove picker panel from input"

This reverts commit 0ab2c15.

Change reactions space keeper method

Audio

Do not use accessory view on Android

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
@Ferossgp Ferossgp merged commit 7bb7b48 into develop Aug 10, 2020
@Ferossgp Ferossgp deleted the fix-input-lags branch August 10, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@churik churik

@Ferossgp Ferossgp

@Serhy Serhy

@qoqobolo qoqobolo

Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ferossgp @status-im-auto @Serhy @qoqobolo @churik @flexsurfer