nix: add missing args to gcroots.sh script #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexsurfer
approved these changes
Aug 6, 2020
Jenkins Builds
|
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix-gcroots-args
branch
2 times, most recently
from
4aae856
to
2440c31
Compare
This should fix the following error showing up on MacOS: ``` error: assertion ((__lessThan 0) ((builtins).stringLength watchmanSockPath)) failed at /Users/jenkins/repos/status-react/nix/mobile/android/watchman.nix:8:9 ``` Which was caused by flags like `--argstr` not being passed. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix-gcroots-args
branch
from
2440c31
to
6872234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following error showing up on MacOS:
Which was caused by flags like
--argstrnot being passed.Also added
--console=plainfor Gradle call in Nix.