Add dinamically toggling webview debug on android #11053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (14)
|
Ferossgp
force-pushed
the
feature/webview-debug
branch
2 times, most recently
from
66167d1
to
3fe0fa1
Compare
|
could you please elaborate on what this PR about ? thanks |
|
@flexsurfer This should be a one time toggle (to not persist) to enable webview debug in android. This is intended for use of DAPP devs to debug their apps in status. cc @andremedeiros |
Ferossgp
force-pushed
the
feature/webview-debug
branch
from
3fe0fa1
to
2d9338f
Compare
Ferossgp
force-pushed
the
feature/webview-debug
branch
2 times, most recently
from
5f6cead
to
c55b6d2
Compare
Ferossgp
changed the title
corpetty
approved these changes
Sep 15, 2020
Ferossgp
force-pushed
the
feature/webview-debug
branch
2 times, most recently
from
ae33a88
to
ec4ffd6
Compare
93% of end-end tests have passedFailed tests (7)Click to expand
Passed tests (92)Click to expand
|
14% of end-end tests have passedFailed tests (6)Click to expand
Passed tests (1) |
67% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (4)Click to expand
|
|
That works on Android 8, Android 9 (real devices) with enabled debug mode. But, once I perform the action in desktop debugger (Chrome in my case) - Status becomes unresponsive and eventually ends up with 'Status is unresponsive. Wait more/Close app' logs in that case |
|
@Serhy I think that's ok for this case, as it still opens the ability for devs to debug apps in the Status |
Optimistic update Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
feature/webview-debug
branch
from
ec4ffd6
to
0368895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some "develop in the dark" issues that Dapp developers have been having.
Effectively, because they can't download the production version of our app and debug their dapps, they develop in the dark. This PR should allow them to temporarily turn debug mode on and attach a remote Chrome / Safari to the dapp browser to make sure they can develop using the tools they usually use.