Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Increase password check to 8 characters and add some basic weakness checks. #13150

Closed
wants to merge 1 commit into from

Conversation

dangarbri
Copy link

@dangarbri dangarbri commented Mar 6, 2022

Fixes #13137

Summary

Password limit should be increased to 8 characters and we should have some
checks to make sure users are not entering weak passwords.

In this PR, I've updated the minimum password length to 8 characters and added 2 weakness checks:

  • Make sure the password characters are not all repeated i.e. "aaaaaaaa" and "11111111" are not allowed
  • Make sure passwords are not sequential characters i.e. "abcdefgh" and "12345678" are not allowed

I've also created a password utility so that the onboarding screen and password reset screens can share
the same password validation code.

Testing notes

Tested on android by inputting passwords to test failing conditions.

  • entered 'aaaaaaaa'
  • entered '12345678'
  • entered other strings of characters

Platforms

  • Android
  • iOS

Areas that maybe impacted

  • Onboarding password creation
  • Password reset
Functional
  • new account
  • user profile updates

Steps to test

  • Clear status storage to simulate being a new user
  • Go through onboarding process and create a password, verify password meets minimum requirements mentioned in summary
  • Change password and verify password meets minimum requirements mentioned in summary.

status: Ready

@ghost
Copy link

ghost commented Mar 6, 2022

Hey @dangarbri, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-im-auto
Copy link
Member

status-im-auto commented Mar 6, 2022

Jenkins Builds

Click to see older builds (27)
Commit #️⃣ Finished (UTC) Duration Platform Result
318cd9e #1 2022-03-06 17:10:00 ~1 min android 📄log
318cd9e #1 2022-03-06 17:10:00 ~1 min android-e2e 📄log
318cd9e #1 2022-03-06 17:10:29 ~1 min ios 📄log
✖️ f627346 #2 2022-03-06 19:40:28 ~7 min android-e2e 📦apk 📲
✖️ f627346 #2 2022-03-06 19:40:34 ~7 min android 📦apk 📲
✖️ f627346 #2 2022-03-06 19:45:10 ~11 min ios 📦ipa 📲
✖️ 73b10ce #3 2022-03-07 21:36:24 ~6 min android 📦apk 📲
✖️ 73b10ce #3 2022-03-07 21:39:26 ~9 min ios 📦ipa 📲
✖️ 73b10ce #3 2022-03-07 21:41:50 ~12 min android-e2e 📦apk 📲
✔️ 7bc5843 #4 2022-03-08 02:34:32 ~6 min android-e2e 📦apk 📲
✔️ 7bc5843 #4 2022-03-08 02:34:50 ~7 min android 📦apk 📲
✔️ 7bc5843 #4 2022-03-08 02:38:49 ~11 min ios 📦ipa 📲
✔️ 18dae95 #5 2022-03-08 04:05:41 ~7 min android 📦apk 📲
✔️ 18dae95 #5 2022-03-08 04:05:53 ~7 min android-e2e 📦apk 📲
✔️ 18dae95 #5 2022-03-08 04:09:09 ~10 min ios 📦ipa 📲
✔️ ad597a9 #6 2022-03-18 17:22:19 ~7 min android-e2e 📦apk 📲
✔️ ad597a9 #6 2022-03-18 17:22:30 ~7 min android 📦apk 📲
✔️ ad597a9 #6 2022-03-18 17:27:49 ~12 min ios 📦ipa 📲
✔️ 22db84a #7 2022-03-26 17:11:02 ~9 min android 📦apk 📲
✔️ 22db84a #7 2022-03-26 17:11:17 ~10 min android-e2e 📦apk 📲
✔️ 22db84a #7 2022-03-26 17:15:56 ~14 min ios 📦ipa 📲
✔️ 2cd00d1 #8 2022-03-26 17:13:39 ~10 min android-e2e 📦apk 📲
✔️ 2cd00d1 #8 2022-03-26 17:14:03 ~10 min android 📦apk 📲
✔️ 2cd00d1 #8 2022-03-26 17:20:24 ~16 min ios 📦ipa 📲
✔️ d319186 #9 2022-03-26 17:20:09 ~15 min android-e2e 📦apk 📲
✔️ d319186 #9 2022-03-26 17:20:24 ~16 min ios 📦ipa 📲
✔️ d319186 #9 2022-03-26 17:20:51 ~16 min android 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a184b9c #10 2022-04-10 23:36:06 ~10 min android 📦apk 📲
✔️ a184b9c #10 2022-04-10 23:36:14 ~10 min android-e2e 📦apk 📲
✔️ a184b9c #10 2022-04-10 23:40:54 ~15 min ios 📦ipa 📲
✔️ 855da78 #11 2022-04-10 23:37:59 ~11 min android 📦apk 📲
✔️ 855da78 #11 2022-04-10 23:38:07 ~11 min android-e2e 📦apk 📲
✔️ 855da78 #11 2022-04-10 23:39:38 ~13 min ios 📦ipa 📲

@dangarbri
Copy link
Author

How do I properly create a namespace? I'm getting this error:

The required namespace "status-im.utils.password-resources" is not available, it was required by "status_im/ui/screens/onboarding/password/views.cljs".

I have (ns status-im.utils.password-resources) in my password_utils.cljs file.

@dangarbri
Copy link
Author

My all-same function is failing by saying the password is not ISeqable, it should just be a string though, right?

@dangarbri
Copy link
Author

Found the build documentation and was able to fix my issue. Tested on android.

@du82
Copy link
Contributor

du82 commented Mar 8, 2022

The word "phenomenon" fits the requirements that you've listed, but it won't let me create an account. Adding a unicode character (Chinese, Emoji, Symbols) to the end doesn't allow me to create the account either.

Screenshot_20220307-193257_Status PR
Screenshot_20220307-193348_Status PR

@dangarbri
Copy link
Author

Shoot, let me check on that

@dangarbri
Copy link
Author

@ducheng0 thanks for catching that, I must have tested without my latest changes, my mistake.
The problem was with my is-sequential function, clojurescript doesn't cast to int like regular clojure, I had to change my character -> number function to use charCodeAt.

It's working now.
Screenshot_20220307-224926

@du82
Copy link
Contributor

du82 commented Mar 9, 2022

looks good to me!

Copy link
Contributor

@cammellos cammellos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks @dangarbri .
I will approve you to work on the bounty on gitcoin and as soon as it's tested ok I will release the bounty.
Thanks again!

@qoqobolo
Copy link
Contributor

Hello @dangarbri, thank you for the contribution!
Could you rebase your PR against the latest develop, please?
After that, PR will be tested. Thanks!

@dangarbri
Copy link
Author

@qoqobolo @cammellos Rebased, thanks!

@status-im-auto
Copy link
Member

44% of end-end tests have passed

Total executed tests: 52
Failed tests: 29
Passed tests: 23
IDs of failed tests: 5502,5762,5783,6305,6279,6315,6253,700747,5315,6645,695843,5310,5373,5786,6283,5782,5332,6316,700746,5304,6646,6263,5689,6228,5387,5317,6226,6265,5403 

Failed tests (29)

Click to expand
  • Rerun tests

  • 1. test_can_add_existing_ens_on_mainnet, id: 5502

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 3: Set 'qwerty' value for 'EditBox'
    Device 3: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    3. test_can_use_purchased_stickers_on_recovered_account, id: 5783

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    4. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    6. test_reactions_to_message_in_chats, id: 6315

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    7. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    8. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Logging out
    Device 1: Scrolling down to LogoutButton

    Device 1: LogoutButton by accessibility id: `log-out-button` is not found on the screen

    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    10. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    11. test_edit_delete_message_in_one_to_one_, id: 695843

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    12. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    13. test_send_and_open_emoji_link_in_one_to_one, id: 5373

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    14. test_block_user_from_public_chat, id: 5786

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    15. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    16. test_install_pack_and_send_sticker, id: 5782

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    17. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    18. test_send_audio_message_with_push_notification_check, id: 6316

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    19. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: Button by xpath:`//*[@text="Wrong password"]` is not found on the screen

    Device sessions

    20. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    21. test_set_profile_picture, id: 6646

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    22. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    23. test_keycard_create_account_unlock_same_seed, id: 5689

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    24. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    25. test_delete_chats_via_delete_button_rejoin, id: 5387

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    26. test_copy_and_paste_messages, id: 5317

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    27. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    28. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    Passed tests (23)

    Click to expand

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_public_chat_open_using_deep_link, id: 700739
    3. test_browser_bookmarks_create_edit_remove, id: 702077
    4. test_restore_validation_seed_phrase_field, id: 700750
    Device sessions

    5. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    6. test_browser_blocked_url, id: 702072
    7. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    8. test_onboarding_share_contact_address, id: 700743
    Device sessions

    9. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    10. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    11. test_browser_delete_close_tabs, id: 702076
    12. test_browser_connection_is_secure_not_secure_warning, id: 702073
    13. test_browser_web3_permissions_testdapp, id: 702078
    14. test_public_chat_tag_message, id: 700738
    15. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    16. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    17. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    18. test_keycard_send_tx_eth, id: 700767
    Device sessions

    19. test_browser_offline, id: 702075
    20. test_browser_invalid_url, id: 702074
    21. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    22. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    23. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    @status-im-auto
    Copy link
    Member

    44% of end-end tests have passed

    Total executed tests: 52
    Failed tests: 29
    Passed tests: 23
    
    IDs of failed tests: 5502,5762,5783,6305,6279,6315,6253,700747,5315,6645,695843,5310,5373,5786,6283,5782,5332,6316,700746,5304,6646,6263,5689,6228,5387,5317,6226,6265,5403 
    

    Failed tests (29)

    Click to expand
  • Rerun tests

  • 1. test_can_add_existing_ens_on_mainnet, id: 5502

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 3: Set 'qwerty' value for 'EditBox'
    Device 3: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    3. test_can_use_purchased_stickers_on_recovered_account, id: 5783

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    4. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    6. test_reactions_to_message_in_chats, id: 6315

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    7. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    8. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Logging out
    Device 1: Scrolling down to LogoutButton

    Device 1: LogoutButton by accessibility id: `log-out-button` is not found on the screen

    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    10. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    11. test_edit_delete_message_in_one_to_one_, id: 695843

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    12. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    13. test_send_and_open_emoji_link_in_one_to_one, id: 5373

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    14. test_block_user_from_public_chat, id: 5786

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    15. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    16. test_install_pack_and_send_sticker, id: 5782

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    17. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    18. test_send_audio_message_with_push_notification_check, id: 6316

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    19. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Device 1: Find 'SignInButton' by 'xpath': `//*[@text="Sign in"]`
    Device 1: Tap on found: SignInButton

    Device 1: Button by xpath:`//*[@text="Wrong password"]` is not found on the screen

    Device sessions

    20. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    21. test_set_profile_picture, id: 6646

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    22. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    23. test_keycard_create_account_unlock_same_seed, id: 5689

    Device 1: Click until 'AccessKeyButton' by 'xpath': `//*[@text="Access existing keys"]` will be presented
    Device 1: Find 'Button' by 'xpath': `//*[@text="Get started"]`

    504 Gateway Time-out

    The server didn't respond in time.


    Device sessions

    24. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    25. test_delete_chats_via_delete_button_rejoin, id: 5387

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    26. test_copy_and_paste_messages, id: 5317

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    27. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    28. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Set 'qwerty' value for 'EditBox'
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to 'qwerty'. Did you interact with the correct element?

    Device sessions

    Passed tests (23)

    Click to expand

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_public_chat_open_using_deep_link, id: 700739
    3. test_browser_bookmarks_create_edit_remove, id: 702077
    4. test_restore_validation_seed_phrase_field, id: 700750
    Device sessions

    5. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    6. test_browser_blocked_url, id: 702072
    7. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    8. test_onboarding_share_contact_address, id: 700743
    Device sessions

    9. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    10. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    11. test_browser_delete_close_tabs, id: 702076
    12. test_browser_connection_is_secure_not_secure_warning, id: 702073
    13. test_browser_web3_permissions_testdapp, id: 702078
    14. test_public_chat_tag_message, id: 700738
    15. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    16. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    17. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    18. test_keycard_send_tx_eth, id: 700767
    Device sessions

    19. test_browser_offline, id: 702075
    20. test_browser_invalid_url, id: 702074
    21. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    22. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    23. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    @dangarbri
    Copy link
    Author

    Ah, the test is failing because it can't find the 2nd password input.
    It types 'qwerty' into the first one and expects the 2nd input to become available. But it doesn't because it doesn't meet the new minimum requirements.

    @dangarbri dangarbri requested a review from churik as a code owner March 26, 2022 17:03
    @pavloburykh
    Copy link
    Contributor

    Ah, the test is failing because it can't find the 2nd password input. It types 'qwerty' into the first one and expects the 2nd input to become available. But it doesn't because it doesn't meet the new minimum requirements.

    yeah, this is known issue. we will update test data and then re-run failed tests.

    @dangarbri
    Copy link
    Author

    I updated where I think it was getting qwerty from to qwerty1234. If that's the right place to update it then this should work now.

    @status-im-auto
    Copy link
    Member

    86% of end-end tests have passed

    Total executed tests: 79
    Failed tests: 11
    Passed tests: 68
    
    IDs of failed tests: 5762,6305,700747,5310,6270,6263,6228,5387,5675,700737,700759 
    

    Failed tests (11)

    Click to expand
  • Rerun tests

  • 1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    2. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find `AllowButton` by `xpath`: `//*[@text="Allow" or @text="ALLOW"]`
    Device 2: Find `Button` by `xpath`: `//*[@content-desc='open-gallery']/following-sibling::android.view.ViewGroup[1]`

    Status of another user not shown when open another user profile Status of another user not shown when open another user profile

    Device sessions

    3. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `123456` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '123456'. Did you interact with the correct element?

    Device sessions

    4. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Worthwhile Shadowy Urson'
    Device 1: Wait for element `Button` for max 120s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    5. test_public_chat_mark_all_messages_as_read, id: 6270

    Device 1: Looking for chat: '#ynohvjj'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    6. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.000267186
    {'blockNumber': '12135565', 'timeStamp': '1648288279', 'hash': '0x7eaa7e417fd81e61612caca39b7b1c8323903daf685e8fe68c54ec5a7d0a175d', 'nonce': '77', 'blockHash': '0xbbd4aec1b2611e88d83f1d92d7d88d053c8b2c130c82f55ac3c9107b4217bd52', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x171cbd64edeceb39237b066e806b1302ddb9234e', 'value': '267186000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '71', 'gas': '141014', 'gasPrice': '1881799832', 'gasUsed': '117512', 'cumulativeGasUsed': '6055782', 'input': 'deprecated', 'confirmations': '7595'}

    Transaction with amount 0.0002814435 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    7. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    8. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:odfbcxbogw

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    9. test_public_chat_fetch_more_history, id: 5675

    ## Public chat 'hosylel' is created successfully!
    # STEP: Check that can fetch previous history for several days

    Device 1: "Mar 27, 2022" is not shown

    Device sessions

    10. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Device 1: Looking for chat: '#ynohvjj'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    11. test_wallet_add_account_generate_new, id: 700759

    Device 1: Find `Button` by `accessibility id`: `add-account-add-account-button`
    Device 1: Tap on found: Button

    Device 1: Incorrect password validation is not performed

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_wallet_manage_assets, id: 700758
    Device sessions

    3. test_public_chat_message_edit, id: 700734
    Device sessions

    4. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    5. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    6. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    7. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    8. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    9. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    10. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    11. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    12. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    13. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    14. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    15. test_restore_validation_seed_phrase_field, id: 700750
    Device sessions

    16. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    17. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    18. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    19. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    20. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    21. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    22. test_browser_blocked_url, id: 702072
    Device sessions

    23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    24. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    25. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    26. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    27. test_block_user_from_public_chat, id: 5786
    Device sessions

    28. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    29. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    30. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    31. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    32. test_public_chat_link_send_open, id: 700736
    Device sessions

    33. test_onboarding_share_contact_address, id: 700743
    Device sessions

    34. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    35. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    36. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    37. test_browser_delete_close_tabs, id: 702076
    Device sessions

    38. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    39. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    40. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    41. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    42. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    43. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    44. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    47. test_group_chat_decline_invite_chat_highligted, id: 5756
    Device sessions

    48. test_set_profile_picture, id: 6646
    Device sessions

    49. test_public_chat_tag_message, id: 700738
    Device sessions

    50. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    51. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    52. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    53. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    54. test_group_chat_offline_pn, id: 3998
    Device sessions

    55. test_group_chat_add_new_member_activity_centre, id: 700732
    Device sessions

    56. test_keycard_send_tx_eth, id: 700767
    Device sessions

    57. test_browser_offline, id: 702075
    Device sessions

    58. test_browser_invalid_url, id: 702074
    Device sessions

    59. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    60. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    61. test_copy_and_paste_messages, id: 5317
    Device sessions

    62. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    63. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    64. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    65. test_group_chat_leave_relogin, id: 3997
    Device sessions

    66. test_public_chat_message_delete, id: 700735
    Device sessions

    67. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    68. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @dangarbri Thanx for your contribution! Please, take a look at following issue.

    ISSUE 1 Unable to login into account after app upgrade if initial account password does not meet new validation rules

    Steps:

    1. Install any other PR build in order to have possibility to set 6 char password . For instance, you can use this build for Android https://status-im-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Mobile-220324-045209-8529e1-pr13185-universal.apk
    2. Create an account and set 6 char password
    3. Upgrade to current PR build
    4. Try to login the account using existing 6 char password

    Actual result: Sign in button is disabled.

    Expected result: user with old passwords (< 8 char, no basic weakness validation) should be able to Sign in their accounts.
    photo_2022-03-28 19 18 09

    @dangarbri
    Copy link
    Author

    Mmmm, good catch. I'll work on that.

    @status-im-auto
    Copy link
    Member

    18% of end-end tests have passed

    Total executed tests: 11
    Failed tests: 9
    Passed tests: 2
    
    IDs of failed tests: 5762,6305,700747,5310,6263,6228,5387,5675,700759 
    

    Failed tests (9)

    Click to expand
  • Rerun tests

  • 1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    2. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find `AllowButton` by `xpath`: `//*[@text="Allow" or @text="ALLOW"]`
    Device 2: Find `Button` by `xpath`: `//*[@content-desc='open-gallery']/following-sibling::android.view.ViewGroup[1]`

    Status of another user not shown when open another user profile Status of another user not shown when open another user profile

    Device sessions

    3. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `123456` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '123456'. Did you interact with the correct element?

    Device sessions

    4. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Cool Those Kestrel'
    Device 1: Wait for element `Button` for max 120s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    5. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.000276484
    {'blockNumber': '12138604', 'timeStamp': '1648364273', 'hash': '0x7d267dd7e36038676b9582ab9715fd812148859a77e976a988dc60127635d1fd', 'nonce': '78', 'blockHash': '0x07e6d6357dc352b163757549a03432e3f13ba94959b5cf12ec4de37ee0d1dae1', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0xd4ec4db9e0623b3707360dfde2737eb35eb34fac', 'value': '276484000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '2', 'gas': '141014', 'gasPrice': '2500000102', 'gasUsed': '117512', 'cumulativeGasUsed': '234606', 'input': 'deprecated', 'confirmations': '4773'}

    Transaction with amount 0.0002816261 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    6. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    7. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:togguxyqps

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    8. test_public_chat_fetch_more_history, id: 5675

    ## Public chat 'agfgtya' is created successfully!
    # STEP: Check that can fetch previous history for several days

    Device 1: "Mar 27, 2022" is not shown

    Device sessions

    9. test_wallet_add_account_generate_new, id: 700759

    Device 1: Find `Button` by `accessibility id`: `add-account-add-account-button`
    Device 1: Tap on found: Button

    Device 1: Incorrect password validation is not performed

    Device sessions

    Passed tests (2)

    Click to expand

    1. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    2. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    ISSUE 2 No validation error is shown to user when he tries to reset password to value that does not meet basic weakness checks (e.g. "aaaaaaaa", "12345678", "abcdefghi" etc)

    Steps:

    1. Open Status App
    2. Sign in / Sign up an account
    3. Go to Profile - Privacy and security - Reset password
    4. Fill in Current password values
    5. Fill in new password and confirm new password field with invalid values that does not meet basic weakness checks ("aaaaaaaa", "12345678", "abcdefghi" etc)
    6. Pay attention if there are any validation errors

    Actual result: no validation errors are shown that could provide user with info why he is unable to proceed with password reset. The text below password fields do not contain any info about basic weakness reqs, only about minimum 8 chars and type of chars (unicode/emoji).
    photo_2022-03-29 12 31 44
    photo_2022-03-29 12 31 53

    Expected result: user must be shown validation error just like he is shown during initial password set.

    @status-im-auto
    Copy link
    Member

    11% of end-end tests have passed

    Total executed tests: 9
    Failed tests: 8
    Passed tests: 1
    
    IDs of failed tests: 5762,6305,700747,6263,5310,6228,5387,5675 
    

    Failed tests (8)

    Click to expand
  • Rerun tests

  • 1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    2. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find `AllowButton` by `xpath`: `//*[@text="Allow" or @text="ALLOW"]`
    Device 2: Find `Button` by `xpath`: `//*[@content-desc='open-gallery']/following-sibling::android.view.ViewGroup[1]`

    Status of another user not shown when open another user profile Status of another user not shown when open another user profile

    Device sessions

    3. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `123456` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '123456'. Did you interact with the correct element?

    Device sessions

    4. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.00028124428
    {'blockNumber': '12142887', 'timeStamp': '1648471967', 'hash': '0x359d6356dbe7a7b70fc73478bdd69a653c5e2e490fdde8086fb85f1d8f2ed41e', 'nonce': '81', 'blockHash': '0xacb79e632c9aebd661d989f07d8c900546e759392445d4f2c75d0afbeea452d5', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x7d3394318b4ac757a2f3f5bb4be7a79e33babbc3', 'value': '281244280000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '24', 'gas': '141014', 'gasPrice': '2213918922', 'gasUsed': '117512', 'cumulativeGasUsed': '4901818', 'input': 'deprecated', 'confirmations': '3205'}

    Transaction with amount 0.0002913843 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    5. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Early Jampacked Hadrosaurus'
    Device 1: Wait for element `Button` for max 120s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    6. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    7. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:qwsbgllwca

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    8. test_public_chat_fetch_more_history, id: 5675

    ## Public chat 'qovpylo' is created successfully!
    # STEP: Check that can fetch previous history for several days

    Device 1: "Mar 28, 2022" is not shown

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    @status-im-auto
    Copy link
    Member

    75% of end-end tests have passed

    Total executed tests: 8
    Failed tests: 2
    Passed tests: 6
    
    IDs of failed tests: 700747,6263 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `123456` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '123456'. Did you interact with the correct element?

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.0002821837
    {'blockNumber': '12144159', 'timeStamp': '1648505838', 'hash': '0x2907c6e05b7f1c70f437b609d755d75d2061896d0dbecd8ec48cbeb3888515f0', 'nonce': '84', 'blockHash': '0xa48f0fbe720e506f2b66f8b74be5f64d3eb351ce5d0acae716868657880ad0e7', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0xf28589669eccc2ee943858166b6a6dee3d5802ec', 'value': '282183700000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '7', 'gas': '141014', 'gasPrice': '2964499730', 'gasUsed': '117512', 'cumulativeGasUsed': '6987593', 'input': 'deprecated', 'confirmations': '4605'}

    Transaction with amount 0.000308378 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    Passed tests (6)

    Click to expand

    1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    2. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    3. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    4. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    5. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    6. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 2
    Failed tests: 2
    Passed tests: 0
    
    IDs of failed tests: 700747,6263 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `12345678` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '12345678'. Did you interact with the correct element?

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.00029725
    {'blockNumber': '12145393', 'timeStamp': '1648541028', 'hash': '0x096169ab8d2c45d989dbf8d59ecca26ce0084bc74a4a13c73f037720e2ab4e89', 'nonce': '85', 'blockHash': '0xdf5a46d3e143b3a92faa6a57f4e0e322e75a8071a2d6b7216b7bb1682412b97a', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x3d27029c08ace54799fbcade5ce1a42bd54469f0', 'value': '297250000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '52', 'gas': '141028', 'gasPrice': '2500000025', 'gasUsed': '117524', 'cumulativeGasUsed': '7757621', 'input': 'deprecated', 'confirmations': '3613'}

    Transaction with amount 0.00030102738 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 2
    Failed tests: 2
    Passed tests: 0
    
    IDs of failed tests: 700747,6263 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `12345678` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '12345678'. Did you interact with the correct element?

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.00029725
    {'blockNumber': '12145393', 'timeStamp': '1648541028', 'hash': '0x096169ab8d2c45d989dbf8d59ecca26ce0084bc74a4a13c73f037720e2ab4e89', 'nonce': '85', 'blockHash': '0xdf5a46d3e143b3a92faa6a57f4e0e322e75a8071a2d6b7216b7bb1682412b97a', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x3d27029c08ace54799fbcade5ce1a42bd54469f0', 'value': '297250000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '52', 'gas': '141028', 'gasPrice': '2500000025', 'gasUsed': '117524', 'cumulativeGasUsed': '7757621', 'input': 'deprecated', 'confirmations': '3667'}

    Transaction with amount 0.0003011324 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 2
    Failed tests: 2
    Passed tests: 0
    
    IDs of failed tests: 700747,6263 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Device 1: Type `1234566` to `EditBox`
    Device 1: Find `EditBox` by `xpath`: `(//android.widget.EditText[@content-desc='password-input'])[2]`

    Cannot set the element to '1234566'. Did you interact with the correct element?

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.00029725
    {'blockNumber': '12145393', 'timeStamp': '1648541028', 'hash': '0x096169ab8d2c45d989dbf8d59ecca26ce0084bc74a4a13c73f037720e2ab4e89', 'nonce': '85', 'blockHash': '0xdf5a46d3e143b3a92faa6a57f4e0e322e75a8071a2d6b7216b7bb1682412b97a', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x3d27029c08ace54799fbcade5ce1a42bd54469f0', 'value': '297250000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '52', 'gas': '141028', 'gasPrice': '2500000025', 'gasUsed': '117524', 'cumulativeGasUsed': '7757621', 'input': 'deprecated', 'confirmations': '3900'}

    Transaction with amount 0.0003012313 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 2
    Failed tests: 1
    Passed tests: 1
    
    IDs of failed tests: 6263 
    

    Failed tests (1)

    Click to expand
  • Rerun tests

  • 1. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Transaction #5, amount is 0.0002913843
    {'blockNumber': '12146128', 'timeStamp': '1648560994', 'hash': '0x00143306b963d839f840a2e06cbb4283d771376640e003dc37d8f8e6585bb608', 'nonce': '86', 'blockHash': '0x00b0e332101581a2226e1ff8aea76fafb5bccb50ab6ea161645ec339d5e11438', 'from': '0xe67685fe27e269799c00c9e3474804bc65ac0208', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0x25ff4fd10316d71124197eaa2b2ff9dadd19a2d1', 'value': '291384300000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '13', 'gas': '141028', 'gasPrice': '9505933069', 'gasUsed': '117524', 'cumulativeGasUsed': '1303375', 'input': 'deprecated', 'confirmations': '3224'}

    Transaction with amount 0.0003012562 is not found in list of token transactions, address is E67685fE27E269799C00C9e3474804BC65ac0208 during 300s

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    Fix problem where signing in requires 8 chars
    
    Add description that emojis are supported.
    
    Update minimum password length for reset password popup
    
    add password utility
    
    Update onboarding and reset password views to share password checking code
    
    Update to support masked data
    Add error when password validation fails
    
    Formatting fix
    Fix is-sequential? function
    @dangarbri dangarbri changed the title Increase password check to 8 characters and add some basic weakness checks. [WIP] Increase password check to 8 characters and add some basic weakness checks. Apr 10, 2022
    @dangarbri
    Copy link
    Author

    Issue 1 resolved, still working on issue 2.

    @status-im-auto
    Copy link
    Member

    97% of end-end tests have passed

    Total executed tests: 79
    Failed tests: 2
    Passed tests: 77
    
    IDs of failed tests: 6270,700737 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_public_chat_mark_all_messages_as_read, id: 6270

    Device 1: Looking for chat: '#bybksdy'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    2. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Device 1: Looking for chat: '#bybksdy'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    Passed tests (77)

    Click to expand

    1. test_install_pack_and_send_sticker (TestRail link is not found)
    Device sessions

    2. test_public_chat_message_edit, id: 700734
    Device sessions

    3. test_public_chat_tag_message, id: 700738
    Device sessions

    4. test_browser_offline, id: 702075
    Device sessions

    5. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    6. test_mobile_data_usage_complex_settings (TestRail link is not found)
    Device sessions

    7. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    8. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    9. test_start_chat_with_ens_mention_in_one_to_one (TestRail link is not found)
    Device sessions

    10. test_can_use_purchased_stickers_on_recovered_account (TestRail link is not found)
    Device sessions

    11. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    12. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    13. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    14. test_set_profile_picture (TestRail link is not found)
    Device sessions

    15. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    16. test_request_and_receive_stt_in_1_1_chat_offline (TestRail link is not found)
    Device sessions

    17. test_decline_transactions_in_1_1_chat_push_notification_changing_state (TestRail link is not found)
    Device sessions

    18. test_public_chat_message_delete, id: 700735
    Device sessions

    19. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    20. test_send_eth_to_ens_in_chat (TestRail link is not found)
    Device sessions

    21. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    22. test_keycard_send_tx_eth, id: 700767
    Device sessions

    23. test_browser_blocked_url, id: 702072
    Device sessions

    24. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    25. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    26. test_group_chat_decline_invite_chat_highligted, id: 5756
    Device sessions

    27. test_onboarding_share_contact_address, id: 700743
    Device sessions

    28. test_group_chat_offline_pn, id: 3998
    Device sessions

    29. test_browser_invalid_url, id: 702074
    Device sessions

    30. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    31. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    32. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    33. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    34. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    35. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    36. test_add_and_remove_mention_contact_with_nickname_from_public_chat (TestRail link is not found)
    Device sessions

    37. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    38. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    39. test_copy_and_paste_messages, id: 5317
    Device sessions

    40. test_restore_account_migrate_multiaccount_to_keycard (TestRail link is not found)
    Device sessions

    41. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    42. test_group_chat_leave_relogin, id: 3997
    Device sessions

    43. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    44. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    45. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    46. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    47. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    48. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    49. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    50. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    51. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases (TestRail link is not found)
    Device sessions

    52. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    53. test_restore_validation_seed_phrase_field, id: 700750
    Device sessions

    54. test_block_user_from_public_chat (TestRail link is not found)
    Device sessions

    55. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    56. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    57. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    58. test_group_chat_add_new_member_activity_centre, id: 700732
    Device sessions

    59. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    60. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat (TestRail link is not found)
    Device sessions

    62. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    63. test_public_chat_link_send_open, id: 700736
    Device sessions

    64. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    65. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    66. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    67. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    68. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    69. test_browser_delete_close_tabs, id: 702076
    Device sessions

    70. test_can_add_existing_ens_on_mainnet (TestRail link is not found)
    Device sessions

    71. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    72. test_wallet_manage_assets, id: 700758
    Device sessions

    73. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    74. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats (TestRail link is not found)
    Device sessions

    75. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    76. test_send_eth_in_1_1_chat_transaction_push (TestRail link is not found)
    Device sessions

    77. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    @flexsurfer
    Copy link
    Member

    hey @dangarbri are you still working on this issue ?

    @dangarbri
    Copy link
    Author

    dangarbri commented May 3, 2022 via email

    @flexsurfer flexsurfer closed this Jun 1, 2022
    @flexsurfer
    Copy link
    Member

    feel free to reopen if needed

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Increase password requirement
    7 participants