Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search input animation with nativeDriver #8464

Merged
merged 1 commit into from
Jun 25, 2019
Merged

search input animation with nativeDriver #8464

merged 1 commit into from
Jun 25, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jun 21, 2019 •
edited by StatusWrike
Loading

Old version (0.2 speed)

New version (0.2 speed)

status: ready

@rasom rasom requested a review from a team as a code owner June 21, 2019 18:58
@auto-assign auto-assign bot removed the request for review from a team June 21, 2019 18:58
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom changed the title search input animation with nativeDriver [WIP] search input animation with nativeDriver Jun 21, 2019
@rasom rasom self-assigned this Jun 21, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 21, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8222008 #1 2019-06-21 19:10:04 ~11 min android-e2e 📦 apk
✔️ 8222008 #1 2019-06-21 19:11:51 ~13 min ios 📦 ipa
✔️ 8222008 #1 2019-06-21 19:12:12 ~13 min android 📦 apk
✔️ 8222008 #1 2019-06-21 19:12:47 ~14 min macos 📦 dmg
✔️ 8222008 #1 2019-06-21 19:17:51 ~19 min linux 📦 App
✔️ 8222008 #1 2019-06-21 19:19:17 ~20 min windows 📦 exe
✔️ 7524f1d #2 2019-06-25 09:46:04 ~10 min linux 📦 App
✔️ 7524f1d #2 2019-06-25 09:48:37 ~13 min ios 📦 ipa
✔️ 7524f1d #2 2019-06-25 09:49:09 ~13 min android 📦 apk
✔️ 7524f1d #2 2019-06-25 09:49:38 ~14 min android-e2e 📦 apk
✔️ 7524f1d #2 2019-06-25 09:49:41 ~14 min macos 📦 dmg
✔️ 7524f1d #2 2019-06-25 09:53:17 ~17 min windows 📦 exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9fa2053 #3 2019-06-25 10:53:43 ~12 min ios 📦 ipa
✔️ 9fa2053 #3 2019-06-25 10:55:19 ~13 min macos 📦 dmg
✔️ 9fa2053 #3 2019-06-25 10:56:37 ~15 min linux 📦 App
✔️ 9fa2053 #3 2019-06-25 10:57:30 ~16 min android 📦 apk
✔️ 9fa2053 #3 2019-06-25 11:00:14 ~18 min android-e2e 📦 apk
✔️ 9fa2053 #3 2019-06-25 11:04:04 ~22 min windows 📦 exe
✔️ cd968cc #4 2019-06-25 12:25:21 ~12 min ios 📦 ipa
✔️ cd968cc #4 2019-06-25 12:25:24 ~12 min android-e2e 📦 apk
✔️ cd968cc #4 2019-06-25 12:26:08 ~13 min android 📦 apk
✔️ cd968cc #4 2019-06-25 12:26:40 ~14 min macos 📦 dmg
✔️ cd968cc #4 2019-06-25 12:27:56 ~15 min linux 📦 App
✔️ cd968cc #4 2019-06-25 12:28:43 ~16 min windows 📦 exe

@rasom rasom requested review from flexsurfer, yenda, vitvly and mandrigin and removed request for flexsurfer June 21, 2019 19:15
@rasom rasom changed the title [WIP] search input animation with nativeDriver search input animation with nativeDriver Jun 21, 2019
@statustestbot
Copy link

62% of end-end tests have passed

Total executed tests: 47
Failed tests: 18
Passed tests: 29

Failed tests (18)

Click to expand
1. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

2. test_open_transaction_on_etherscan

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

3. test_add_to_contacts

Device 2: Tap on CrossIcon
Device 2: Tap on EditButton

Device 2: 'EditPictureButton' is not found on the screen

Device sessions

4. test_logcat_send_transaction_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

5. test_send_token_with_7_decimals

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

6. test_send_eth_from_wallet_to_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

7. test_manage_assets

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

8. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

9. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

10. test_send_tokens_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

11. test_network_mismatch_for_send_request_commands

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

12. test_send_stt_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

13. test_send_eth_from_wallet_to_contact

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

14. test_offline_status

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'home_button'

Device sessions

15. test_user_can_remove_profile_picture

Device 1: Wait for ShareMyProfileButton
Device 1: Tap on EditButton

Device 1: 'EditPictureButton' is not found on the screen

Device sessions

16. test_share_contact_code_and_wallet_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

17. test_request_eth_in_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

18. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

Passed tests (29)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_long_press_to_delete_public_chat
Device sessions

15. test_send_emoji
Device sessions

16. test_search_chat_on_home
Device sessions

17. test_logcat_recovering_account
Device sessions

18. test_messaging_in_different_networks
Device sessions

19. test_logcat_sign_message_from_daap
Device sessions

20. test_switch_users_and_add_new_account
Device sessions

21. test_login_with_new_account
Device sessions

22. test_add_contact_from_public_chat
Device sessions

23. test_send_two_transactions_one_after_another_in_dapp
Device sessions

24. test_password_in_logcat_creating_account
Device sessions

25. test_backup_recovery_phrase
Device sessions

26. test_open_google_com_via_open_dapp
Device sessions

27. test_unread_messages_counter_public_chat
Device sessions

28. test_sign_message_from_daap
Device sessions

29. test_refresh_button_browsing_app_webview
Device sessions

@weekly-digest weekly-digest bot mentioned this pull request Jun 23, 2019
Closed
@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 49
Failed tests: 2
Passed tests: 47

Failed tests (2)

Click to expand
1. test_manage_assets

Device 1: Wait for AccountsMoreOptions
Device 1: Wait for AccountsMoreOptions

Device 1: 'AccountsMoreOptions' is not found on the screen

Device sessions

2. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for AccountsMoreOptions
Device 1: Wait for BackupRecoveryPhraseWarningText

'Back up your seed phrase' warning is not shown on Wallet

Device sessions

Passed tests (47)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_long_press_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

@Serhy Serhy self-assigned this Jun 24, 2019
@Serhy
Copy link
Contributor

Serhy commented Jun 25, 2019

@rasom, there are two regressions which are not present in develop.

Issue 1
The search input is shown on Chats screen when no chats on 'Chats' view.

  1. Open Status
  2. Create new account
  3. Once you end up on Chats view check whether Search input is present
    Actual result: Search input is present on screen
    Expected result: No search input on Chats view
  4. Join any public chat and delete this public chat so no chats on Chats view
    Actual result: Search input is present on screen
    Expected result: No search input on Chats view

Screenshot 2019-06-25 at 11 01 31

Issue 2 [Android only]
Search input does not appear if to open Status from background state while on background it was put by device 'Back' button:

  1. Open Status and create new account
  2. Join any public chat
  3. Navigate to 'Chats' view
  4. Pull down the screen so the Search input appears
  5. Put the cursor in Search input
  6. Tap Android device Back button twice (the first tap hides keyboard and with the second tap it puts Status app on background)
  7. Open Status from background.
  8. Tap 'Cancel' which is next to Search input
  9. On Chats view now pull down for Search input.
    Actual result: No Search input appears
    Expected result: Search input appears

VIdeo: https://drive.google.com/file/d/1J7Pxrrt47zvqdISofAjM24ZdKnLw2boK/view?usp=sharing

@rasom rasom closed this Jun 25, 2019
@rasom rasom force-pushed the serach-input-native-driver branch from 8222008 to 8321346 Compare June 25, 2019 09:33
@rasom rasom reopened this Jun 25, 2019
@rasom rasom force-pushed the serach-input-native-driver branch from 7524f1d to 9fa2053 Compare June 25, 2019 10:41
@rasom
Copy link
Contributor Author

rasom commented Jun 25, 2019

@Serhy should be fixed now

@Serhy
Copy link
Contributor

Serhy commented Jun 25, 2019

Thanks, @rasom. Looks cool! All issues above are fixed, no regressions, search input appears/disappears smoother that in release build.

@rasom rasom force-pushed the serach-input-native-driver branch from 9fa2053 to cd968cc Compare June 25, 2019 12:12
@rasom rasom merged commit cd968cc into develop Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the serach-input-native-driver branch June 25, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda Awaiting requested review from yenda

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
performance Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rasom @status-im-auto @statustestbot @Serhy @mandrigin @flexsurfer