Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stickers panel animation with native driver #8465

Merged
merged 1 commit into from
Jun 24, 2019
Merged

stickers panel animation with native driver #8465

merged 1 commit into from
Jun 24, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jun 22, 2019 •
edited
Loading

status: ready

@rasom rasom requested a review from a team as a code owner June 22, 2019 07:44
@auto-assign auto-assign bot removed the request for review from a team June 22, 2019 07:44
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom self-assigned this Jun 22, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 22, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4e2f19d #1 2019-06-22 07:55:53 ~10 min android 📦 apk
✔️ 4e2f19d #1 2019-06-22 07:56:56 ~11 min ios 📦 ipa
✔️ 4e2f19d #1 2019-06-22 08:00:38 ~15 min macos 📦 dmg
✔️ 4e2f19d #1 2019-06-22 08:01:31 ~16 min windows 📦 exe
✔️ 4e2f19d #1 2019-06-22 08:01:39 ~16 min android-e2e 📦 apk
✔️ 4e2f19d #1 2019-06-22 08:02:35 ~17 min linux 📦 App
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d5962c3 #2 2019-06-24 12:48:37 ~16 min ios 📦 ipa
✔️ d5962c3 #2 2019-06-24 15:00:30 ~16 min macos 📦 dmg
✔️ d5962c3 #2 2019-06-24 15:04:45 ~21 min windows 📦 exe
✔️ d5962c3 #2 2019-06-24 15:05:04 ~21 min linux 📦 App
✔️ d5962c3 #2 2019-06-24 15:06:13 ~23 min android 📦 apk
✔️ d5962c3 #2 2019-06-24 15:06:33 ~22 min android-e2e 📦 apk
✔️ cd56765 #3 2019-06-24 15:39:29 ~10 min ios 📦 ipa
✔️ cd56765 #3 2019-06-24 15:40:37 ~11 min android-e2e 📦 apk
✔️ cd56765 #3 2019-06-24 15:41:15 ~12 min macos 📦 dmg
✔️ cd56765 #3 2019-06-24 15:42:55 ~13 min android 📦 apk
✔️ cd56765 #3 2019-06-24 15:44:33 ~15 min linux 📦 App
✔️ cd56765 #3 2019-06-24 15:46:41 ~17 min windows 📦 exe

@statustestbot
Copy link

57% of end-end tests have passed

Total executed tests: 47
Failed tests: 20
Passed tests: 27

Failed tests (20)

Click to expand
1. test_block_user_from_public_chat

Device 1: Tap on SignInButton
Device 1: Tap on PlusButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

2. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

3. test_open_transaction_on_etherscan

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

4. test_add_to_contacts

Device 2: Tap on CrossIcon
Device 2: Tap on EditButton

Device 2: 'EditPictureButton' is not found on the screen

Device sessions

5. test_logcat_send_transaction_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

6. test_send_token_with_7_decimals

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

7. test_send_eth_from_wallet_to_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

8. test_manage_assets

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

9. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

10. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

11. test_search_chat_on_home

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Device 1: 'SearchChatInput' is not found on the screen

Device sessions

12. test_send_tokens_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

13. test_network_mismatch_for_send_request_commands

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

14. test_send_stt_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

15. test_send_eth_from_wallet_to_contact

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

16. test_offline_status

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'home_button'

Device sessions

17. test_user_can_remove_profile_picture

Device 1: Wait for ShareMyProfileButton
Device 1: Tap on EditButton

Device 1: 'EditPictureButton' is not found on the screen

Device sessions

18. test_share_contact_code_and_wallet_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

19. test_request_eth_in_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

20. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

Passed tests (27)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_deploy_contract_from_daap
Device sessions

5. test_public_chat_messaging
Device sessions

6. test_long_press_to_delete_1_1_chat
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_sign_typed_message (TestRail link is not found)
Device sessions

10. test_unread_messages_counter_1_1_chat
Device sessions

11. test_logcat_send_transaction_from_daap
Device sessions

12. test_send_message_in_group_chat
Device sessions

13. test_long_press_to_delete_public_chat
Device sessions

14. test_send_emoji
Device sessions

15. test_logcat_recovering_account
Device sessions

16. test_messaging_in_different_networks
Device sessions

17. test_logcat_sign_message_from_daap
Device sessions

18. test_switch_users_and_add_new_account
Device sessions

19. test_login_with_new_account
Device sessions

20. test_add_contact_from_public_chat
Device sessions

21. test_send_two_transactions_one_after_another_in_dapp
Device sessions

22. test_password_in_logcat_creating_account
Device sessions

23. test_backup_recovery_phrase
Device sessions

24. test_open_google_com_via_open_dapp
Device sessions

25. test_unread_messages_counter_public_chat
Device sessions

26. test_sign_message_from_daap
Device sessions

27. test_refresh_button_browsing_app_webview
Device sessions

@weekly-digest weekly-digest bot mentioned this pull request Jun 23, 2019
Closed
@Serhy Serhy self-assigned this Jun 24, 2019
@Serhy
Copy link
Contributor

Serhy commented Jun 24, 2019

@rasom, there is a regression here: there are no sticker panel elements are present in a case when sticker panel opens while device keyboard is active. Please see video and scenario below:

  1. Open Status and create new account
  2. Join public chat
  3. Tap inside the message box area. (Device keyboard appears at this point)
  4. Tap upon 'Stickers' icon from the message box
    Actual result: Empty Stickers panel.
    Expected result: Get stickers button, (+) button, 🕓button are present in the stickers panel.

Screenshot 2019-06-24 at 12 37 15

However if to proceed:
5) Tap in the chat view. (Device keyboard hides at this point)
6) Tap upon 'Stickers' icon from the message box
Actual result = Expected result: Sticker panel elements are present as expected.

Video: https://drive.google.com/file/d/1_SZqKS4BhpxxGChlMkv7TORooFQ_9lPg/view?usp=sharing

@rasom
Copy link
Contributor Author

rasom commented Jun 24, 2019

@Serhy should be fixed now

@Serhy
Copy link
Contributor

Serhy commented Jun 24, 2019

Tested with Android 8.1, iOS 12 and MasOS and no regressions found.
Thanks, @rasom !

@rasom rasom merged commit cd56765 into develop Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the stickers-panel-animation branch June 24, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda Awaiting requested review from yenda

@dmitryn dmitryn Awaiting requested review from dmitryn

Assignees
No one assigned
Labels
performance Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rasom @status-im-auto @statustestbot @Serhy @mandrigin @flexsurfer