e2e for mobile data sync #9085
Merged
e2e for mobile data sync #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (18)
|
Serhy
approved these changes
Oct 1, 2019
churik
changed the title
churik
force-pushed
the
tests/mobile-popup
branch
from
71db00c
to
9eb71a6
Compare
Serhy
approved these changes
Oct 3, 2019
Comment on lines
+54
to
+56
| if not chat.chat_element_by_text(message).is_element_displayed(): | ||
| self.errors.append("Message was not sent!") |
There was a problem hiding this comment.
I'd check here the message status after it sent rather than message itself
There was a problem hiding this comment.
It makes more sense on IOS, on Android you can't even send a message from offline.
But I can add check
There was a problem hiding this comment.
also, please add self.verify_no_errors() in the end of the test
|
Well done, @churik! |
antdanchenko
reviewed
Oct 3, 2019
| self.errors.append("Mobile data is enabled by default") | ||
| if not profile_view.ask_me_when_on_mobile_network.attribute_value("checked"): | ||
| self.errors.append("'Ask me when on mobile network' is not enabled by default") | ||
|
|
There was a problem hiding this comment.
please, add self.verify_no_errors()
antdanchenko
requested changes
Oct 3, 2019
churik
force-pushed
the
tests/mobile-popup
branch
2 times, most recently
from
1399d78
to
8b57a9c
Compare
|
@antdanchenko thanks for stepping in! |
antdanchenko
approved these changes
Oct 4, 2019
Signed-off-by: Churikova Tetiana <churikova.tm@gmail.com>
churik
force-pushed
the
tests/mobile-popup
branch
from
8b57a9c
to
da4fb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 tests about mobile sync after fix #8973