[#8446] [Multi-Account] Build account settings for individual wallet #9158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (18)
|
flexsurfer
force-pushed
the
feature/account-settings
branch
from
859cd33 to
3fa607e
Compare
flexsurfer
changed the title
|
iOS build link does not seem to work, will test on Android tho |
|
@andmironov please wait for the latest build, ios builds should work, @churik @jakubgs ? |
andmironov
reviewed
Oct 16, 2019
There was a problem hiding this comment.
Bugs I spotted on Android:
- If I change the name of the account and tap "Apply" the keyboards does not get hidden;
- If I change the name of the account it does not change;
- If I change the color of the account it does not change;
- There is an extra margin before "Account name";
- There's no bottom padding below "Storage: This device" (My Nexus' screen height is exactly the same as the height of this screen);
Here's a screenshot with all the margins and paddings issues I'm talking about
|
sorry @andmironov you were reviewing stale build, i've added bottom padding, but not sure about extra margin before "Account name"; thanks |
flexsurfer
force-pushed
the
feature/account-settings
branch
from
73e2801 to
ccdb935
Compare
|
@siphiuel @dmitryn, please review |
|
@yenda @siphiuel please review |
vitvly
approved these changes
Oct 18, 2019
| {:events [:wallet.accounts/save-account]} | ||
| [{:keys [db] :as cofx} account {:keys [name color]}] | ||
| (let [{:keys [accounts]} (:multiaccount db) | ||
| new-account (cond-> account |
There was a problem hiding this comment.
Maybe we can do (merge account new-account) here to avoid name/color duplication.
flexsurfer
force-pushed
the
feature/account-settings
branch
2 times, most recently
from
c57eb90 to
0a386ee
Compare
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/account-settings
branch
from
0a386ee to
1c51731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8446
tested on ios simulator, edit account