Check for empty public key #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
rasom
approved these changes
Feb 7, 2020
Jenkins BuildsClick to see older builds (6)
|
flexsurfer
requested changes
Feb 7, 2020
| @@ -9,9 +9,12 @@ | |||
| [{:keys [multiaccount]} public-key] | |||
| (= (:public-key multiaccount) public-key)) | |||
|
|
|||
| (def empty-public-key "0x0400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000") | |||
There was a problem hiding this comment.
cammellos
force-pushed
the
bug/ens-wrong-key
branch
from
11bc3a4
to
20786b8
Compare
flexsurfer
approved these changes
Feb 7, 2020
cammellos
force-pushed
the
bug/ens-wrong-key
branch
from
20786b8
to
fa6a9ee
Compare
yenda
approved these changes
Feb 7, 2020
cammellos
force-pushed
the
bug/ens-wrong-key
branch
from
fa6a9ee
to
8af7b1d
Compare
We check that ENS does not return an empty public key. In addition to that validation is done on status-go in order to avoid saving the chat. Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
cammellos
force-pushed
the
bug/ens-wrong-key
branch
from
8af7b1d
to
3d4ee8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check that ENS does not return an empty public key. In addition to
that validation is done on status-go in order to avoid saving the chat.
status: ready