From 74fd7e09a661f3042f420f1326195e7b38088eab Mon Sep 17 00:00:00 2001 From: Pranav <85227306+Pranavchiku@users.noreply.github.com> Date: Sun, 17 Mar 2024 20:53:07 +0530 Subject: [PATCH] chore: apply suggestions from code review Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> --- .../benchmark/benchmark.native.js | 2 +- .../base/assert/is-composite/manifest.json | 37 +------------------ .../math/base/assert/is-composite/src/main.c | 2 - 3 files changed, 2 insertions(+), 39 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/assert/is-composite/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/assert/is-composite/benchmark/benchmark.native.js index b5d4c5f41b2..ffc4588b445 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-composite/benchmark/benchmark.native.js +++ b/lib/node_modules/@stdlib/math/base/assert/is-composite/benchmark/benchmark.native.js @@ -44,7 +44,7 @@ bench( pkg+'::native', opts, function benchmark( b ) { b.tic(); for ( i = 0; i < b.iterations; i++ ) { bool = isComposite( i + 1 ); - if ( typeof bool !== 'boolean' ) { + if ( !isBoolean( bool ) ) { b.fail( 'should return a boolean' ); } } diff --git a/lib/node_modules/@stdlib/math/base/assert/is-composite/manifest.json b/lib/node_modules/@stdlib/math/base/assert/is-composite/manifest.json index 16d3f08a7c9..e139b0cc68c 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-composite/manifest.json +++ b/lib/node_modules/@stdlib/math/base/assert/is-composite/manifest.json @@ -1,7 +1,5 @@ { - "options": { - "task": "build" - }, + "options": {}, "fields": [ { "field": "src", @@ -26,39 +24,6 @@ ], "confs": [ { - "task": "build", - "src": [ - "./src/main.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/math/base/assert/is-prime", - "@stdlib/math/base/assert/is-integer", - "@stdlib/constants/float64/pinf" - ] - }, - { - "task": "benchmark", - "src": [ - "./src/main.c" - ], - "include": [ - "./include" - ], - "libraries": [], - "libpath": [], - "dependencies": [ - "@stdlib/math/base/assert/is-prime", - "@stdlib/math/base/assert/is-integer", - "@stdlib/constants/float64/pinf" - ] - }, - { - "task": "examples", "src": [ "./src/main.c" ], diff --git a/lib/node_modules/@stdlib/math/base/assert/is-composite/src/main.c b/lib/node_modules/@stdlib/math/base/assert/is-composite/src/main.c index b4fbe764bba..f4b932447fa 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-composite/src/main.c +++ b/lib/node_modules/@stdlib/math/base/assert/is-composite/src/main.c @@ -20,8 +20,6 @@ #include "stdlib/math/base/assert/is_prime.h" #include "stdlib/math/base/assert/is_integer.h" #include "stdlib/constants/float64/pinf.h" -#include -#include /** * Returns a boolean indicating whether a number is a composite.