From 93560b988c750b47e68cf5a789cc5e9d74b8e2d8 Mon Sep 17 00:00:00 2001 From: RISHAV <115060907+rishav2404@users.noreply.github.com> Date: Sat, 19 Oct 2024 14:36:51 +0530 Subject: [PATCH] fix: ensure correct seed validation The previous implementation used a direct property check (`config.seed`), which could inadvertently treat falsy values, such as `0`, as missing, leading to incorrect seed validation. PR-URL: https://github.com/stdlib-js/stdlib/pull/3007 Closes: https://github.com/stdlib-js/stdlib/issues/2952 Reviewed-by: Athan Reines --- lib/node_modules/@stdlib/random/shuffle/lib/factory.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/random/shuffle/lib/factory.js b/lib/node_modules/@stdlib/random/shuffle/lib/factory.js index 91544cb5ddc..c3154b7313a 100644 --- a/lib/node_modules/@stdlib/random/shuffle/lib/factory.js +++ b/lib/node_modules/@stdlib/random/shuffle/lib/factory.js @@ -28,6 +28,7 @@ var deepCopy = require( '@stdlib/utils/copy' ); var floor = require( '@stdlib/math/base/special/floor' ); var randu = require( '@stdlib/random/base/mt19937' ).factory; var format = require( '@stdlib/string/format' ); +var hasOwnProp = require( '@stdlib/assert/has-own-property' ); var defaults = require( './defaults.json' ); var validate = require( './validate.js' ); @@ -63,7 +64,7 @@ function factory( config ) { throw err; } } - if ( config && config.seed ) { + if ( config && hasOwnProp( config, 'seed' ) ) { rand = randu({ 'seed': config.seed });