feat: add support for keyboard shortcuts #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented most of the keyboard shortcuts specified in stdlib-js#26 - Moved shortcuts prop and related methods to client.jsx - Made sure to not to overlap with the webaim keyboard shortcuts for web accessibility
|
@lovelindhoni Thanks for submitting this PR. To help with review, can you remove built file changes? The inclusion of those changes just creates diff noise and runs the risk of out-of-date build artifacts as we iterate during PR review. Once this PR is merged, we'll rebuild the site locally to include the proposed changes and push to GitHub. |
This reverts commit 9e12970.
- Implemented most of the keyboard shortcuts specified in stdlib-js#26 - Moved shortcuts prop and related methods to client.jsx - Made sure to not to overlap with the webaim keyboard shortcuts for web accessibility
|
Apologies @kgryte, I have removed the built file changes and created a new commit |
|
@kgryte is there any other changes that needs to be done? |
|
I'll need to pull down and play around. Likely won't be until this weekend that I'll get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26 .
Checklist
master.masterbranch.Description
Related Issues
This pull request:
Questions
I thought keyboard shortcuts for package changelog would be too verbose. Any comments on my decision will be welcomed.
Other
To toggle through themes, use shift + a, as proposed b wouldn't make much sense if multiple themes were supported. Clicking shift + a cycles through the available themes, as I believed specifying modifiers each time would be overkill.
@stdlib-js/reviewers