Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: responsive design needs to better accommodate the addition of the settings icon #41

Open
2 tasks done
kgryte opened this issue Oct 2, 2021 · 0 comments
Open
2 tasks done
Assignees
Labels

Comments

@kgryte
Copy link
Member

kgryte commented Oct 2, 2021

Description

Encountered an error when adjusting the viewport width to emulate various devices. Upon adding the settings icon, we didn't update the top-navigation styling to accommodate the icon at various device widths. Screenshots are included below:

Screen Shot 2021-10-02 at 1 02 26 PM

Screen Shot 2021-10-02 at 1 03 15 PM

Screen Shot 2021-10-02 at 1 01 24 PM

Screen Shot 2021-10-02 at 1 00 36 PM

We need to determine our strategy for incorporating settings in the top navigation.

Related Issues

None.

Questions

No.

Demo

No response

Reproduction

-   navigate to the documentation for a particular package.
-   open the inspector.
-   emulate various devices.
-   notice that, at certain widths, our responsive design breaks.

Expected Results

The expected behavior is that our design fluidly accommodates devices of most widths, barring possibly the smallest (such as Galaxy Fold).

Actual Results

Our design breaks.

Environments

Firefox, Chrome, Safari, Microsoft Edge, Internet Explorer, Other Browser

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte added the bug label Oct 2, 2021
@kgryte kgryte self-assigned this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant