Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement busy-status integration #21

Open
ghost opened this issue May 9, 2016 · 6 comments
Open

Implement busy-status integration #21

ghost opened this issue May 9, 2016 · 6 comments
Assignees

Comments

@ghost
Copy link

ghost commented May 9, 2016

Hello

I've recently begun requiring intentions for php-integrator-refactoring to allow the user to select contextual commands from the list. This works very well and I've now been wondering if it would be a good idea to have some kind of placeholder (i.e. "No intentions available") if none of the providers return any intentions (or some way of taking a look at and possibly updating the final combined list from all providers).

Thanks in advance

@steelbrain
Copy link
Owner

steelbrain commented May 9, 2016

We could have a notification but the IDE that this package was inspired from (PhpStorm) doesn't have do this. Can you please recommend a place to show this type of message?

@ghost
Copy link
Author

ghost commented May 9, 2016

It's a bit of a visual hint to the user. For example, suppose I have the following code:

public function test()
{

}

... where there is only an intent on the name of the method. If the user presses alt-enter on any other part of the code, no intentions will show up (which is of course, intended behavior). Showing the message here gives a form of "satisfaction" to the user that what he is trying to do did indeed do something (the intentions were requested) as opposed to "Did it do nothing at all, does the shortcut not work or are there simply no intentions available in this context?".

@steelbrain
Copy link
Owner

steelbrain commented May 9, 2016

Another thing I could think of is that we could keep the spinner of busy-signal spinning while the providers are doing their thing and stop it once it's done. Spinner moving and then stopping but no list popping up would mean that there's no intentions at that particular location.

We could show a notification but it would be too noisy

@ghost
Copy link
Author

ghost commented May 10, 2016

That would also be a good idea. I agree that too much noise is best avoided. As such, atom notifications are absolutely overkill. It would be possible to show it inside the intentions menu itself (as if it were some sort of intention), but then care should be taken that it doesn't hog the cursor or it can become a nuisance there as well.

Another idea would be to have some other kind of indication, such as the cursor shaking or a quickly fading out message of some kind, but that is probably a little too much ;-).

@steelbrain steelbrain changed the title Ability to show placeholder? Implement busy-status integration May 10, 2016
@steelbrain
Copy link
Owner

Great, I'll be implementing busy-signal and will see how it goes

@steelbrain steelbrain self-assigned this May 10, 2016
@steelbrain
Copy link
Owner

Hey sorry for lack of update but busy-signal is done and published, I'll be integrating it into this package soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant