Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): config name should be camel case #71

Merged
merged 1 commit into from
May 30, 2014
Merged

fix(config): config name should be camel case #71

merged 1 commit into from
May 30, 2014

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented May 30, 2014

When you observe a config value, it will be added into the atom.config and it not seems to be a good behavior to have not camel case config name.

screen shot 2014-05-30 at 3 21 15 pm

The issue #64 is affiliated I think.

@iam4x iam4x added the bug label May 30, 2014
@iam4x iam4x added this to the 0.4.9 milestone May 30, 2014
@park9140
Copy link

@iam4x, It's probably fine with the full written name. But given it is easier to read in the code this way I'm all for it.

park9140 added a commit that referenced this pull request May 30, 2014
fix(config): config name should be camel case
@park9140 park9140 merged commit 63d3739 into steelbrain:master May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants