Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Sending HMR 0" if --hmr not sent #78

Closed
appsforartists opened this issue Nov 4, 2016 · 2 comments
Closed

"Sending HMR 0" if --hmr not sent #78

appsforartists opened this issue Nov 4, 2016 · 2 comments
Assignees
@steelbrain
Labels
bug

Comments

@appsforartists
Copy link

It's easy for a new user to think that HMR is on, even if they forgot the --hmr flag, because the logs still mention it

Pundle:Server Sending HMR of 0 file(s) to 0 connection(s) +43s
Pundle:Watcher File Changed :: ~/pundle/packages/test/src/index.js +21s

Should HMR ever be off in the Dev Server? It should probably default to on. If it is off, HMR disabled is a better message than Sending HMR 0 file(s).
@steelbrain
Copy link
Owner

Sounds fair

@steelbrain steelbrain self-assigned this Nov 4, 2016
@steelbrain steelbrain added the bug label Nov 4, 2016
@steelbrain
Copy link
Owner

Fixed in Pundle v2Alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steelbrain steelbrain

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appsforartists @steelbrain