New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setChangeFrequency casts to string #95

Open

stefandoorn opened this issue Jul 1, 2019 · 1 comment

Milestone

Owner

stefandoorn commented Jul 1, 2019

Should we cast it on setting, or should we cast it on getting (or parsing)?

See

sitemap-plugin/src/Model/Url.php

Line 63 in 673fcd6

public function setChangeFrequency(ChangeFrequency $changeFrequency): void

stefandoorn added this to the v2.0 milestone

Collaborator

loevgaard commented Jul 2, 2019

Cast on setting so you only do it once. No reason to delay it. That's my opinion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment