Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with embroider & staticHelpers #44

Open
mydea opened this issue Mar 4, 2021 · 0 comments · May be fixed by #45
Open

Does not work with embroider & staticHelpers #44

mydea opened this issue Mar 4, 2021 · 0 comments · May be fixed by #45

Comments

@mydea
Copy link

mydea commented Mar 4, 2021

When using embroider to build an app & enabling staticHelpers, this resolver stops working. I made a reproduction here:

https://github.com/mydea/ember-issue-reproductions/tree/fn/embroider

What seems to be happening is that here:
https://github.com/stefanpenner/ember-strict-resolver/blob/master/addon/index.js#L114

It is returning undefined. It seems that require(moduleName) returns the constructor method of the helper instead of a module?

I am not sure if that belongs here on in https://github.com/embroider-build/embroider..?
@mydea mydea linked a pull request Mar 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle non-default exports with embroider mydea/ember-strict-resolver
1 participant
@mydea