Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for label selectors #43

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Add validation for label selectors #43

merged 2 commits into from
Feb 11, 2019

Conversation

stefanprodan
Copy link
Member

Reject deployment if the pod label selector doesn't match app: <DEPLOYMENT_NAME>

Fix: #42

- Reject deployment if the pod label selector doesn't match 'app: <DEPLOYMENT_NAME>'
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #43 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   56.75%   56.62%   -0.14%     
==========================================
  Files           9        9              
  Lines        1302     1305       +3     
==========================================
  Hits          739      739              
- Misses        436      438       +2     
- Partials      127      128       +1
Impacted Files Coverage Δ
pkg/controller/deployer.go 58.7% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217ef06...434c614. Read the comment docs.

@stefanprodan stefanprodan merged commit 8a03ae1 into master Feb 11, 2019
@stefanprodan stefanprodan deleted the app-validation branch February 11, 2019 09:55
@stefanprodan stefanprodan mentioned this pull request Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants