Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Git LFS #20

Closed
jkaan opened this issue Nov 30, 2019 · 4 comments
Closed

Support for Git LFS #20

jkaan opened this issue Nov 30, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jkaan
Copy link
Contributor

jkaan commented Nov 30, 2019

Hi there! I am wondering if it is possible to support Git LFS with this tool.

Is there a way that I could overwrite the Dockerfile or something so that I could install Git LFS before?

@stefanzweifel
Copy link
Owner

Hi Joey 👋

The only way you currently could do that is by forking the repo and update the Dockerfile and using your forks in GitHub Actions.

However, I'm open for pull requests. Git LFS supports seems something a lot of people could be using.

I haven't looked into Git LFS yet: Is there a drawback when LFS is installed globally? Maybe we can add an option flag like enable_lfs and only when the value is set to true, LFS is installed.

@stefanzweifel stefanzweifel added enhancement New feature or request help wanted Extra attention is needed labels Nov 30, 2019
@stefanzweifel
Copy link
Owner

Reading through the Git LFS docs there doesn't seem to be a problem, when we install LFS in repositories which do not have a LFS configurations.

As LFS configuration is stored in .gitattributes, we also don't have to expose a new configuration, where users would have to define, which file extensions they want to track in LFS.

Feel free to open a PR to update the Dockerfile; or I will look into this more next week.

@jkaan
Copy link
Contributor Author

jkaan commented Nov 30, 2019

@stefanzweifel What a fast response! I'll make a PR for it, should not be that much work.

@stefanzweifel
Copy link
Owner

Fixed in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants