Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

[Features] Replace youtube-dl-exec with our own stream module #851

Closed
Mednoob opened this issue Apr 1, 2022 · 1 comment · Fixed by #753
Closed

[Features] Replace youtube-dl-exec with our own stream module #851

Mednoob opened this issue Apr 1, 2022 · 1 comment · Fixed by #753
Labels
enhancement New feature or request feat: player

Comments

@Mednoob
Copy link
Contributor

Mednoob commented Apr 1, 2022

Apparently, when some of our users trying to install modules for Rawon the NPM doesn't install youtube-dl-exec. Why? because they don't have Python on their machine. "But you already added play-dl alternative right? So what's the problem?" The problem is that when they're trying to build the project, youtube-dl-exec is trying to be imported in the YTDLUtils.ts by ESLint. Then, yes as you might've thought, since youtube-dl-exec is not installed on their machine ESLint detect it as any. This leads to ESLint error. So, the alternative that I come up with is that we move youtube-dl-exec into a single stream module file so that the YTDLUtils can still get the types of the stream module.

@mzrtamp mzrtamp linked a pull request Apr 1, 2022 that will close this issue
2 tasks
@Mednoob
Copy link
Contributor Author

Mednoob commented Apr 8, 2022

Feature added in commit c65d96e

@Mednoob Mednoob closed this as completed May 4, 2022
@mzrtamp mzrtamp added enhancement New feature or request feat: player labels Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request feat: player
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants