Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

kelp showing/using overly rounded/low-preicision prices #110

Closed
paul-token opened this issue Feb 21, 2019 · 0 comments
Closed

kelp showing/using overly rounded/low-preicision prices #110

paul-token opened this issue Feb 21, 2019 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@paul-token
Copy link
Contributor

paul-token commented Feb 21, 2019

Describe the bug

When using ccxt via DATA_FEED_B_URL="ccxt-poloniex/ETH/USDT" in buysell.cfg, kelp's logs are showing 2019/02/21 00:56:42 price from exchange feed (ccxt-bittrex/ETH/USDT): bidPrice=147.0000000, askPrice=148.0000000, centerPrice=147.5000000, which seems to be overly rounded, whereas querying ccxt directly results in correct/more-precise prices.

Expected behavior

kelp should pull in (and use) more accurate prices when possible (for example, when using sdex)

Frequency

Seems to be always

Steps To Reproduce

Set up ccxt via DATA_FEED_B_URL="ccxt-poloniex/ETH/USDT" in a buysell.cfg

Your Environment

version: fixed_fee:v1.4.0-3-ga0362947
git branch: fixed_fee
git hash: a036294
build date: 20190220T231403Z
GOOS: linux
GOARCH: amd64

Context

With too low a precision value there are many cases where no trades will ever be made even though there could be a ~1% difference in certain assets (for example, with ETH)

@paul-token paul-token added the bug Something isn't working label Feb 21, 2019
@paul-token paul-token changed the title kelp showing overly rounded ETH prices kelp showing/using overly rounded/low-preicision prices Feb 21, 2019
@nikhilsaraf nikhilsaraf added this to the v1.5.0 milestone Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants