Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servics/horizon: send Retry-After header in rate-limited responses #4858

Open
mollykarcher opened this issue May 1, 2023 · 0 comments
Open
Labels

Comments

@mollykarcher
Copy link
Contributor

What problem does your feature solve?

From lightsail-network/java-stellar-sdk#433

Some horizon instances do not populate the Retry-After header (horizon.stellar.org for example)

What would you like to see?

We should make sure we're sending this header on rate-limited responses. There is rate limiting that is handled directly in horizon application-code, but our public horizon instance (horizon.stellar.org) has disabled the application-code level rate limiting and is rate-limiting at the infra level in AWS WAF. We'll need to make sure this header is returned in both of these places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant