Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on GoConvey #638

Closed
kr opened this issue Sep 6, 2018 · 5 comments · Fixed by #706
Closed

Remove dependency on GoConvey #638

kr opened this issue Sep 6, 2018 · 5 comments · Fixed by #706

Comments

@kr
Copy link
Contributor

kr commented Sep 6, 2018

In #635 (comment), @bartekn says that this codebase wants to move away from GoConvey. I 100% support this direction, so here's an issue to discuss and track progress on that.

We might start opening pull requests to convert tests if that would make sense!
@kr kr changed the title Update all tests to stop using goconvey Remove dependency on GoConvey Sep 6, 2018
This was referenced Sep 7, 2018
Merged
Merged
Merged
Closed
Merged
Merged
This was referenced Sep 15, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@lechengfan lechengfan mentioned this issue Sep 26, 2018
Merged
@lechengfan
Copy link
Contributor

Go Convey should be completely removed now

@kr
Copy link
Contributor Author

kr commented Oct 2, 2018

Nice!

@kr kr closed this as completed Oct 2, 2018
@bartekn
Copy link
Contributor

bartekn commented Oct 4, 2018

Can you also remove it from Gopkg.lock?

@bartekn bartekn reopened this Oct 4, 2018
@lechengfan
Copy link
Contributor

Isn't Gopkg.lock something that's automatically generated by dep ensure -v? As in when users run dep ensure for the first time, it'll get rid of the convey deps

@bartekn
Copy link
Contributor

bartekn commented Oct 4, 2018

I mean we should regenerate it so that running dep ensure after cloning the repo doesn't make any changes to the working directory.

@lechengfan lechengfan mentioned this issue Oct 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gopkg after removing goconvey
3 participants
@kr @bartekn @lechengfan