clients/horizonclient: fix theoretical bug in currentServerTime #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erTime isn't contained in the global ServerTimeMap.
tsachiherman
commented
Sep 19, 2022
leighmcculloch
requested review from
ire-and-curses
and removed request for
leighmcculloch
sreuland
reviewed
Sep 20, 2022
sreuland
reviewed
Sep 21, 2022
sreuland
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code in currentServerTime was not testing the existence of the entry in
ServerTimeMapcorrectly. As a result, it would have missed the case where an entry could be missing from the map.That being said, this is a benign bug. It would never triggered unless the clock is set around epoch time ( which is not really realistic ). This fix is just to make sure that our code is correct. There should be no expectation of any behavioral change.
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
The logic of
currentServerTimeis being update to properly test for absence of hosts entry in the map.Why
Potential issue was found during code review.
Known limitations
N/A