-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestion filtering should use OR logic for rules rather than AND #5303
Ingestion filtering should use OR logic for rules rather than AND #5303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. left some comments on additional test coverage for consideration.
wanted to also suggest for consideration, would be worthwhile to add a changelog entry under Unreleased
for this so that you can provide a more detailed description for it, as this is changing the inclusion behavior of filters and so, can highlight this as a 'breaking' change under Unreleased
, otherwise the next release process would probably not pick up on this meaning, and it would just be added under general changes with the pr title.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
#5304
Why
We want transactions to be stored if it matches atleast one of the ingestion filtering rules.
Known limitations
[TODO or N/A]