Added ResultCodes to SubmitTransactionResponse

lightsail-network · Feb 24, 2016 · 79e2260 · 79e2260
1 parent de09803
commit 79e2260
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 3 deletions.
diff --git a/readme.md b/readme.md
@@ -2,7 +2,7 @@
 
 [![Build Status](https://travis-ci.org/stellar/java-stellar-sdk.svg)](https://travis-ci.org/stellar/java-stellar-sdk)
 
-This library provides API to connect to [horizon](https://github.com/stellar/horizon).
+This library provides API to build transactions and connect to [Horizon](https://github.com/stellar/horizon).
 
 ### Download
 

diff --git a/src/main/java/org/stellar/sdk/requests/TooManyRequestsException.java b/src/main/java/org/stellar/sdk/requests/TooManyRequestsException.java
@@ -14,7 +14,6 @@ public TooManyRequestsException(int retryAfter) {
 
   /**
    * Returns number of seconds a client should wait before sending requests again.
-   * @return
    */
   public int getRetryAfter() {
     return retryAfter;

diff --git a/src/main/java/org/stellar/sdk/responses/SubmitTransactionResponse.java b/src/main/java/org/stellar/sdk/responses/SubmitTransactionResponse.java
@@ -4,6 +4,8 @@
 
 import org.stellar.sdk.Server;
 
+import java.util.ArrayList;
+
 /**
  * Represents server response after submitting transaction.
  * @see Server#submitTransaction(org.stellar.sdk.Transaction)
@@ -34,6 +36,9 @@ public Long getLedger() {
         return ledger;
     }
 
+    /**
+     * Additional information returned by a server. This will be <code>null</code> if transaction succeeded.
+     */
     public Extras getExtras() {
         return extras;
     }
@@ -46,10 +51,13 @@ public static class Extras {
         private final String envelopeXdr;
         @SerializedName("result_xdr")
         private final String resultXdr;
+        @SerializedName("result_codes")
+        private final ResultCodes resultCodes;
 
-        Extras(String envelopeXdr, String resultXdr) {
+        Extras(String envelopeXdr, String resultXdr, ResultCodes resultCodes) {
             this.envelopeXdr = envelopeXdr;
             this.resultXdr = resultXdr;
+            this.resultCodes = resultCodes;
         }
 
         /**
@@ -67,5 +75,36 @@ public String getEnvelopeXdr() {
         public String getResultXdr() {
             return resultXdr;
         }
+
+        /**
+         * Returns ResultCodes object that contains result codes for transaction.
+         */
+        public ResultCodes getResultCodes() {
+            return resultCodes;
+        }
+
+        /**
+         * Contains result codes for this transaction.
+         * @see <a href="https://github.com/stellar/horizon/blob/master/src/github.com/stellar/horizon/codes/main.go" target="_blank">Possible values</a>
+         */
+        public static class ResultCodes {
+            @SerializedName("transaction")
+            private final String transactionResultCode;
+            @SerializedName("operations")
+            private final ArrayList<String> operationsResultCodes;
+
+            public ResultCodes(String transactionResultCode, ArrayList<String> operationsResultCodes) {
+                this.transactionResultCode = transactionResultCode;
+                this.operationsResultCodes = operationsResultCodes;
+            }
+
+            public String getTransactionResultCode() {
+                return transactionResultCode;
+            }
+
+            public ArrayList<String> getOperationsResultCodes() {
+                return operationsResultCodes;
+            }
+        }
     }
 }
diff --git a/src/test/java/org/stellar/sdk/ServerTest.java b/src/test/java/org/stellar/sdk/ServerTest.java
@@ -106,6 +106,7 @@ public void testSubmitTransactionSuccess() throws IOException {
         assertTrue(response.isSuccess());
         assertEquals(response.getLedger(), new Long(826150L));
         assertEquals(response.getHash(), "2634d2cf5adcbd3487d1df042166eef53830115844fdde1588828667bf93ff42");
+        assertNull(response.getExtras());
     }
 
     @Test
@@ -120,5 +121,8 @@ public void testSubmitTransactionFail() throws IOException {
         assertNull(response.getHash());
         assertEquals(response.getExtras().getEnvelopeXdr(), "AAAAAK4Pg4OEkjGmSN0AN37K/dcKyKPT2DC90xvjjawKp136AAAAZAAKsZQAAAABAAAAAAAAAAEAAAAJSmF2YSBGVFchAAAAAAAAAQAAAAAAAAABAAAAAG9wfBI7rRYoBlX3qRa0KOnI75W5BaPU6NbyKmm2t71MAAAAAAAAAAABMS0AAAAAAAAAAAEKp136AAAAQOWEjL+Sm+WP2puE9dLIxWlOibIEOz8PsXyG77jOCVdHZfQvkgB49Mu5wqKCMWWIsDSLFekwUsLaunvmXrpyBwQ=");
         assertEquals(response.getExtras().getResultXdr(), "AAAAAAAAAGT/////AAAAAQAAAAAAAAAB////+wAAAAA=");
+        assertNotNull(response.getExtras());
+        assertEquals("tx_failed", response.getExtras().getResultCodes().getTransactionResultCode());
+        assertEquals("op_no_destination", response.getExtras().getResultCodes().getOperationsResultCodes().get(0));
     }
 }