Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shade kotlin dependencies #448

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Shade kotlin dependencies #448

merged 2 commits into from
Jul 25, 2022

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jul 25, 2022

Close #446

In the 0.35.0 release we upgraded the com.squareup.okhttp3:okhttp dependency from v3 to v4. Bumping that dependency pulled in a dependency on kotlin. This causes "Duplicate Class" errors when using the java stellar sdk on kotlin projects. The fix for this issue is to properly shade all the kotlin dependencies.

Copy link
Contributor

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tamirms tamirms merged commit 7ad758b into master Jul 25, 2022
@tamirms tamirms deleted the shade-kotlin-deps branch July 25, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.35.0 'Build failed' error with the several 'Duplicate class' errors
3 participants