Improve the reliability of SSEStream.
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcat
changed the title
SSEStream.
sreuland
reviewed
Nov 7, 2023
| // Start a timer to check if the client has not received any event for a long time. | ||
| // If so, we will close the connection and restart it. | ||
| latestEventTime.set(System.currentTimeMillis()); | ||
| clientTimeoutTimer.scheduleAtFixedRate( |
There was a problem hiding this comment.
rather than another thread, can this be run in the start thread loop - https://github.com/stellar/java-stellar-sdk/pull/555/files#diff-e2dabf286e824384ee81a568eccc0deaea2558961523521b93f048abb37792baR77
sreuland
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #463, fix #432, fix #210.
Restart SSE to improve reliability if no new messages are received within the timeout period.