Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code. #562

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

overcat
Copy link
Member

@overcat overcat commented Jan 6, 2024

This code refactoring does not bring any new functionality additions, nor does it bring any breaking changes.

The main aspects of the refactoring are as follows:

  1. Use Lombok to reduce duplicate code (this also allows us to add toString, hashCode, and equals methods to most classes)
  2. Updated some documentation
  3. Fixed some warnings.
  4. Modified the style of some code.

This is a larger PR, but I hardly modified the test code to prove that there were no destructive changes.

This code refactoring does not bring any new functionality additions, nor does it bring any breaking changes.
The main aspects of the refactoring are as follows:
1. Use Lombok to reduce duplicate code (this also allows us to add `toString`, `hashCode`, and `equals` methods to most classes)
2. Updated some documentation
3. Fixed some warnings.
4. Modified the style of some code.
@overcat
Copy link
Member Author

overcat commented Jan 11, 2024

Hi @sreuland @tamirms, do you have the bandwidth to review this PR in the near future?

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, net reduction of about 2300 lines of source code!

@overcat overcat merged commit 97e0295 into lightsail-network:master Jan 11, 2024
6 checks passed
@overcat overcat deleted the refactor branch January 11, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants