Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransactionBuilder#TransactionBuilder(Transaction) constructor. #567

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

overcat
Copy link
Member

@overcat overcat commented Jan 12, 2024

Closes #456

See #456 (comment)

Other option is to rebuild the tx with TransactionBuilder, and then re-invoke the sign() methods to build out the signatures again.

@overcat overcat requested a review from sreuland January 12, 2024 08:57
*
* @param transaction the transaction to rebuild
*/
public TransactionBuilder(Transaction transaction) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this builder pattern is good way to maintain immutability and convenience!

@overcat overcat merged commit 48599b5 into lightsail-network:master Jan 13, 2024
5 checks passed
@overcat overcat deleted the tx-builder branch January 13, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signers were made immutable causing a breaking change
2 participants